reworked restart/update-cert path to always trigger update before restart #270
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Fixes #265
Solution
Reworked the
restart_grafana
method to always call_update_cert
ifCertHandler.enabled
.Together with a unified
_cert_ready
method that verifies that the cert and key files are on the container filesystem, this should ensure a (more) robust flow:To test:
charmcraft pack
deploy this bundle
Then deploy grafana:
juju deploy ./grafana-k8s.charm --resource grafana-image=docker.io/ubuntu/grafana:9.2-22.04_beta --resource litestream-image=docker.io/litestream/litestream:0.4.0-beta.2
Once all is active/idle, do a
jhack imatrix fill
to cross-relate