Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IAM 1064 Don't request audience in login request #428

Merged
merged 1 commit into from
Sep 27, 2024

Conversation

BarcoMasile
Copy link
Contributor

@BarcoMasile BarcoMasile commented Sep 26, 2024

Description

Remove the audience parameter from the oauth2 login redirection and adjusts tests accordingly.

This was manually tested also, and the jwt minted by hydra are still the same as expected.

Fixes #415

@BarcoMasile BarcoMasile requested a review from a team as a code owner September 26, 2024 14:43
pkg/ui/handlers.go Outdated Show resolved Hide resolved
@BarcoMasile BarcoMasile force-pushed the IAM-1064-remove-aud-from-request branch from 0378f17 to 4bad945 Compare September 27, 2024 08:05
@BarcoMasile BarcoMasile merged commit a2d6337 into main Sep 27, 2024
10 checks passed
@BarcoMasile BarcoMasile deleted the IAM-1064-remove-aud-from-request branch September 27, 2024 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Do not request for the audience to include the client_id
4 participants