fix(request) avoid using request url in the ui. fixes #289 #298
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nsklikas
reviewed
Sep 30, 2024
edlerd
force-pushed
the
remove-request-url
branch
from
03e5b0e
to
d53dcad
Compare
Signed-off-by: David Edler <david.edler@canonical.com>
edlerd
force-pushed
the
remove-request-url
branch
from
d53dcad
to
53db067
Compare
Yes, you are right. Changed the approach and unified a bit across all pages. |
nsklikas
approved these changes
Oct 1, 2024
Comment on lines
-56
to
+54
| await router.replace( | ||
| { | ||
| pathname: window.location.pathname, | ||
| query: router.query, | ||
| }, | ||
| undefined, | ||
| { shallow: true }, | ||
| ); | ||
| .then(({ data }) => { | ||
| const pwParam = pwChanged ? `&pw_changed=${pwChanged.toString()}` : ""; | ||
| if (flowId !== data.id) { | ||
| window.history.replaceState( |
There was a problem hiding this comment.
question: Is router.replace and window.history.replaceState the same API and the 1st is the nextjs way of interacting with the history API? In that case why don't we use the tool provided from the framework?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Done
fixes #289