Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(request) avoid using request url in the ui. fixes #289 #298

Merged
merged 1 commit into from
Oct 1, 2024
Merged

fix(request) avoid using request url in the ui. fixes #289 #298

merged 1 commit into from
Oct 1, 2024

Conversation

edlerd
Copy link
Contributor

@edlerd edlerd commented Sep 30, 2024

Done

  • fix(request) avoid using request url in the ui.

fixes #289

@edlerd edlerd requested a review from a team as a code owner September 30, 2024 14:16
nsklikas
nsklikas reviewed Sep 30, 2024
View reviewed changes
Copy link
Contributor

@nsklikas nsklikas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought setting the flow=<flow_id> in the url was intentional, are we sure we want to remove that?

@edlerd
fix(request) avoid using request url in the ui. fixes canonical#289
53db067 
Signed-off-by: David Edler <david.edler@canonical.com>
@edlerd
Copy link
Contributor Author

edlerd commented Sep 30, 2024

I thought setting the flow=<flow_id> in the url was intentional, are we sure we want to remove that?

Yes, you are right. Changed the approach and unified a bit across all pages.

nsklikas
nsklikas approved these changes Oct 1, 2024
View reviewed changes
Copy link
Contributor

@nsklikas nsklikas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, but I have a question

ui/pages/setup_secure.tsx Show resolved Hide resolved
@nsklikas nsklikas merged commit 6536c67 into canonical:main Oct 1, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nsklikas nsklikas nsklikas approved these changes

@shipperizer shipperizer shipperizer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Invalid checks/redirects in UI
3 participants
@edlerd @shipperizer @nsklikas