Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can submit a reset password request even if an email is incorrect #385

Open
lukasSerelis opened this issue Dec 3, 2024 · 4 comments · May be fixed by #396
Open

Can submit a reset password request even if an email is incorrect #385

lukasSerelis opened this issue Dec 3, 2024 · 4 comments · May be fixed by #396
Labels
bug Something isn't working frontend This is a UI issue

Comments

@lukasSerelis
Copy link

Flow to reproduce:

Login page -> Click reset password -> Enter a non compliant email format that contains an @ (mail@mail for example) -> click Reset password -> You're taken to the next page even if there is an error on the entry field.
Also, even when the reset doesn't go through, example if you just entered "mail", it refreshes the page and gets rid of the validation error. That validation error should remain there and page shouldn't get refreshed.

Fix

Login page -> Click reset password -> Enter a non compliant email format that contains an @ (mail@mail for example) -> click Reset password -> nothing happens, as there is an error in the email field. There shouldn't be a refresh of the page, field error should remain active until fixed.

@lukasSerelis lukasSerelis added bug Something isn't working frontend This is a UI issue labels Dec 3, 2024
Copy link

Thank you for reporting us your feedback!

The internal ticket has been created: https://warthogs.atlassian.net/browse/IAM-1246.

This message was autogenerated

@edlerd
Copy link
Contributor

edlerd commented Dec 16, 2024

Afaik mail@mail can be a valid email, and we should not enforce that an addition top level domain is in the email address.

@edlerd
Copy link
Contributor

edlerd commented Dec 16, 2024

See the relevant rfc

@lukasSerelis
Copy link
Author

lukasSerelis commented Dec 16, 2024

The problem is that the field validation calls it out as an incorrect email address but I can still proceed as if there's no error. So what the system does VS what we tell the user is completely different.
image

edlerd added a commit to edlerd/identity-platform-login-ui that referenced this issue Dec 17, 2024
… invalid email address. fixes canonical#385

Signed-off-by: David Edler <david.edler@canonical.com>
edlerd added a commit to edlerd/identity-platform-login-ui that referenced this issue Dec 18, 2024
… invalid email address. fixes canonical#385

Signed-off-by: David Edler <david.edler@canonical.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working frontend This is a UI issue
Projects
None yet
2 participants