Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial implementation for embedded datastore #105

Merged
merged 18 commits into from
Jun 24, 2024
Merged

Conversation

neoaggelos
Copy link
Contributor

Summary

Add option to run in embedded datastore mode (using k8s-dqlite --embedded=true)

Changes

  • Implement embedded datastore in pkg/embedded
  • Add k8s-dqlite embeddedctl commands for managing cluster members and taking snapshots. These are meant to be commands that can be used to quickly interact with the cluster
  • Add a generic pkg/server.Instance interface, and use either pkg/server.(*Server), or pkg/embedded.(*embedded) when starting k8s-dqlite.

Notes

Embedded mode uses two config files, embedded.yaml (directly parsed by embed.ConfigFromFile) and config.yaml, which defines extra local node args and information to self-register on the local cluster.

Copy link
Contributor

@bschimke95 bschimke95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good to me. Only minor docs request.
Questions were already resolved offline.

cmd/root.go Outdated Show resolved Hide resolved
Copy link
Contributor

@bschimke95 bschimke95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@neoaggelos neoaggelos merged commit 6f4a785 into master Jun 24, 2024
9 checks passed
@berkayoz berkayoz deleted the KU-961/embedded branch September 2, 2024 07:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants