Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused GetRevision query #166

Merged
merged 1 commit into from
Sep 2, 2024
Merged

Conversation

marco6
Copy link
Collaborator

@marco6 marco6 commented Sep 2, 2024

GetRevision method (and the associated query) were used in the compaction only. Now no code calls that function.

As such, I removed it.

@marco6 marco6 requested a review from a team as a code owner September 2, 2024 10:07
Copy link
Contributor

@bschimke95 bschimke95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, good catch!

Copy link

github-actions bot commented Sep 2, 2024

Benchmark Result

goos: linux
goarch: amd64
pkg: github.com/canonical/k8s-dqlite/test
cpu: AMD EPYC 7763 64-Core Processor                
                                        │    Before     │                After                │
                                        │    sec/op     │    sec/op      vs base              │
Compaction/sqlite-4                        44.76µ ± 15%    40.91µ ± 12%       ~ (p=0.053 n=7)
Compaction/dqlite-4                        43.20µ ±  8%    42.46µ ±  4%       ~ (p=0.383 n=7)
Create/sqlite-4                            1.315m ± 11%    1.396m ± 14%       ~ (p=0.128 n=7)
Create/dqlite-4                            1.220m ± 14%    1.105m ± 11%       ~ (p=0.165 n=7)
Delete/sqlite-4                            1.612m ±  8%    1.480m ± 10%  -8.16% (p=0.001 n=7)
Delete/dqlite-4                            1.488m ±  7%    1.351m ±  8%  -9.16% (p=0.002 n=7)
Get/sqlite-4                               266.0µ ±  1%    270.6µ ±  0%  +1.75% (p=0.001 n=7)
Get/dqlite-4                               355.1µ ±  1%    356.1µ ±  2%       ~ (p=0.073 n=7)
Lease/sqlite-4                            100.49µ ±  3%    99.26µ ±  1%       ~ (p=0.165 n=7)
Lease/dqlite-4                             98.72µ ±  2%   100.25µ ±  1%  +1.55% (p=0.026 n=7)
List/sqlite-tiny/all-4                     4.427µ ±  3%    4.449µ ±  2%       ~ (p=0.902 n=7)
List/sqlite-tiny/pagination-4              9.175µ ±  3%    9.185µ ±  2%       ~ (p=0.902 n=7)
List/sqlite-fits-in-page/all-4             7.371µ ±  5%    7.318µ ±  4%       ~ (p=0.383 n=7)
List/sqlite-fits-in-page/pagination-4      23.09µ ±  6%    22.83µ ±  4%       ~ (p=1.000 n=7)
List/sqlite-overflows-page/all-4           18.07µ ±  5%    18.07µ ±  6%       ~ (p=1.000 n=7)
List/sqlite-overflows-page/pagination-4    48.80µ ±  4%    47.92µ ±  2%       ~ (p=0.053 n=7)
List/dqlite-tiny/all-4                     2.827µ ±  3%    2.756µ ±  9%  -2.51% (p=0.004 n=7)
List/dqlite-tiny/pagination-4              5.920µ ±  2%    5.977µ ±  2%       ~ (p=0.128 n=7)
List/dqlite-fits-in-page/all-4             6.202µ ±  6%    6.113µ ±  1%       ~ (p=0.209 n=7)
List/dqlite-fits-in-page/pagination-4      17.12µ ±  2%    17.06µ ±  3%       ~ (p=0.710 n=7)
List/dqlite-overflows-page/all-4           19.12µ ±  2%    19.15µ ±  1%       ~ (p=0.805 n=7)
List/dqlite-overflows-page/pagination-4    43.14µ ±  6%    43.79µ ±  4%       ~ (p=0.535 n=7)
Update/sqlite-4                            1.627m ±  7%    1.477m ± 12%  -9.22% (p=0.002 n=7)
Update/dqlite-4                            1.459m ±  9%    1.363m ±  8%       ~ (p=0.209 n=7)
geomean                                    69.25µ          67.77µ        -2.13%

                                        │        Before        │                    After                     │
                                        │ page-cache-misses/op │ page-cache-misses/op  vs base                │
Compaction/sqlite-4                               0.000 ± 0%               0.000 ± 0%       ~ (p=1.000 n=7) ¹
Compaction/dqlite-4                               0.000 ± 0%               0.000 ± 0%       ~ (p=1.000 n=7) ¹
Create/sqlite-4                                   0.000 ± 0%               0.000 ± 0%       ~ (p=1.000 n=7) ¹
Create/dqlite-4                                   0.000 ± 0%               0.000 ± 0%       ~ (p=1.000 n=7) ¹
Delete/sqlite-4                                   0.000 ± 0%               0.000 ± 0%       ~ (p=1.000 n=7) ¹
Delete/dqlite-4                                   0.000 ± 0%               0.000 ± 0%       ~ (p=1.000 n=7) ¹
Get/sqlite-4                                      0.000 ± 0%               0.000 ± 0%       ~ (p=1.000 n=7) ¹
Get/dqlite-4                                      0.000 ± 0%               0.000 ± 0%       ~ (p=1.000 n=7) ¹
Lease/sqlite-4                                    0.000 ± 0%               0.000 ± 0%       ~ (p=1.000 n=7) ¹
Lease/dqlite-4                                    0.000 ± 0%               0.000 ± 0%       ~ (p=1.000 n=7) ¹
List/sqlite-tiny/all-4                            0.000 ± 0%               0.000 ± 0%       ~ (p=1.000 n=7) ¹
List/sqlite-tiny/pagination-4                     0.000 ± 0%               0.000 ± 0%       ~ (p=1.000 n=7) ¹
List/sqlite-fits-in-page/all-4                    0.000 ± 0%               0.000 ± 0%       ~ (p=1.000 n=7) ¹
List/sqlite-fits-in-page/pagination-4             0.000 ± 0%               0.000 ± 0%       ~ (p=1.000 n=7) ¹
List/sqlite-overflows-page/all-4                  0.000 ± 0%               0.000 ± 0%       ~ (p=1.000 n=7) ¹
List/sqlite-overflows-page/pagination-4           0.000 ± 0%               0.000 ± 0%       ~ (p=1.000 n=7) ¹
List/dqlite-tiny/all-4                            0.000 ± 0%               0.000 ± 0%       ~ (p=1.000 n=7) ¹
List/dqlite-tiny/pagination-4                     0.000 ± 0%               0.000 ± 0%       ~ (p=1.000 n=7) ¹
List/dqlite-fits-in-page/all-4                    0.000 ± 0%               0.000 ± 0%       ~ (p=1.000 n=7) ¹
List/dqlite-fits-in-page/pagination-4             0.000 ± 0%               0.000 ± 0%       ~ (p=1.000 n=7) ¹
List/dqlite-overflows-page/all-4                  0.000 ± 0%               0.000 ± 0%       ~ (p=1.000 n=7) ¹
List/dqlite-overflows-page/pagination-4           0.000 ± 0%               0.000 ± 0%       ~ (p=1.000 n=7) ¹
Update/sqlite-4                                   0.000 ± 0%               0.000 ± 0%       ~ (p=1.000 n=7) ¹
Update/dqlite-4                                   0.000 ± 0%               0.000 ± 0%       ~ (p=1.000 n=7) ¹
geomean                                                      ²                         +0.00%               ²
¹ all samples are equal
² summaries must be >0 to compute geomean

                                        │        Before        │                    After                     │
                                        │ page-cache-spills/op │ page-cache-spills/op  vs base                │
Compaction/sqlite-4                               0.000 ± 0%               0.000 ± 0%       ~ (p=1.000 n=7) ¹
Compaction/dqlite-4                               0.000 ± 0%               0.000 ± 0%       ~ (p=1.000 n=7) ¹
Create/sqlite-4                                   0.000 ± 0%               0.000 ± 0%       ~ (p=1.000 n=7) ¹
Create/dqlite-4                                   0.000 ± 0%               0.000 ± 0%       ~ (p=1.000 n=7) ¹
Delete/sqlite-4                                   0.000 ± 0%               0.000 ± 0%       ~ (p=1.000 n=7) ¹
Delete/dqlite-4                                   0.000 ± 0%               0.000 ± 0%       ~ (p=1.000 n=7) ¹
Get/sqlite-4                                      0.000 ± 0%               0.000 ± 0%       ~ (p=1.000 n=7) ¹
Get/dqlite-4                                      0.000 ± 0%               0.000 ± 0%       ~ (p=1.000 n=7) ¹
Lease/sqlite-4                                    0.000 ± 0%               0.000 ± 0%       ~ (p=1.000 n=7) ¹
Lease/dqlite-4                                    0.000 ± 0%               0.000 ± 0%       ~ (p=1.000 n=7) ¹
List/sqlite-tiny/all-4                            0.000 ± 0%               0.000 ± 0%       ~ (p=1.000 n=7) ¹
List/sqlite-tiny/pagination-4                     0.000 ± 0%               0.000 ± 0%       ~ (p=1.000 n=7) ¹
List/sqlite-fits-in-page/all-4                    0.000 ± 0%               0.000 ± 0%       ~ (p=1.000 n=7) ¹
List/sqlite-fits-in-page/pagination-4             0.000 ± 0%               0.000 ± 0%       ~ (p=1.000 n=7) ¹
List/sqlite-overflows-page/all-4                  0.000 ± 0%               0.000 ± 0%       ~ (p=1.000 n=7) ¹
List/sqlite-overflows-page/pagination-4           0.000 ± 0%               0.000 ± 0%       ~ (p=1.000 n=7) ¹
List/dqlite-tiny/all-4                            0.000 ± 0%               0.000 ± 0%       ~ (p=1.000 n=7) ¹
List/dqlite-tiny/pagination-4                     0.000 ± 0%               0.000 ± 0%       ~ (p=1.000 n=7) ¹
List/dqlite-fits-in-page/all-4                    0.000 ± 0%               0.000 ± 0%       ~ (p=1.000 n=7) ¹
List/dqlite-fits-in-page/pagination-4             0.000 ± 0%               0.000 ± 0%       ~ (p=1.000 n=7) ¹
List/dqlite-overflows-page/all-4                  0.000 ± 0%               0.000 ± 0%       ~ (p=1.000 n=7) ¹
List/dqlite-overflows-page/pagination-4           0.000 ± 0%               0.000 ± 0%       ~ (p=1.000 n=7) ¹
Update/sqlite-4                                   0.000 ± 0%               0.000 ± 0%       ~ (p=1.000 n=7) ¹
Update/dqlite-4                                   0.000 ± 0%               0.000 ± 0%       ~ (p=1.000 n=7) ¹
geomean                                                      ²                         +0.00%               ²
¹ all samples are equal
² summaries must be >0 to compute geomean

                                        │    Before     │                After                │
                                        │ page-reads/op │ page-reads/op  vs base              │
Compaction/sqlite-4                         12.21 ±  1%    12.22 ±   1%       ~ (p=0.593 n=7)
Compaction/dqlite-4                         12.22 ±  1%    12.18 ±   1%       ~ (p=0.689 n=7)
Create/sqlite-4                             14.05 ± 15%    13.89 ±   2%       ~ (p=0.902 n=7)
Create/dqlite-4                             12.99 ±  3%    12.95 ±   1%       ~ (p=0.833 n=7)
Delete/sqlite-4                             24.98 ±  2%    25.09 ±   6%       ~ (p=0.512 n=7)
Delete/dqlite-4                             23.84 ±  1%    23.71 ±   1%       ~ (p=0.512 n=7)
Get/sqlite-4                                14.96 ±  0%    14.95 ±   0%       ~ (p=0.388 n=7)
Get/dqlite-4                                11.97 ±  0%    11.96 ±   0%       ~ (p=0.688 n=7)
Lease/sqlite-4                             800.0µ ± 77%   492.8µ ± 187%       ~ (p=0.246 n=7)
Lease/dqlite-4                             660.9µ ± 82%   800.0µ ±  50%       ~ (p=0.052 n=7)
List/sqlite-tiny/all-4                     192.3m ±  0%   192.3m ±   0%       ~ (p=0.971 n=7)
List/sqlite-tiny/pagination-4               1.132 ±  0%    1.132 ±   0%       ~ (p=1.000 n=7)
List/sqlite-fits-in-page/all-4             165.0m ±  0%   165.1m ±   0%       ~ (p=0.643 n=7)
List/sqlite-fits-in-page/pagination-4      965.4m ±  3%   965.5m ±   3%       ~ (p=0.476 n=7)
List/sqlite-overflows-page/all-4           315.6m ± 23%   321.3m ±  20%       ~ (p=0.902 n=7)
List/sqlite-overflows-page/pagination-4     2.081 ±  0%    2.080 ±   0%       ~ (p=0.592 n=7)
List/dqlite-tiny/all-4                     191.2m ±  0%   191.0m ±   1%  -0.10% (p=0.035 n=7)
List/dqlite-tiny/pagination-4               1.125 ±  3%    1.126 ±   0%       ~ (p=0.869 n=7)
List/dqlite-fits-in-page/all-4             163.2m ± 59%   163.1m ±   0%       ~ (p=0.427 n=7)
List/dqlite-fits-in-page/pagination-4      954.4m ±  0%   954.3m ±   3%       ~ (p=0.867 n=7)
List/dqlite-overflows-page/all-4           182.9m ±  0%   182.9m ±   0%       ~ (p=0.991 n=7)
List/dqlite-overflows-page/pagination-4     1.071 ±  3%    1.071 ±   3%       ~ (p=0.290 n=7)
Update/sqlite-4                             24.51 ±  3%    24.84 ±   3%       ~ (p=0.090 n=7)
Update/dqlite-4                             23.99 ±  2%    23.99 ±   2%       ~ (p=0.924 n=7)
geomean                                     1.227          1.212         -1.17%

                                        │     Before     │                 After                  │
                                        │ page-writes/op │ page-writes/op  vs base                │
Compaction/sqlite-4                        207.7m ± 1%        207.8m ± 1%       ~ (p=0.642 n=7)
Compaction/dqlite-4                        188.0m ± 0%        187.8m ± 1%       ~ (p=0.298 n=7)
Create/sqlite-4                             5.121 ± 1%         5.107 ± 1%       ~ (p=0.107 n=7)
Create/dqlite-4                             4.196 ± 1%         4.214 ± 2%       ~ (p=0.456 n=7)
Delete/sqlite-4                             5.311 ± 0%         5.320 ± 0%       ~ (p=0.558 n=7)
Delete/dqlite-4                             4.390 ± 1%         4.392 ± 1%       ~ (p=0.805 n=7)
Get/sqlite-4                                0.000 ± 0%         0.000 ± 0%       ~ (p=1.000 n=7) ¹
Get/dqlite-4                                0.000 ± 0%         0.000 ± 0%       ~ (p=1.000 n=7) ¹
Lease/sqlite-4                              0.000 ± 0%         0.000 ± 0%       ~ (p=1.000 n=7) ¹
Lease/dqlite-4                              0.000 ± 0%         0.000 ± 0%       ~ (p=1.000 n=7) ¹
List/sqlite-tiny/all-4                      0.000 ± 0%         0.000 ± 0%       ~ (p=1.000 n=7) ¹
List/sqlite-tiny/pagination-4               0.000 ± 0%         0.000 ± 0%       ~ (p=1.000 n=7) ¹
List/sqlite-fits-in-page/all-4              0.000 ± 0%         0.000 ± 0%       ~ (p=1.000 n=7) ¹
List/sqlite-fits-in-page/pagination-4       0.000 ± 0%         0.000 ± 0%       ~ (p=1.000 n=7) ¹
List/sqlite-overflows-page/all-4            0.000 ± 0%         0.000 ± 0%       ~ (p=1.000 n=7) ¹
List/sqlite-overflows-page/pagination-4     0.000 ± 0%         0.000 ± 0%       ~ (p=1.000 n=7) ¹
List/dqlite-tiny/all-4                      0.000 ± 0%         0.000 ± 0%       ~ (p=1.000 n=7) ¹
List/dqlite-tiny/pagination-4               0.000 ± 0%         0.000 ± 0%       ~ (p=1.000 n=7) ¹
List/dqlite-fits-in-page/all-4              0.000 ± 0%         0.000 ± 0%       ~ (p=1.000 n=7) ¹
List/dqlite-fits-in-page/pagination-4       0.000 ± 0%         0.000 ± 0%       ~ (p=1.000 n=7) ¹
List/dqlite-overflows-page/all-4            0.000 ± 0%         0.000 ± 0%       ~ (p=1.000 n=7) ¹
List/dqlite-overflows-page/pagination-4     0.000 ± 0%         0.000 ± 0%       ~ (p=1.000 n=7) ¹
Update/sqlite-4                             5.125 ± 0%         5.138 ± 1%       ~ (p=0.403 n=7)
Update/dqlite-4                             4.164 ± 0%         4.157 ± 1%       ~ (p=0.091 n=7)
geomean                                                ²                   +0.02%               ²
¹ all samples are equal
² summaries must be >0 to compute geomean

                                        │      Before       │                 After                  │
                                        │  sec-reading/op   │ sec-reading/op  vs base                │
Compaction/sqlite-4                        128.1µ ±   13%      120.3µ ±   9%       ~ (p=0.128 n=7)
Compaction/dqlite-4                        28.40µ ±   31%      26.40µ ±  37%       ~ (p=0.782 n=7)
Create/sqlite-4                            51.40µ ± 1748%     102.40µ ± 299%       ~ (p=0.710 n=7)
Create/dqlite-4                            10.30µ ±   53%      12.20µ ±  51%       ~ (p=0.402 n=7)
Delete/sqlite-4                            265.1µ ±  115%      175.6µ ± 386%       ~ (p=1.000 n=7)
Delete/dqlite-4                            54.90µ ±   31%      53.40µ ±  27%       ~ (p=1.000 n=7)
Get/sqlite-4                               87.50µ ±    5%      90.80µ ±   3%       ~ (p=0.073 n=7)
Get/dqlite-4                               33.40µ ±   14%      34.60µ ±  18%       ~ (p=0.318 n=7)
Lease/sqlite-4                             300.0n ±     ?      300.0n ±    ?       ~ (p=0.300 n=7)
Lease/dqlite-4                              0.000 ±    0%       0.000 ±   0%       ~ (p=1.000 n=7) ¹
List/sqlite-tiny/all-4                     14.60µ ±    4%      14.40µ ±   6%       ~ (p=0.114 n=7)
List/sqlite-tiny/pagination-4              20.40µ ±    4%      19.70µ ±   4%       ~ (p=0.558 n=7)
List/sqlite-fits-in-page/all-4             19.40µ ±   21%      17.60µ ±  19%       ~ (p=0.805 n=7)
List/sqlite-fits-in-page/pagination-4      63.30µ ±    5%      63.00µ ±   5%       ~ (p=0.976 n=7)
List/sqlite-overflows-page/all-4           68.80µ ±   13%      69.90µ ±  18%       ~ (p=0.383 n=7)
List/sqlite-overflows-page/pagination-4    180.7µ ±    1%      176.9µ ±   1%  -2.10% (p=0.001 n=7)
List/dqlite-tiny/all-4                     4.700µ ±   17%      3.900µ ±  23%       ~ (p=0.173 n=7)
List/dqlite-tiny/pagination-4              8.300µ ±    4%      8.400µ ±  14%       ~ (p=0.052 n=7)
List/dqlite-fits-in-page/all-4             9.600µ ±   10%     10.100µ ±  14%       ~ (p=0.788 n=7)
List/dqlite-fits-in-page/pagination-4      24.10µ ±   27%      24.30µ ±  20%       ~ (p=0.533 n=7)
List/dqlite-overflows-page/all-4           33.00µ ±    1%      32.70µ ±   2%       ~ (p=0.301 n=7)
List/dqlite-overflows-page/pagination-4    74.90µ ±   17%      75.60µ ±   4%       ~ (p=0.435 n=7)
Update/sqlite-4                            192.2µ ±  315%      220.8µ ±  50%       ~ (p=0.259 n=7)
Update/dqlite-4                           108.90µ ±   25%      97.50µ ±  15%       ~ (p=0.383 n=7)
geomean                                                   ²                   +0.47%               ²
¹ all samples are equal
² summaries must be >0 to compute geomean

                                        │     Before     │                  After                  │
                                        │ sec-writing/op │ sec-writing/op  vs base                 │
Compaction/sqlite-4                       11.20µ ±  9%       10.20µ ± 11%        ~ (p=0.067 n=7)
Compaction/dqlite-4                       6.900µ ±  6%       6.900µ ± 12%        ~ (p=0.749 n=7)
Create/sqlite-4                           1.055m ± 14%       1.148m ± 18%        ~ (p=0.128 n=7)
Create/dqlite-4                           39.00µ ± 20%       37.30µ ± 20%        ~ (p=0.510 n=7)
Delete/sqlite-4                           1.223m ± 13%       1.082m ± 10%  -11.53% (p=0.001 n=7)
Delete/dqlite-4                           19.40µ ± 34%       25.10µ ± 47%        ~ (p=0.073 n=7)
Get/sqlite-4                               0.000 ±  0%        0.000 ±  0%        ~ (p=1.000 n=7) ¹
Get/dqlite-4                               0.000 ±  0%        0.000 ±  0%        ~ (p=1.000 n=7) ¹
Lease/sqlite-4                             0.000 ±  0%        0.000 ±  0%        ~ (p=1.000 n=7) ¹
Lease/dqlite-4                             0.000 ±  0%        0.000 ±  0%        ~ (p=1.000 n=7) ¹
List/sqlite-tiny/all-4                     0.000 ±  0%        0.000 ±  0%        ~ (p=1.000 n=7) ¹
List/sqlite-tiny/pagination-4              0.000 ±  0%        0.000 ±  0%        ~ (p=1.000 n=7) ¹
List/sqlite-fits-in-page/all-4             0.000 ±  0%        0.000 ±  0%        ~ (p=1.000 n=7) ¹
List/sqlite-fits-in-page/pagination-4      0.000 ±  0%        0.000 ±  0%        ~ (p=1.000 n=7) ¹
List/sqlite-overflows-page/all-4           0.000 ±  0%        0.000 ±  0%        ~ (p=1.000 n=7) ¹
List/sqlite-overflows-page/pagination-4    0.000 ±  0%        0.000 ±  0%        ~ (p=1.000 n=7) ¹
List/dqlite-tiny/all-4                     0.000 ±  0%        0.000 ±  0%        ~ (p=1.000 n=7) ¹
List/dqlite-tiny/pagination-4              0.000 ±  0%        0.000 ±  0%        ~ (p=1.000 n=7) ¹
List/dqlite-fits-in-page/all-4             0.000 ±  0%        0.000 ±  0%        ~ (p=1.000 n=7) ¹
List/dqlite-fits-in-page/pagination-4      0.000 ±  0%        0.000 ±  0%        ~ (p=1.000 n=7) ¹
List/dqlite-overflows-page/all-4           0.000 ±  0%        0.000 ±  0%        ~ (p=1.000 n=7) ¹
List/dqlite-overflows-page/pagination-4    0.000 ±  0%        0.000 ±  0%        ~ (p=1.000 n=7) ¹
Update/sqlite-4                           1.210m ± 11%       1.031m ± 17%  -14.79% (p=0.004 n=7)
Update/dqlite-4                           18.80µ ± 61%       24.10µ ± 39%        ~ (p=0.097 n=7)
geomean                                                ²                    +0.71%               ²
¹ all samples are equal
² summaries must be >0 to compute geomean

                                        │    Before     │                After                │
                                        │     B/op      │     B/op       vs base              │
Compaction/sqlite-4                        1031.0 ± 36%     742.0 ± 75%       ~ (p=0.066 n=7)
Compaction/dqlite-4                       4.769Ki ± 51%   4.504Ki ± 53%       ~ (p=0.456 n=7)
Create/sqlite-4                           21.30Ki ± 12%   21.34Ki ±  0%       ~ (p=0.128 n=7)
Create/dqlite-4                           20.09Ki ±  0%   20.08Ki ±  0%       ~ (p=0.336 n=7)
Delete/sqlite-4                           32.47Ki ±  2%   32.64Ki ±  6%       ~ (p=0.535 n=7)
Delete/dqlite-4                           29.51Ki ±  0%   29.49Ki ±  0%  -0.09% (p=0.013 n=7)
Get/sqlite-4                              25.08Ki ±  0%   25.08Ki ±  0%       ~ (p=0.104 n=7)
Get/dqlite-4                              22.89Ki ±  0%   22.89Ki ±  0%       ~ (p=0.830 n=7)
Lease/sqlite-4                            12.33Ki ±  0%   12.33Ki ±  0%       ~ (p=0.133 n=7)
Lease/dqlite-4                            12.33Ki ±  0%   12.33Ki ±  0%       ~ (p=0.065 n=7)
List/sqlite-tiny/all-4                    1.259Ki ±  1%   1.261Ki ±  2%       ~ (p=0.786 n=7)
List/sqlite-tiny/pagination-4             1.843Ki ±  3%   1.836Ki ±  3%       ~ (p=0.555 n=7)
List/sqlite-fits-in-page/all-4            5.145Ki ±  3%   5.192Ki ±  2%       ~ (p=0.902 n=7)
List/sqlite-fits-in-page/pagination-4     10.22Ki ±  0%   10.21Ki ±  0%       ~ (p=0.476 n=7)
List/sqlite-overflows-page/all-4          27.22Ki ±  6%   27.40Ki ±  5%       ~ (p=0.902 n=7)
List/sqlite-overflows-page/pagination-4   46.11Ki ±  1%   46.10Ki ±  0%       ~ (p=0.535 n=7)
List/dqlite-tiny/all-4                      873.0 ±  2%     860.0 ±  8%  -1.49% (p=0.041 n=7)
List/dqlite-tiny/pagination-4               842.0 ±  2%     842.0 ±  1%       ~ (p=0.637 n=7)
List/dqlite-fits-in-page/all-4            4.302Ki ±  1%   4.288Ki ±  1%       ~ (p=0.832 n=7)
List/dqlite-fits-in-page/pagination-4     4.352Ki ±  2%   4.360Ki ±  4%       ~ (p=0.513 n=7)
List/dqlite-overflows-page/all-4          21.31Ki ±  1%   21.25Ki ±  1%       ~ (p=0.223 n=7)
List/dqlite-overflows-page/pagination-4   22.62Ki ±  3%   23.21Ki ±  2%       ~ (p=0.073 n=7)
Update/sqlite-4                           30.25Ki ±  4%   30.18Ki ±  1%       ~ (p=0.535 n=7)
Update/dqlite-4                           27.63Ki ±  0%   27.64Ki ±  0%       ~ (p=0.645 n=7)
geomean                                   9.211Ki         9.073Ki        -1.50%

                                        │   Before    │                After                │
                                        │  allocs/op  │  allocs/op   vs base                │
Compaction/sqlite-4                       40.00 ± 38%   28.00 ± 82%       ~ (p=0.054 n=7)
Compaction/dqlite-4                       115.0 ± 51%   109.0 ± 55%       ~ (p=0.476 n=7)
Create/sqlite-4                           453.0 ± 17%   453.0 ±  1%       ~ (p=0.547 n=7)
Create/dqlite-4                           372.0 ±  0%   372.0 ±  0%       ~ (p=1.000 n=7)
Delete/sqlite-4                           722.0 ±  2%   726.0 ±  8%       ~ (p=0.520 n=7)
Delete/dqlite-4                           510.0 ±  0%   510.0 ±  0%       ~ (p=1.000 n=7) ¹
Get/sqlite-4                              563.0 ±  0%   563.0 ±  0%       ~ (p=1.000 n=7) ¹
Get/dqlite-4                              407.0 ±  0%   407.0 ±  0%       ~ (p=1.000 n=7) ¹
Lease/sqlite-4                            224.0 ±  0%   224.0 ±  0%       ~ (p=1.000 n=7) ¹
Lease/dqlite-4                            224.0 ±  0%   224.0 ±  0%       ~ (p=1.000 n=7) ¹
List/sqlite-tiny/all-4                    41.00 ±  2%   41.00 ±  2%       ~ (p=1.000 n=7)
List/sqlite-tiny/pagination-4             64.00 ±  3%   64.00 ±  3%       ~ (p=0.878 n=7)
List/sqlite-fits-in-page/all-4            47.00 ±  6%   48.00 ±  4%       ~ (p=0.825 n=7)
List/sqlite-fits-in-page/pagination-4     93.00 ±  0%   93.00 ±  0%       ~ (p=1.000 n=7) ¹
List/sqlite-overflows-page/all-4          58.00 ±  5%   58.00 ±  5%       ~ (p=0.995 n=7)
List/sqlite-overflows-page/pagination-4   93.00 ±  0%   93.00 ±  0%       ~ (p=1.000 n=7) ¹
List/dqlite-tiny/all-4                    14.00 ±  0%   14.00 ± 14%       ~ (p=0.192 n=7)
List/dqlite-tiny/pagination-4             13.00 ±  0%   13.00 ±  0%       ~ (p=1.000 n=7) ¹
List/dqlite-fits-in-page/all-4            18.00 ±  6%   18.00 ±  0%       ~ (p=1.000 n=7)
List/dqlite-fits-in-page/pagination-4     18.00 ±  6%   18.00 ±  6%       ~ (p=0.269 n=7)
List/dqlite-overflows-page/all-4          30.00 ±  3%   29.00 ±  3%       ~ (p=0.592 n=7)
List/dqlite-overflows-page/pagination-4   32.00 ±  6%   33.00 ±  3%  +3.12% (p=0.020 n=7)
Update/sqlite-4                           667.0 ±  6%   666.0 ±  1%       ~ (p=0.418 n=7)
Update/dqlite-4                           492.0 ±  0%   492.0 ±  0%       ~ (p=0.559 n=7)
geomean                                   105.7         104.0        -1.60%
¹ all samples are equal

                                        │        Before         │                    After                    │
                                        │ network-bytes-read/op │ network-bytes-read/op  vs base              │
Compaction/dqlite-4                               1.732Ki ± 52%           1.635Ki ± 54%       ~ (p=0.456 n=7)
Create/dqlite-4                                     240.5 ±  0%             240.8 ±  1%       ~ (p=0.273 n=7)
Delete/dqlite-4                                   1.156Ki ±  0%           1.157Ki ±  0%  +0.08% (p=0.009 n=7)
Get/dqlite-4                                      1.133Ki ±  0%           1.134Ki ±  0%       ~ (p=1.000 n=7)
Lease/dqlite-4                                    0.02695 ± 54%           0.03280 ± 27%       ~ (p=0.052 n=7)
List/dqlite-tiny/all-4                              203.5 ±  2%             199.9 ± 14%  -1.77% (p=0.011 n=7)
List/dqlite-tiny/pagination-4                       188.9 ±  1%             190.4 ±  2%       ~ (p=0.154 n=7)
List/dqlite-fits-in-page/all-4                    1.231Ki ±  2%           1.226Ki ±  1%       ~ (p=0.736 n=7)
List/dqlite-fits-in-page/pagination-4             1.230Ki ±  4%           1.233Ki ±  6%       ~ (p=0.558 n=7)
List/dqlite-overflows-page/all-4                  6.271Ki ±  1%           6.248Ki ±  2%       ~ (p=0.259 n=7)
List/dqlite-overflows-page/pagination-4           6.803Ki ±  5%           7.035Ki ±  3%       ~ (p=0.128 n=7)
Update/dqlite-4                                     564.3 ±  0%             564.2 ±  0%       ~ (p=0.517 n=7)
geomean                                             412.6                   418.1        +1.33%

                                        │          Before          │                      After                      │
                                        │ network-bytes-written/op │ network-bytes-written/op  vs base               │
Compaction/dqlite-4                                   4.472 ±   9%                4.462 ±  9%        ~ (p=1.000 n=7)
Create/dqlite-4                                       114.2 ±   2%                114.5 ±  2%        ~ (p=0.220 n=7)
Delete/dqlite-4                                       423.4 ±   0%                423.5 ±  0%        ~ (p=0.167 n=7)
Get/dqlite-4                                          80.50 ±   0%                80.56 ±  0%        ~ (p=0.318 n=7)
Lease/dqlite-4                                      0.01118 ± 601%              0.04974 ± 73%        ~ (p=0.090 n=7)
List/dqlite-tiny/all-4                              0.04317 ±   4%              0.04158 ± 26%   -3.68% (p=0.007 n=7)
List/dqlite-tiny/pagination-4                       0.04584 ±   6%              0.04577 ±  5%        ~ (p=0.710 n=7)
List/dqlite-fits-in-page/all-4                      0.05235 ±   3%              0.05222 ±  2%        ~ (p=0.805 n=7)
List/dqlite-fits-in-page/pagination-4               0.07482 ±  14%              0.07774 ± 11%        ~ (p=0.620 n=7)
List/dqlite-overflows-page/all-4                    0.06562 ±   2%              0.06521 ±  3%        ~ (p=0.259 n=7)
List/dqlite-overflows-page/pagination-4              0.1103 ±   8%               0.1255 ± 15%  +13.78% (p=0.002 n=7)
Update/dqlite-4                                       263.5 ±   0%                263.4 ±  0%        ~ (p=0.788 n=7)
geomean                                               1.092                       1.249        +14.39%
Current status
goos: linux
goarch: amd64
pkg: github.com/canonical/k8s-dqlite/test
cpu: AMD EPYC 7763 64-Core Processor                
                                        │    After     │
                                        │    sec/op    │
Compaction/sqlite-4                       40.91µ ± 12%
Compaction/dqlite-4                       42.46µ ±  4%
Create/sqlite-4                           1.396m ± 14%
Create/dqlite-4                           1.105m ± 11%
Delete/sqlite-4                           1.480m ± 10%
Delete/dqlite-4                           1.351m ±  8%
Get/sqlite-4                              270.6µ ±  0%
Get/dqlite-4                              356.1µ ±  2%
Lease/sqlite-4                            99.26µ ±  1%
Lease/dqlite-4                            100.2µ ±  1%
List/sqlite-tiny/all-4                    4.449µ ±  2%
List/sqlite-tiny/pagination-4             9.185µ ±  2%
List/sqlite-fits-in-page/all-4            7.318µ ±  4%
List/sqlite-fits-in-page/pagination-4     22.83µ ±  4%
List/sqlite-overflows-page/all-4          18.07µ ±  6%
List/sqlite-overflows-page/pagination-4   47.92µ ±  2%
List/dqlite-tiny/all-4                    2.756µ ±  9%
List/dqlite-tiny/pagination-4             5.977µ ±  2%
List/dqlite-fits-in-page/all-4            6.113µ ±  1%
List/dqlite-fits-in-page/pagination-4     17.06µ ±  3%
List/dqlite-overflows-page/all-4          19.15µ ±  1%
List/dqlite-overflows-page/pagination-4   43.79µ ±  4%
Update/sqlite-4                           1.477m ± 12%
Update/dqlite-4                           1.363m ±  8%
geomean                                   67.77µ

                                        │        After         │
                                        │ page-cache-misses/op │
Compaction/sqlite-4                               0.000 ± 0%
Compaction/dqlite-4                               0.000 ± 0%
Create/sqlite-4                                   0.000 ± 0%
Create/dqlite-4                                   0.000 ± 0%
Delete/sqlite-4                                   0.000 ± 0%
Delete/dqlite-4                                   0.000 ± 0%
Get/sqlite-4                                      0.000 ± 0%
Get/dqlite-4                                      0.000 ± 0%
Lease/sqlite-4                                    0.000 ± 0%
Lease/dqlite-4                                    0.000 ± 0%
List/sqlite-tiny/all-4                            0.000 ± 0%
List/sqlite-tiny/pagination-4                     0.000 ± 0%
List/sqlite-fits-in-page/all-4                    0.000 ± 0%
List/sqlite-fits-in-page/pagination-4             0.000 ± 0%
List/sqlite-overflows-page/all-4                  0.000 ± 0%
List/sqlite-overflows-page/pagination-4           0.000 ± 0%
List/dqlite-tiny/all-4                            0.000 ± 0%
List/dqlite-tiny/pagination-4                     0.000 ± 0%
List/dqlite-fits-in-page/all-4                    0.000 ± 0%
List/dqlite-fits-in-page/pagination-4             0.000 ± 0%
List/dqlite-overflows-page/all-4                  0.000 ± 0%
List/dqlite-overflows-page/pagination-4           0.000 ± 0%
Update/sqlite-4                                   0.000 ± 0%
Update/dqlite-4                                   0.000 ± 0%
geomean                                                      ¹
¹ summaries must be >0 to compute geomean

                                        │        After         │
                                        │ page-cache-spills/op │
Compaction/sqlite-4                               0.000 ± 0%
Compaction/dqlite-4                               0.000 ± 0%
Create/sqlite-4                                   0.000 ± 0%
Create/dqlite-4                                   0.000 ± 0%
Delete/sqlite-4                                   0.000 ± 0%
Delete/dqlite-4                                   0.000 ± 0%
Get/sqlite-4                                      0.000 ± 0%
Get/dqlite-4                                      0.000 ± 0%
Lease/sqlite-4                                    0.000 ± 0%
Lease/dqlite-4                                    0.000 ± 0%
List/sqlite-tiny/all-4                            0.000 ± 0%
List/sqlite-tiny/pagination-4                     0.000 ± 0%
List/sqlite-fits-in-page/all-4                    0.000 ± 0%
List/sqlite-fits-in-page/pagination-4             0.000 ± 0%
List/sqlite-overflows-page/all-4                  0.000 ± 0%
List/sqlite-overflows-page/pagination-4           0.000 ± 0%
List/dqlite-tiny/all-4                            0.000 ± 0%
List/dqlite-tiny/pagination-4                     0.000 ± 0%
List/dqlite-fits-in-page/all-4                    0.000 ± 0%
List/dqlite-fits-in-page/pagination-4             0.000 ± 0%
List/dqlite-overflows-page/all-4                  0.000 ± 0%
List/dqlite-overflows-page/pagination-4           0.000 ± 0%
Update/sqlite-4                                   0.000 ± 0%
Update/dqlite-4                                   0.000 ± 0%
geomean                                                      ¹
¹ summaries must be >0 to compute geomean

                                        │     After     │
                                        │ page-reads/op │
Compaction/sqlite-4                        12.22 ±   1%
Compaction/dqlite-4                        12.18 ±   1%
Create/sqlite-4                            13.89 ±   2%
Create/dqlite-4                            12.95 ±   1%
Delete/sqlite-4                            25.09 ±   6%
Delete/dqlite-4                            23.71 ±   1%
Get/sqlite-4                               14.95 ±   0%
Get/dqlite-4                               11.96 ±   0%
Lease/sqlite-4                            492.8µ ± 187%
Lease/dqlite-4                            800.0µ ±  50%
List/sqlite-tiny/all-4                    192.3m ±   0%
List/sqlite-tiny/pagination-4              1.132 ±   0%
List/sqlite-fits-in-page/all-4            165.1m ±   0%
List/sqlite-fits-in-page/pagination-4     965.5m ±   3%
List/sqlite-overflows-page/all-4          321.3m ±  20%
List/sqlite-overflows-page/pagination-4    2.080 ±   0%
List/dqlite-tiny/all-4                    191.0m ±   1%
List/dqlite-tiny/pagination-4              1.126 ±   0%
List/dqlite-fits-in-page/all-4            163.1m ±   0%
List/dqlite-fits-in-page/pagination-4     954.3m ±   3%
List/dqlite-overflows-page/all-4          182.9m ±   0%
List/dqlite-overflows-page/pagination-4    1.071 ±   3%
Update/sqlite-4                            24.84 ±   3%
Update/dqlite-4                            23.99 ±   2%
geomean                                    1.212

                                        │     After      │
                                        │ page-writes/op │
Compaction/sqlite-4                        207.8m ± 1%
Compaction/dqlite-4                        187.8m ± 1%
Create/sqlite-4                             5.107 ± 1%
Create/dqlite-4                             4.214 ± 2%
Delete/sqlite-4                             5.320 ± 0%
Delete/dqlite-4                             4.392 ± 1%
Get/sqlite-4                                0.000 ± 0%
Get/dqlite-4                                0.000 ± 0%
Lease/sqlite-4                              0.000 ± 0%
Lease/dqlite-4                              0.000 ± 0%
List/sqlite-tiny/all-4                      0.000 ± 0%
List/sqlite-tiny/pagination-4               0.000 ± 0%
List/sqlite-fits-in-page/all-4              0.000 ± 0%
List/sqlite-fits-in-page/pagination-4       0.000 ± 0%
List/sqlite-overflows-page/all-4            0.000 ± 0%
List/sqlite-overflows-page/pagination-4     0.000 ± 0%
List/dqlite-tiny/all-4                      0.000 ± 0%
List/dqlite-tiny/pagination-4               0.000 ± 0%
List/dqlite-fits-in-page/all-4              0.000 ± 0%
List/dqlite-fits-in-page/pagination-4       0.000 ± 0%
List/dqlite-overflows-page/all-4            0.000 ± 0%
List/dqlite-overflows-page/pagination-4     0.000 ± 0%
Update/sqlite-4                             5.138 ± 1%
Update/dqlite-4                             4.157 ± 1%
geomean                                                ¹
¹ summaries must be >0 to compute geomean

                                        │      After      │
                                        │ sec-reading/op  │
Compaction/sqlite-4                       120.3µ ±   9%
Compaction/dqlite-4                       26.40µ ±  37%
Create/sqlite-4                           102.4µ ± 299%
Create/dqlite-4                           12.20µ ±  51%
Delete/sqlite-4                           175.6µ ± 386%
Delete/dqlite-4                           53.40µ ±  27%
Get/sqlite-4                              90.80µ ±   3%
Get/dqlite-4                              34.60µ ±  18%
Lease/sqlite-4                            300.0n ±    ?
Lease/dqlite-4                             0.000 ±   0%
List/sqlite-tiny/all-4                    14.40µ ±   6%
List/sqlite-tiny/pagination-4             19.70µ ±   4%
List/sqlite-fits-in-page/all-4            17.60µ ±  19%
List/sqlite-fits-in-page/pagination-4     63.00µ ±   5%
List/sqlite-overflows-page/all-4          69.90µ ±  18%
List/sqlite-overflows-page/pagination-4   176.9µ ±   1%
List/dqlite-tiny/all-4                    3.900µ ±  23%
List/dqlite-tiny/pagination-4             8.400µ ±  14%
List/dqlite-fits-in-page/all-4            10.10µ ±  14%
List/dqlite-fits-in-page/pagination-4     24.30µ ±  20%
List/dqlite-overflows-page/all-4          32.70µ ±   2%
List/dqlite-overflows-page/pagination-4   75.60µ ±   4%
Update/sqlite-4                           220.8µ ±  50%
Update/dqlite-4                           97.50µ ±  15%
geomean                                                 ¹
¹ summaries must be >0 to compute geomean

                                        │     After      │
                                        │ sec-writing/op │
Compaction/sqlite-4                       10.20µ ± 11%
Compaction/dqlite-4                       6.900µ ± 12%
Create/sqlite-4                           1.148m ± 18%
Create/dqlite-4                           37.30µ ± 20%
Delete/sqlite-4                           1.082m ± 10%
Delete/dqlite-4                           25.10µ ± 47%
Get/sqlite-4                               0.000 ±  0%
Get/dqlite-4                               0.000 ±  0%
Lease/sqlite-4                             0.000 ±  0%
Lease/dqlite-4                             0.000 ±  0%
List/sqlite-tiny/all-4                     0.000 ±  0%
List/sqlite-tiny/pagination-4              0.000 ±  0%
List/sqlite-fits-in-page/all-4             0.000 ±  0%
List/sqlite-fits-in-page/pagination-4      0.000 ±  0%
List/sqlite-overflows-page/all-4           0.000 ±  0%
List/sqlite-overflows-page/pagination-4    0.000 ±  0%
List/dqlite-tiny/all-4                     0.000 ±  0%
List/dqlite-tiny/pagination-4              0.000 ±  0%
List/dqlite-fits-in-page/all-4             0.000 ±  0%
List/dqlite-fits-in-page/pagination-4      0.000 ±  0%
List/dqlite-overflows-page/all-4           0.000 ±  0%
List/dqlite-overflows-page/pagination-4    0.000 ±  0%
Update/sqlite-4                           1.031m ± 17%
Update/dqlite-4                           24.10µ ± 39%
geomean                                                ¹
¹ summaries must be >0 to compute geomean

                                        │     After     │
                                        │     B/op      │
Compaction/sqlite-4                         742.0 ± 75%
Compaction/dqlite-4                       4.504Ki ± 53%
Create/sqlite-4                           21.34Ki ±  0%
Create/dqlite-4                           20.08Ki ±  0%
Delete/sqlite-4                           32.64Ki ±  6%
Delete/dqlite-4                           29.49Ki ±  0%
Get/sqlite-4                              25.08Ki ±  0%
Get/dqlite-4                              22.89Ki ±  0%
Lease/sqlite-4                            12.33Ki ±  0%
Lease/dqlite-4                            12.33Ki ±  0%
List/sqlite-tiny/all-4                    1.261Ki ±  2%
List/sqlite-tiny/pagination-4             1.836Ki ±  3%
List/sqlite-fits-in-page/all-4            5.192Ki ±  2%
List/sqlite-fits-in-page/pagination-4     10.21Ki ±  0%
List/sqlite-overflows-page/all-4          27.40Ki ±  5%
List/sqlite-overflows-page/pagination-4   46.10Ki ±  0%
List/dqlite-tiny/all-4                      860.0 ±  8%
List/dqlite-tiny/pagination-4               842.0 ±  1%
List/dqlite-fits-in-page/all-4            4.288Ki ±  1%
List/dqlite-fits-in-page/pagination-4     4.360Ki ±  4%
List/dqlite-overflows-page/all-4          21.25Ki ±  1%
List/dqlite-overflows-page/pagination-4   23.21Ki ±  2%
Update/sqlite-4                           30.18Ki ±  1%
Update/dqlite-4                           27.64Ki ±  0%
geomean                                   9.073Ki

                                        │    After    │
                                        │  allocs/op  │
Compaction/sqlite-4                       28.00 ± 82%
Compaction/dqlite-4                       109.0 ± 55%
Create/sqlite-4                           453.0 ±  1%
Create/dqlite-4                           372.0 ±  0%
Delete/sqlite-4                           726.0 ±  8%
Delete/dqlite-4                           510.0 ±  0%
Get/sqlite-4                              563.0 ±  0%
Get/dqlite-4                              407.0 ±  0%
Lease/sqlite-4                            224.0 ±  0%
Lease/dqlite-4                            224.0 ±  0%
List/sqlite-tiny/all-4                    41.00 ±  2%
List/sqlite-tiny/pagination-4             64.00 ±  3%
List/sqlite-fits-in-page/all-4            48.00 ±  4%
List/sqlite-fits-in-page/pagination-4     93.00 ±  0%
List/sqlite-overflows-page/all-4          58.00 ±  5%
List/sqlite-overflows-page/pagination-4   93.00 ±  0%
List/dqlite-tiny/all-4                    14.00 ± 14%
List/dqlite-tiny/pagination-4             13.00 ±  0%
List/dqlite-fits-in-page/all-4            18.00 ±  0%
List/dqlite-fits-in-page/pagination-4     18.00 ±  6%
List/dqlite-overflows-page/all-4          29.00 ±  3%
List/dqlite-overflows-page/pagination-4   33.00 ±  3%
Update/sqlite-4                           666.0 ±  1%
Update/dqlite-4                           492.0 ±  0%
geomean                                   104.0

                                        │         After         │
                                        │ network-bytes-read/op │
Compaction/dqlite-4                               1.635Ki ± 54%
Create/dqlite-4                                     240.8 ±  1%
Delete/dqlite-4                                   1.157Ki ±  0%
Get/dqlite-4                                      1.134Ki ±  0%
Lease/dqlite-4                                    0.03280 ± 27%
List/dqlite-tiny/all-4                              199.9 ± 14%
List/dqlite-tiny/pagination-4                       190.4 ±  2%
List/dqlite-fits-in-page/all-4                    1.226Ki ±  1%
List/dqlite-fits-in-page/pagination-4             1.233Ki ±  6%
List/dqlite-overflows-page/all-4                  6.248Ki ±  2%
List/dqlite-overflows-page/pagination-4           7.035Ki ±  3%
Update/dqlite-4                                     564.2 ±  0%
geomean                                             418.1

                                        │          After           │
                                        │ network-bytes-written/op │
Compaction/dqlite-4                                    4.462 ±  9%
Create/dqlite-4                                        114.5 ±  2%
Delete/dqlite-4                                        423.5 ±  0%
Get/dqlite-4                                           80.56 ±  0%
Lease/dqlite-4                                       0.04974 ± 73%
List/dqlite-tiny/all-4                               0.04158 ± 26%
List/dqlite-tiny/pagination-4                        0.04577 ±  5%
List/dqlite-fits-in-page/all-4                       0.05222 ±  2%
List/dqlite-fits-in-page/pagination-4                0.07774 ± 11%
List/dqlite-overflows-page/all-4                     0.06521 ±  3%
List/dqlite-overflows-page/pagination-4               0.1255 ± 15%
Update/dqlite-4                                        263.4 ±  0%
geomean                                                1.249

@marco6 marco6 merged commit 132be15 into master Sep 2, 2024
7 checks passed
@marco6 marco6 deleted the marco6/remove-unused-query branch September 2, 2024 11:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants