Code cleanup remove lease test and dead code

[louiseschmidtgen]

Description

Note that calling lease grant doesn't do anything but return a response to k8s, leases and ttl are handled by a long running go routine in the kine layer: pkg/kine/logstructured/logstructured.go.
Removing the benchmark test because it is not measuring any lease performance.

The function updateKey is not used and can be removed.

[github-actions]

Benchmark Result

goos: linux
goarch: amd64
pkg: github.com/canonical/k8s-dqlite/test
cpu: AMD EPYC 7763 64-Core Processor                
                                        │    Before    │                 After                 │
                                        │    sec/op    │    sec/op     vs base                 │
Compaction/sqlite-4                       40.89µ ±  9%   46.25µ ± 11%  +13.11% (p=0.038 n=7)
Compaction/dqlite-4                       45.09µ ±  7%   44.23µ ± 10%        ~ (p=1.000 n=7)
Create/sqlite-4                           1.737m ± 12%   1.610m ± 15%        ~ (p=0.128 n=7)
Create/dqlite-4                           1.349m ± 13%   1.380m ±  4%        ~ (p=0.383 n=7)
Delete/sqlite-4                           1.855m ±  8%   1.870m ± 16%        ~ (p=0.902 n=7)
Delete/dqlite-4                           1.425m ± 23%   1.621m ± 19%        ~ (p=0.165 n=7)
Get/sqlite-4                              265.2µ ±  1%   264.3µ ±  1%        ~ (p=0.209 n=7)
Get/dqlite-4                              353.8µ ±  1%   352.8µ ±  4%        ~ (p=0.620 n=7)
Lease/sqlite-4                            99.49µ ±  1%
Lease/dqlite-4                            100.9µ ±  1%
List/sqlite-tiny/all-4                    4.430µ ±  4%   4.408µ ±  4%        ~ (p=0.209 n=7)
List/sqlite-tiny/pagination-4             9.198µ ±  3%   8.962µ ±  6%        ~ (p=0.076 n=7)
List/sqlite-fits-in-page/all-4            7.520µ ±  2%   7.408µ ±  5%        ~ (p=0.221 n=7)
List/sqlite-fits-in-page/pagination-4     22.49µ ±  3%   22.91µ ±  5%        ~ (p=0.535 n=7)
List/sqlite-overflows-page/all-4          18.05µ ±  4%   17.46µ ±  5%   -3.28% (p=0.001 n=7)
List/sqlite-overflows-page/pagination-4   48.18µ ±  3%   47.00µ ±  7%        ~ (p=0.073 n=7)
List/dqlite-tiny/all-4                    2.744µ ±  3%   2.796µ ± 12%        ~ (p=0.902 n=7)
List/dqlite-tiny/pagination-4             5.966µ ±  2%   5.905µ ±  2%        ~ (p=0.078 n=7)
List/dqlite-fits-in-page/all-4            6.091µ ±  3%   6.153µ ±  4%        ~ (p=0.902 n=7)
List/dqlite-fits-in-page/pagination-4     17.03µ ±  2%   17.08µ ±  1%        ~ (p=0.902 n=7)
List/dqlite-overflows-page/all-4          19.00µ ±  2%   19.39µ ±  2%        ~ (p=0.128 n=7)
List/dqlite-overflows-page/pagination-4   42.90µ ±  4%   42.65µ ±  2%        ~ (p=0.138 n=7)
Update/sqlite-4                           1.696m ± 12%   1.637m ± 24%        ~ (p=0.165 n=7)
Update/dqlite-4                           1.622m ± 11%   1.442m ± 10%  -11.14% (p=0.017 n=7)
geomean                                   70.73µ         68.45µ         -0.10%               ¹
¹ benchmark set differs from baseline; geomeans may not be comparable

                                        │        Before        │                     After                      │
                                        │ page-cache-misses/op │ page-cache-misses/op  vs base                  │
Compaction/sqlite-4                               0.000 ± 0%               0.000 ± 0%       ~ (p=1.000 n=7) ¹
Compaction/dqlite-4                               0.000 ± 0%               0.000 ± 0%       ~ (p=1.000 n=7) ¹
Create/sqlite-4                                   0.000 ± 0%               0.000 ± 0%       ~ (p=1.000 n=7) ¹
Create/dqlite-4                                   0.000 ± 0%               0.000 ± 0%       ~ (p=1.000 n=7) ¹
Delete/sqlite-4                                   0.000 ± 0%               0.000 ± 0%       ~ (p=1.000 n=7) ¹
Delete/dqlite-4                                   0.000 ± 0%               0.000 ± 0%       ~ (p=1.000 n=7) ¹
Get/sqlite-4                                      0.000 ± 0%               0.000 ± 0%       ~ (p=1.000 n=7) ¹
Get/dqlite-4                                      0.000 ± 0%               0.000 ± 0%       ~ (p=1.000 n=7) ¹
Lease/sqlite-4                                    0.000 ± 0%
Lease/dqlite-4                                    0.000 ± 0%
List/sqlite-tiny/all-4                            0.000 ± 0%               0.000 ± 0%       ~ (p=1.000 n=7) ¹
List/sqlite-tiny/pagination-4                     0.000 ± 0%               0.000 ± 0%       ~ (p=1.000 n=7) ¹
List/sqlite-fits-in-page/all-4                    0.000 ± 0%               0.000 ± 0%       ~ (p=1.000 n=7) ¹
List/sqlite-fits-in-page/pagination-4             0.000 ± 0%               0.000 ± 0%       ~ (p=1.000 n=7) ¹
List/sqlite-overflows-page/all-4                  0.000 ± 0%               0.000 ± 0%       ~ (p=1.000 n=7) ¹
List/sqlite-overflows-page/pagination-4           0.000 ± 0%               0.000 ± 0%       ~ (p=1.000 n=7) ¹
List/dqlite-tiny/all-4                            0.000 ± 0%               0.000 ± 0%       ~ (p=1.000 n=7) ¹
List/dqlite-tiny/pagination-4                     0.000 ± 0%               0.000 ± 0%       ~ (p=1.000 n=7) ¹
List/dqlite-fits-in-page/all-4                    0.000 ± 0%               0.000 ± 0%       ~ (p=1.000 n=7) ¹
List/dqlite-fits-in-page/pagination-4             0.000 ± 0%               0.000 ± 0%       ~ (p=1.000 n=7) ¹
List/dqlite-overflows-page/all-4                  0.000 ± 0%               0.000 ± 0%       ~ (p=1.000 n=7) ¹
List/dqlite-overflows-page/pagination-4           0.000 ± 0%               0.000 ± 0%       ~ (p=1.000 n=7) ¹
Update/sqlite-4                                   0.000 ± 0%               0.000 ± 0%       ~ (p=1.000 n=7) ¹
Update/dqlite-4                                   0.000 ± 0%               0.000 ± 0%       ~ (p=1.000 n=7) ¹
geomean                                                      ²                         +0.00%               ³ ²
¹ all samples are equal
² summaries must be >0 to compute geomean
³ benchmark set differs from baseline; geomeans may not be comparable

                                        │        Before        │                     After                      │
                                        │ page-cache-spills/op │ page-cache-spills/op  vs base                  │
Compaction/sqlite-4                               0.000 ± 0%               0.000 ± 0%       ~ (p=1.000 n=7) ¹
Compaction/dqlite-4                               0.000 ± 0%               0.000 ± 0%       ~ (p=1.000 n=7) ¹
Create/sqlite-4                                   0.000 ± 0%               0.000 ± 0%       ~ (p=1.000 n=7) ¹
Create/dqlite-4                                   0.000 ± 0%               0.000 ± 0%       ~ (p=1.000 n=7) ¹
Delete/sqlite-4                                   0.000 ± 0%               0.000 ± 0%       ~ (p=1.000 n=7) ¹
Delete/dqlite-4                                   0.000 ± 0%               0.000 ± 0%       ~ (p=1.000 n=7) ¹
Get/sqlite-4                                      0.000 ± 0%               0.000 ± 0%       ~ (p=1.000 n=7) ¹
Get/dqlite-4                                      0.000 ± 0%               0.000 ± 0%       ~ (p=1.000 n=7) ¹
Lease/sqlite-4                                    0.000 ± 0%
Lease/dqlite-4                                    0.000 ± 0%
List/sqlite-tiny/all-4                            0.000 ± 0%               0.000 ± 0%       ~ (p=1.000 n=7) ¹
List/sqlite-tiny/pagination-4                     0.000 ± 0%               0.000 ± 0%       ~ (p=1.000 n=7) ¹
List/sqlite-fits-in-page/all-4                    0.000 ± 0%               0.000 ± 0%       ~ (p=1.000 n=7) ¹
List/sqlite-fits-in-page/pagination-4             0.000 ± 0%               0.000 ± 0%       ~ (p=1.000 n=7) ¹
List/sqlite-overflows-page/all-4                  0.000 ± 0%               0.000 ± 0%       ~ (p=1.000 n=7) ¹
List/sqlite-overflows-page/pagination-4           0.000 ± 0%               0.000 ± 0%       ~ (p=1.000 n=7) ¹
List/dqlite-tiny/all-4                            0.000 ± 0%               0.000 ± 0%       ~ (p=1.000 n=7) ¹
List/dqlite-tiny/pagination-4                     0.000 ± 0%               0.000 ± 0%       ~ (p=1.000 n=7) ¹
List/dqlite-fits-in-page/all-4                    0.000 ± 0%               0.000 ± 0%       ~ (p=1.000 n=7) ¹
List/dqlite-fits-in-page/pagination-4             0.000 ± 0%               0.000 ± 0%       ~ (p=1.000 n=7) ¹
List/dqlite-overflows-page/all-4                  0.000 ± 0%               0.000 ± 0%       ~ (p=1.000 n=7) ¹
List/dqlite-overflows-page/pagination-4           0.000 ± 0%               0.000 ± 0%       ~ (p=1.000 n=7) ¹
Update/sqlite-4                                   0.000 ± 0%               0.000 ± 0%       ~ (p=1.000 n=7) ¹
Update/dqlite-4                                   0.000 ± 0%               0.000 ± 0%       ~ (p=1.000 n=7) ¹
geomean                                                      ²                         +0.00%               ³ ²
¹ all samples are equal
² summaries must be >0 to compute geomean
³ benchmark set differs from baseline; geomeans may not be comparable

                                        │    Before     │                 After                 │
                                        │ page-reads/op │ page-reads/op  vs base                │
Compaction/sqlite-4                        12.22 ±   2%     12.22 ±  1%       ~ (p=0.397 n=7)
Compaction/dqlite-4                        12.22 ±   1%     12.18 ±  1%       ~ (p=0.251 n=7)
Create/sqlite-4                            13.41 ±  18%     13.68 ±  4%       ~ (p=0.209 n=7)
Create/dqlite-4                            12.82 ±   2%     12.76 ±  3%       ~ (p=0.779 n=7)
Delete/sqlite-4                            24.72 ±   9%     25.01 ±  7%       ~ (p=0.710 n=7)
Delete/dqlite-4                            23.81 ±   1%     23.81 ±  1%       ~ (p=0.598 n=7)
Get/sqlite-4                               14.96 ±   0%     14.96 ±  0%       ~ (p=0.983 n=7)
Get/dqlite-4                               11.96 ±   0%     11.96 ±  0%       ~ (p=0.797 n=7)
Lease/sqlite-4                            200.0µ ± 524%
Lease/dqlite-4                            1.200m ±  45%
List/sqlite-tiny/all-4                    192.3m ±   0%    192.2m ±  0%       ~ (p=0.128 n=7)
List/sqlite-tiny/pagination-4              1.132 ±   3%     1.132 ±  0%       ~ (p=0.269 n=7)
List/sqlite-fits-in-page/all-4            164.9m ±   0%    165.2m ±  0%       ~ (p=0.112 n=7)
List/sqlite-fits-in-page/pagination-4     965.4m ±   3%    965.6m ±  3%       ~ (p=0.298 n=7)
List/sqlite-overflows-page/all-4          302.2m ±  28%    281.5m ± 25%       ~ (p=0.318 n=7)
List/sqlite-overflows-page/pagination-4    2.081 ±   0%     2.081 ±  0%       ~ (p=1.000 n=7)
List/dqlite-tiny/all-4                    191.0m ±   0%    191.1m ±  1%       ~ (p=0.992 n=7)
List/dqlite-tiny/pagination-4              1.126 ±   0%     1.125 ±  3%       ~ (p=0.152 n=7)
List/dqlite-fits-in-page/all-4            163.3m ±  59%    163.3m ± 59%       ~ (p=0.303 n=7)
List/dqlite-fits-in-page/pagination-4     954.5m ±   0%    954.6m ±  3%       ~ (p=0.523 n=7)
List/dqlite-overflows-page/all-4          182.9m ±   0%    182.7m ±  0%  -0.11% (p=0.002 n=7)
List/dqlite-overflows-page/pagination-4    1.070 ±   3%     1.071 ±  3%  +0.09% (p=0.049 n=7)
Update/sqlite-4                            24.30 ±   2%     25.02 ±  4%       ~ (p=0.097 n=7)
Update/dqlite-4                            23.65 ±   2%     23.95 ±  3%       ~ (p=0.302 n=7)
geomean                                    1.180            2.395        -0.02%               ¹
¹ benchmark set differs from baseline; geomeans may not be comparable

                                        │     Before     │                  After                   │
                                        │ page-writes/op │ page-writes/op  vs base                  │
Compaction/sqlite-4                        208.1m ± 0%        207.3m ± 0%       ~ (p=0.181 n=7)
Compaction/dqlite-4                        187.9m ± 0%        188.0m ± 0%       ~ (p=0.925 n=7)
Create/sqlite-4                             5.094 ± 1%         5.096 ± 1%       ~ (p=0.402 n=7)
Create/dqlite-4                             4.133 ± 3%         4.143 ± 2%       ~ (p=0.509 n=7)
Delete/sqlite-4                             5.347 ± 1%         5.319 ± 1%       ~ (p=0.163 n=7)
Delete/dqlite-4                             4.378 ± 1%         4.407 ± 1%       ~ (p=0.193 n=7)
Get/sqlite-4                                0.000 ± 0%         0.000 ± 0%       ~ (p=1.000 n=7) ¹
Get/dqlite-4                                0.000 ± 0%         0.000 ± 0%       ~ (p=1.000 n=7) ¹
Lease/sqlite-4                              0.000 ± 0%
Lease/dqlite-4                              0.000 ± 0%
List/sqlite-tiny/all-4                      0.000 ± 0%         0.000 ± 0%       ~ (p=1.000 n=7) ¹
List/sqlite-tiny/pagination-4               0.000 ± 0%         0.000 ± 0%       ~ (p=1.000 n=7) ¹
List/sqlite-fits-in-page/all-4              0.000 ± 0%         0.000 ± 0%       ~ (p=1.000 n=7) ¹
List/sqlite-fits-in-page/pagination-4       0.000 ± 0%         0.000 ± 0%       ~ (p=1.000 n=7) ¹
List/sqlite-overflows-page/all-4            0.000 ± 0%         0.000 ± 0%       ~ (p=1.000 n=7) ¹
List/sqlite-overflows-page/pagination-4     0.000 ± 0%         0.000 ± 0%       ~ (p=1.000 n=7) ¹
List/dqlite-tiny/all-4                      0.000 ± 0%         0.000 ± 0%       ~ (p=1.000 n=7) ¹
List/dqlite-tiny/pagination-4               0.000 ± 0%         0.000 ± 0%       ~ (p=1.000 n=7) ¹
List/dqlite-fits-in-page/all-4              0.000 ± 0%         0.000 ± 0%       ~ (p=1.000 n=7) ¹
List/dqlite-fits-in-page/pagination-4       0.000 ± 0%         0.000 ± 0%       ~ (p=1.000 n=7) ¹
List/dqlite-overflows-page/all-4            0.000 ± 0%         0.000 ± 0%       ~ (p=1.000 n=7) ¹
List/dqlite-overflows-page/pagination-4     0.000 ± 0%         0.000 ± 0%       ~ (p=1.000 n=7) ¹
Update/sqlite-4                             5.120 ± 1%         5.139 ± 0%       ~ (p=0.298 n=7)
Update/dqlite-4                             4.133 ± 0%         4.154 ± 1%       ~ (p=0.105 n=7)
geomean                                                ²                   +0.04%               ³ ²
¹ all samples are equal
² summaries must be >0 to compute geomean
³ benchmark set differs from baseline; geomeans may not be comparable

                                        │      Before      │                  After                  │
                                        │  sec-reading/op  │ sec-reading/op  vs base                 │
Compaction/sqlite-4                        119.8µ ±   9%      123.3µ ±  12%        ~ (p=0.640 n=7)
Compaction/dqlite-4                        29.70µ ±  30%      27.50µ ±  39%        ~ (p=0.259 n=7)
Create/sqlite-4                           258.10µ ± 500%      70.00µ ± 455%        ~ (p=0.456 n=7)
Create/dqlite-4                            9.800µ ±  34%     10.000µ ±  52%        ~ (p=0.805 n=7)
Delete/sqlite-4                            436.9µ ± 294%      397.7µ ± 258%        ~ (p=0.902 n=7)
Delete/dqlite-4                            56.70µ ±  15%      45.60µ ±  33%  -19.58% (p=0.037 n=7)
Get/sqlite-4                               89.30µ ±   5%      88.80µ ±   7%        ~ (p=0.972 n=7)
Get/dqlite-4                               34.20µ ±  11%      33.00µ ±  11%        ~ (p=0.122 n=7)
Lease/sqlite-4                             200.0n ± 250%
Lease/dqlite-4                              0.000 ±   0%
List/sqlite-tiny/all-4                     14.50µ ±   2%      14.10µ ±   4%   -2.76% (p=0.004 n=7)
List/sqlite-tiny/pagination-4              19.90µ ±   6%      20.00µ ±   5%        ~ (p=0.645 n=7)
List/sqlite-fits-in-page/all-4             19.50µ ±  19%      18.00µ ±  21%        ~ (p=0.781 n=7)
List/sqlite-fits-in-page/pagination-4      64.30µ ±   4%      65.30µ ±   6%        ~ (p=0.736 n=7)
List/sqlite-overflows-page/all-4           72.70µ ±   6%      65.30µ ±  21%        ~ (p=0.209 n=7)
List/sqlite-overflows-page/pagination-4    180.9µ ±   3%      179.5µ ±   3%        ~ (p=0.555 n=7)
List/dqlite-tiny/all-4                     3.900µ ±  23%      4.700µ ±  38%        ~ (p=1.000 n=7)
List/dqlite-tiny/pagination-4              8.500µ ±  25%      8.200µ ±  15%        ~ (p=0.594 n=7)
List/dqlite-fits-in-page/all-4             10.10µ ±  15%      10.20µ ±  18%        ~ (p=0.832 n=7)
List/dqlite-fits-in-page/pagination-4      25.60µ ±  17%      25.10µ ±  21%        ~ (p=1.000 n=7)
List/dqlite-overflows-page/all-4           32.50µ ±   2%      33.50µ ±   2%   +3.08% (p=0.005 n=7)
List/dqlite-overflows-page/pagination-4    72.60µ ±  16%      74.50µ ±  12%        ~ (p=0.685 n=7)
Update/sqlite-4                            170.0µ ±  80%      180.7µ ± 112%        ~ (p=0.259 n=7)
Update/dqlite-4                            96.80µ ±  12%      95.20µ ±  17%        ~ (p=0.209 n=7)
geomean                                                  ¹    40.30µ          -7.21%               ²
¹ summaries must be >0 to compute geomean
² benchmark set differs from baseline; geomeans may not be comparable

                                        │     Before     │                  After                   │
                                        │ sec-writing/op │ sec-writing/op  vs base                  │
Compaction/sqlite-4                       10.00µ ± 13%       10.50µ ±  6%       ~ (p=0.430 n=7)
Compaction/dqlite-4                       6.700µ ±  7%       7.000µ ±  9%       ~ (p=0.445 n=7)
Create/sqlite-4                           1.507m ± 13%       1.357m ± 16%       ~ (p=0.073 n=7)
Create/dqlite-4                           41.70µ ± 18%       38.10µ ± 26%       ~ (p=0.383 n=7)
Delete/sqlite-4                           1.471m ± 12%       1.450m ± 17%       ~ (p=1.000 n=7)
Delete/dqlite-4                           19.10µ ± 45%       21.50µ ± 22%       ~ (p=0.737 n=7)
Get/sqlite-4                               0.000 ±  0%        0.000 ±  0%       ~ (p=1.000 n=7) ¹
Get/dqlite-4                               0.000 ±  0%        0.000 ±  0%       ~ (p=1.000 n=7) ¹
Lease/sqlite-4                             0.000 ±  0%
Lease/dqlite-4                             0.000 ±  0%
List/sqlite-tiny/all-4                     0.000 ±  0%        0.000 ±  0%       ~ (p=1.000 n=7) ¹
List/sqlite-tiny/pagination-4              0.000 ±  0%        0.000 ±  0%       ~ (p=1.000 n=7) ¹
List/sqlite-fits-in-page/all-4             0.000 ±  0%        0.000 ±  0%       ~ (p=1.000 n=7) ¹
List/sqlite-fits-in-page/pagination-4      0.000 ±  0%        0.000 ±  0%       ~ (p=1.000 n=7) ¹
List/sqlite-overflows-page/all-4           0.000 ±  0%        0.000 ±  0%       ~ (p=1.000 n=7) ¹
List/sqlite-overflows-page/pagination-4    0.000 ±  0%        0.000 ±  0%       ~ (p=1.000 n=7) ¹
List/dqlite-tiny/all-4                     0.000 ±  0%        0.000 ±  0%       ~ (p=1.000 n=7) ¹
List/dqlite-tiny/pagination-4              0.000 ±  0%        0.000 ±  0%       ~ (p=1.000 n=7) ¹
List/dqlite-fits-in-page/all-4             0.000 ±  0%        0.000 ±  0%       ~ (p=1.000 n=7) ¹
List/dqlite-fits-in-page/pagination-4      0.000 ±  0%        0.000 ±  0%       ~ (p=1.000 n=7) ¹
List/dqlite-overflows-page/all-4           0.000 ±  0%        0.000 ±  0%       ~ (p=1.000 n=7) ¹
List/dqlite-overflows-page/pagination-4    0.000 ±  0%        0.000 ±  0%       ~ (p=1.000 n=7) ¹
Update/sqlite-4                           1.240m ± 16%       1.185m ± 32%       ~ (p=0.245 n=7)
Update/dqlite-4                           20.30µ ± 21%       14.90µ ± 91%       ~ (p=0.301 n=7)
geomean                                                ²                   -1.59%               ³ ²
¹ all samples are equal
² summaries must be >0 to compute geomean
³ benchmark set differs from baseline; geomeans may not be comparable

                                        │     Before     │                 After                  │
                                        │      B/op      │      B/op       vs base                │
Compaction/sqlite-4                         468.0 ± 125%     471.0 ± 145%       ~ (p=0.902 n=7)
Compaction/dqlite-4                       5.178Ki ±  48%   4.528Ki ±  49%       ~ (p=0.383 n=7)
Create/sqlite-4                           21.30Ki ±  15%   21.28Ki ±   1%       ~ (p=1.000 n=7)
Create/dqlite-4                           20.14Ki ±   0%   20.12Ki ±   0%       ~ (p=0.555 n=7)
Delete/sqlite-4                           32.22Ki ±   8%   32.48Ki ±   6%       ~ (p=0.710 n=7)
Delete/dqlite-4                           29.49Ki ±   0%   29.50Ki ±   0%       ~ (p=0.805 n=7)
Get/sqlite-4                              25.07Ki ±   0%   25.08Ki ±   0%       ~ (p=0.249 n=7)
Get/dqlite-4                              22.89Ki ±   0%   22.89Ki ±   0%       ~ (p=0.487 n=7)
Lease/sqlite-4                            12.33Ki ±   0%
Lease/dqlite-4                            12.33Ki ±   0%
List/sqlite-tiny/all-4                    1.260Ki ±   2%   1.252Ki ±   2%       ~ (p=0.071 n=7)
List/sqlite-tiny/pagination-4             1.832Ki ±   4%   1.820Ki ±   5%       ~ (p=0.558 n=7)
List/sqlite-fits-in-page/all-4            5.119Ki ±   1%   5.200Ki ±   3%       ~ (p=0.138 n=7)
List/sqlite-fits-in-page/pagination-4     10.23Ki ±   0%   10.23Ki ±   1%       ~ (p=0.829 n=7)
List/sqlite-overflows-page/all-4          26.84Ki ±   7%   26.48Ki ±   6%       ~ (p=0.383 n=7)
List/sqlite-overflows-page/pagination-4   46.12Ki ±   0%   46.10Ki ±   0%       ~ (p=0.259 n=7)
List/dqlite-tiny/all-4                      863.0 ±   2%     874.0 ±  11%       ~ (p=0.805 n=7)
List/dqlite-tiny/pagination-4               846.0 ±   6%     842.0 ±   1%       ~ (p=0.218 n=7)
List/dqlite-fits-in-page/all-4            4.302Ki ±   1%   4.314Ki ±   2%       ~ (p=0.927 n=7)
List/dqlite-fits-in-page/pagination-4     4.368Ki ±   2%   4.410Ki ±   4%       ~ (p=0.097 n=7)
List/dqlite-overflows-page/all-4          21.38Ki ±   1%   21.14Ki ±   1%  -1.10% (p=0.001 n=7)
List/dqlite-overflows-page/pagination-4   21.82Ki ±   3%   22.66Ki ±   6%       ~ (p=0.073 n=7)
Update/sqlite-4                           30.37Ki ±   1%   30.30Ki ±   2%       ~ (p=0.097 n=7)
Update/dqlite-4                           27.65Ki ±   0%   27.64Ki ±   0%       ~ (p=0.510 n=7)
geomean                                   8.920Ki          8.628Ki         -0.40%               ¹
¹ benchmark set differs from baseline; geomeans may not be comparable

                                        │    Before    │                After                 │
                                        │  allocs/op   │  allocs/op    vs base                │
Compaction/sqlite-4                       16.00 ± 150%   16.00 ± 181%       ~ (p=0.927 n=7)
Compaction/dqlite-4                       125.0 ±  48%   109.0 ±  49%       ~ (p=0.383 n=7)
Create/sqlite-4                           452.0 ±  22%   452.0 ±   3%       ~ (p=0.787 n=7)
Create/dqlite-4                           371.0 ±   0%   372.0 ±   0%       ~ (p=0.592 n=7)
Delete/sqlite-4                           712.0 ±  11%   720.0 ±   8%       ~ (p=0.618 n=7)
Delete/dqlite-4                           510.0 ±   0%   510.0 ±   0%       ~ (p=0.462 n=7)
Get/sqlite-4                              563.0 ±   0%   563.0 ±   0%       ~ (p=1.000 n=7) ¹
Get/dqlite-4                              407.0 ±   0%   407.0 ±   0%       ~ (p=1.000 n=7) ¹
Lease/sqlite-4                            224.0 ±   0%
Lease/dqlite-4                            224.0 ±   0%
List/sqlite-tiny/all-4                    41.00 ±   2%   41.00 ±   2%       ~ (p=0.633 n=7)
List/sqlite-tiny/pagination-4             63.00 ±   3%   63.00 ±   5%       ~ (p=0.971 n=7)
List/sqlite-fits-in-page/all-4            47.00 ±   2%   48.00 ±   4%       ~ (p=0.452 n=7)
List/sqlite-fits-in-page/pagination-4     93.00 ±   0%   93.00 ±   1%       ~ (p=1.000 n=7)
List/sqlite-overflows-page/all-4          57.00 ±   7%   56.00 ±   4%       ~ (p=0.142 n=7)
List/sqlite-overflows-page/pagination-4   93.00 ±   0%   93.00 ±   0%       ~ (p=1.000 n=7) ¹
List/dqlite-tiny/all-4                    14.00 ±   7%   14.00 ±  14%       ~ (p=0.437 n=7)
List/dqlite-tiny/pagination-4             13.00 ±   8%   13.00 ±   0%       ~ (p=1.000 n=7)
List/dqlite-fits-in-page/all-4            18.00 ±   0%   18.00 ±   6%       ~ (p=0.462 n=7)
List/dqlite-fits-in-page/pagination-4     18.00 ±   6%   18.00 ±   6%       ~ (p=0.364 n=7)
List/dqlite-overflows-page/all-4          30.00 ±   3%   29.00 ±   0%  -3.33% (p=0.005 n=7)
List/dqlite-overflows-page/pagination-4   30.00 ±   3%   32.00 ±   9%       ~ (p=0.103 n=7)
Update/sqlite-4                           670.0 ±   1%   670.0 ±   3%       ~ (p=1.000 n=7)
Update/dqlite-4                           491.0 ±   0%   492.0 ±   0%       ~ (p=0.070 n=7)
geomean                                   101.6          94.18         -0.40%               ²
¹ all samples are equal
² benchmark set differs from baseline; geomeans may not be comparable

                                        │        Before         │                     After                     │
                                        │ network-bytes-read/op │ network-bytes-read/op  vs base                │
Compaction/dqlite-4                               1.886Ki ± 49%           1.644Ki ± 50%       ~ (p=0.383 n=7)
Create/dqlite-4                                     239.5 ±  1%             239.7 ±  0%       ~ (p=0.744 n=7)
Delete/dqlite-4                                   1.156Ki ±  0%           1.156Ki ±  0%       ~ (p=0.640 n=7)
Get/dqlite-4                                      1.133Ki ±  0%           1.134Ki ±  0%       ~ (p=1.000 n=7)
Lease/dqlite-4                                    0.04160 ± 58%
List/dqlite-tiny/all-4                              199.6 ±  4%             202.6 ± 18%       ~ (p=0.929 n=7)
List/dqlite-tiny/pagination-4                       191.8 ±  6%             189.0 ±  1%  -1.46% (p=0.001 n=7)
List/dqlite-fits-in-page/all-4                    1.235Ki ±  2%           1.239Ki ±  3%       ~ (p=0.902 n=7)
List/dqlite-fits-in-page/pagination-4             1.237Ki ±  4%           1.255Ki ±  6%       ~ (p=0.128 n=7)
List/dqlite-overflows-page/all-4                  6.305Ki ±  1%           6.194Ki ±  2%  -1.75% (p=0.001 n=7)
List/dqlite-overflows-page/pagination-4           6.435Ki ±  5%           6.795Ki ±  9%       ~ (p=0.053 n=7)
Update/dqlite-4                                     563.5 ±  0%             564.4 ±  0%  +0.16% (p=0.001 n=7)
geomean                                             429.0                   986.6        -0.72%               ¹
¹ benchmark set differs from baseline; geomeans may not be comparable

                                        │          Before          │                      After                       │
                                        │ network-bytes-written/op │ network-bytes-written/op  vs base                │
Compaction/dqlite-4                                    4.537 ±  9%                4.438 ±  8%       ~ (p=0.383 n=7)
Create/dqlite-4                                        112.5 ±  2%                112.8 ±  1%       ~ (p=0.363 n=7)
Delete/dqlite-4                                        423.5 ±  0%                423.4 ±  0%       ~ (p=0.842 n=7)
Get/dqlite-4                                           80.56 ±  0%                80.50 ±  0%       ~ (p=0.247 n=7)
Lease/dqlite-4                                       0.06160 ± 82%
List/dqlite-tiny/all-4                               0.04156 ±  7%              0.04274 ± 34%       ~ (p=0.902 n=7)
List/dqlite-tiny/pagination-4                        0.04566 ± 19%              0.04634 ±  7%       ~ (p=0.710 n=7)
List/dqlite-fits-in-page/all-4                       0.05269 ±  2%              0.05279 ±  4%       ~ (p=0.902 n=7)
List/dqlite-fits-in-page/pagination-4                0.07134 ± 17%              0.07658 ± 20%       ~ (p=0.128 n=7)
List/dqlite-overflows-page/all-4                     0.06674 ±  2%              0.06475 ±  3%  -2.98% (p=0.001 n=7)
List/dqlite-overflows-page/pagination-4               0.1090 ± 24%               0.1173 ±  7%       ~ (p=0.535 n=7)
Update/dqlite-4                                        263.4 ±  0%                263.4 ±  0%       ~ (p=0.874 n=7)
geomean                                                1.251                      1.665        +1.27%               ¹
¹ benchmark set differs from baseline; geomeans may not be comparable

Current status

goos: linux
goarch: amd64
pkg: github.com/canonical/k8s-dqlite/test
cpu: AMD EPYC 7763 64-Core Processor                
                                        │    After     │
                                        │    sec/op    │
Compaction/sqlite-4                       46.25µ ± 11%
Compaction/dqlite-4                       44.23µ ± 10%
Create/sqlite-4                           1.610m ± 15%
Create/dqlite-4                           1.380m ±  4%
Delete/sqlite-4                           1.870m ± 16%
Delete/dqlite-4                           1.621m ± 19%
Get/sqlite-4                              264.3µ ±  1%
Get/dqlite-4                              352.8µ ±  4%
List/sqlite-tiny/all-4                    4.408µ ±  4%
List/sqlite-tiny/pagination-4             8.962µ ±  6%
List/sqlite-fits-in-page/all-4            7.408µ ±  5%
List/sqlite-fits-in-page/pagination-4     22.91µ ±  5%
List/sqlite-overflows-page/all-4          17.46µ ±  5%
List/sqlite-overflows-page/pagination-4   47.00µ ±  7%
List/dqlite-tiny/all-4                    2.796µ ± 12%
List/dqlite-tiny/pagination-4             5.905µ ±  2%
List/dqlite-fits-in-page/all-4            6.153µ ±  4%
List/dqlite-fits-in-page/pagination-4     17.08µ ±  1%
List/dqlite-overflows-page/all-4          19.39µ ±  2%
List/dqlite-overflows-page/pagination-4   42.65µ ±  2%
Update/sqlite-4                           1.637m ± 24%
Update/dqlite-4                           1.442m ± 10%
geomean                                   68.45µ

                                        │        After         │
                                        │ page-cache-misses/op │
Compaction/sqlite-4                               0.000 ± 0%
Compaction/dqlite-4                               0.000 ± 0%
Create/sqlite-4                                   0.000 ± 0%
Create/dqlite-4                                   0.000 ± 0%
Delete/sqlite-4                                   0.000 ± 0%
Delete/dqlite-4                                   0.000 ± 0%
Get/sqlite-4                                      0.000 ± 0%
Get/dqlite-4                                      0.000 ± 0%
List/sqlite-tiny/all-4                            0.000 ± 0%
List/sqlite-tiny/pagination-4                     0.000 ± 0%
List/sqlite-fits-in-page/all-4                    0.000 ± 0%
List/sqlite-fits-in-page/pagination-4             0.000 ± 0%
List/sqlite-overflows-page/all-4                  0.000 ± 0%
List/sqlite-overflows-page/pagination-4           0.000 ± 0%
List/dqlite-tiny/all-4                            0.000 ± 0%
List/dqlite-tiny/pagination-4                     0.000 ± 0%
List/dqlite-fits-in-page/all-4                    0.000 ± 0%
List/dqlite-fits-in-page/pagination-4             0.000 ± 0%
List/dqlite-overflows-page/all-4                  0.000 ± 0%
List/dqlite-overflows-page/pagination-4           0.000 ± 0%
Update/sqlite-4                                   0.000 ± 0%
Update/dqlite-4                                   0.000 ± 0%
geomean                                                      ¹
¹ summaries must be >0 to compute geomean

                                        │        After         │
                                        │ page-cache-spills/op │
Compaction/sqlite-4                               0.000 ± 0%
Compaction/dqlite-4                               0.000 ± 0%
Create/sqlite-4                                   0.000 ± 0%
Create/dqlite-4                                   0.000 ± 0%
Delete/sqlite-4                                   0.000 ± 0%
Delete/dqlite-4                                   0.000 ± 0%
Get/sqlite-4                                      0.000 ± 0%
Get/dqlite-4                                      0.000 ± 0%
List/sqlite-tiny/all-4                            0.000 ± 0%
List/sqlite-tiny/pagination-4                     0.000 ± 0%
List/sqlite-fits-in-page/all-4                    0.000 ± 0%
List/sqlite-fits-in-page/pagination-4             0.000 ± 0%
List/sqlite-overflows-page/all-4                  0.000 ± 0%
List/sqlite-overflows-page/pagination-4           0.000 ± 0%
List/dqlite-tiny/all-4                            0.000 ± 0%
List/dqlite-tiny/pagination-4                     0.000 ± 0%
List/dqlite-fits-in-page/all-4                    0.000 ± 0%
List/dqlite-fits-in-page/pagination-4             0.000 ± 0%
List/dqlite-overflows-page/all-4                  0.000 ± 0%
List/dqlite-overflows-page/pagination-4           0.000 ± 0%
Update/sqlite-4                                   0.000 ± 0%
Update/dqlite-4                                   0.000 ± 0%
geomean                                                      ¹
¹ summaries must be >0 to compute geomean

                                        │     After     │
                                        │ page-reads/op │
Compaction/sqlite-4                         12.22 ±  1%
Compaction/dqlite-4                         12.18 ±  1%
Create/sqlite-4                             13.68 ±  4%
Create/dqlite-4                             12.76 ±  3%
Delete/sqlite-4                             25.01 ±  7%
Delete/dqlite-4                             23.81 ±  1%
Get/sqlite-4                                14.96 ±  0%
Get/dqlite-4                                11.96 ±  0%
List/sqlite-tiny/all-4                     192.2m ±  0%
List/sqlite-tiny/pagination-4               1.132 ±  0%
List/sqlite-fits-in-page/all-4             165.2m ±  0%
List/sqlite-fits-in-page/pagination-4      965.6m ±  3%
List/sqlite-overflows-page/all-4           281.5m ± 25%
List/sqlite-overflows-page/pagination-4     2.081 ±  0%
List/dqlite-tiny/all-4                     191.1m ±  1%
List/dqlite-tiny/pagination-4               1.125 ±  3%
List/dqlite-fits-in-page/all-4             163.3m ± 59%
List/dqlite-fits-in-page/pagination-4      954.6m ±  3%
List/dqlite-overflows-page/all-4           182.7m ±  0%
List/dqlite-overflows-page/pagination-4     1.071 ±  3%
Update/sqlite-4                             25.02 ±  4%
Update/dqlite-4                             23.95 ±  3%
geomean                                     2.395

                                        │     After      │
                                        │ page-writes/op │
Compaction/sqlite-4                        207.3m ± 0%
Compaction/dqlite-4                        188.0m ± 0%
Create/sqlite-4                             5.096 ± 1%
Create/dqlite-4                             4.143 ± 2%
Delete/sqlite-4                             5.319 ± 1%
Delete/dqlite-4                             4.407 ± 1%
Get/sqlite-4                                0.000 ± 0%
Get/dqlite-4                                0.000 ± 0%
List/sqlite-tiny/all-4                      0.000 ± 0%
List/sqlite-tiny/pagination-4               0.000 ± 0%
List/sqlite-fits-in-page/all-4              0.000 ± 0%
List/sqlite-fits-in-page/pagination-4       0.000 ± 0%
List/sqlite-overflows-page/all-4            0.000 ± 0%
List/sqlite-overflows-page/pagination-4     0.000 ± 0%
List/dqlite-tiny/all-4                      0.000 ± 0%
List/dqlite-tiny/pagination-4               0.000 ± 0%
List/dqlite-fits-in-page/all-4              0.000 ± 0%
List/dqlite-fits-in-page/pagination-4       0.000 ± 0%
List/dqlite-overflows-page/all-4            0.000 ± 0%
List/dqlite-overflows-page/pagination-4     0.000 ± 0%
Update/sqlite-4                             5.139 ± 0%
Update/dqlite-4                             4.154 ± 1%
geomean                                                ¹
¹ summaries must be >0 to compute geomean

                                        │     After      │
                                        │ sec-reading/op │
Compaction/sqlite-4                        123.3µ ±  12%
Compaction/dqlite-4                        27.50µ ±  39%
Create/sqlite-4                            70.00µ ± 455%
Create/dqlite-4                            10.00µ ±  52%
Delete/sqlite-4                            397.7µ ± 258%
Delete/dqlite-4                            45.60µ ±  33%
Get/sqlite-4                               88.80µ ±   7%
Get/dqlite-4                               33.00µ ±  11%
List/sqlite-tiny/all-4                     14.10µ ±   4%
List/sqlite-tiny/pagination-4              20.00µ ±   5%
List/sqlite-fits-in-page/all-4             18.00µ ±  21%
List/sqlite-fits-in-page/pagination-4      65.30µ ±   6%
List/sqlite-overflows-page/all-4           65.30µ ±  21%
List/sqlite-overflows-page/pagination-4    179.5µ ±   3%
List/dqlite-tiny/all-4                     4.700µ ±  38%
List/dqlite-tiny/pagination-4              8.200µ ±  15%
List/dqlite-fits-in-page/all-4             10.20µ ±  18%
List/dqlite-fits-in-page/pagination-4      25.10µ ±  21%
List/dqlite-overflows-page/all-4           33.50µ ±   2%
List/dqlite-overflows-page/pagination-4    74.50µ ±  12%
Update/sqlite-4                            180.7µ ± 112%
Update/dqlite-4                            95.20µ ±  17%
geomean                                    40.30µ

                                        │     After      │
                                        │ sec-writing/op │
Compaction/sqlite-4                       10.50µ ±  6%
Compaction/dqlite-4                       7.000µ ±  9%
Create/sqlite-4                           1.357m ± 16%
Create/dqlite-4                           38.10µ ± 26%
Delete/sqlite-4                           1.450m ± 17%
Delete/dqlite-4                           21.50µ ± 22%
Get/sqlite-4                               0.000 ±  0%
Get/dqlite-4                               0.000 ±  0%
List/sqlite-tiny/all-4                     0.000 ±  0%
List/sqlite-tiny/pagination-4              0.000 ±  0%
List/sqlite-fits-in-page/all-4             0.000 ±  0%
List/sqlite-fits-in-page/pagination-4      0.000 ±  0%
List/sqlite-overflows-page/all-4           0.000 ±  0%
List/sqlite-overflows-page/pagination-4    0.000 ±  0%
List/dqlite-tiny/all-4                     0.000 ±  0%
List/dqlite-tiny/pagination-4              0.000 ±  0%
List/dqlite-fits-in-page/all-4             0.000 ±  0%
List/dqlite-fits-in-page/pagination-4      0.000 ±  0%
List/dqlite-overflows-page/all-4           0.000 ±  0%
List/dqlite-overflows-page/pagination-4    0.000 ±  0%
Update/sqlite-4                           1.185m ± 32%
Update/dqlite-4                           14.90µ ± 91%
geomean                                                ¹
¹ summaries must be >0 to compute geomean

                                        │     After      │
                                        │      B/op      │
Compaction/sqlite-4                         471.0 ± 145%
Compaction/dqlite-4                       4.528Ki ±  49%
Create/sqlite-4                           21.28Ki ±   1%
Create/dqlite-4                           20.12Ki ±   0%
Delete/sqlite-4                           32.48Ki ±   6%
Delete/dqlite-4                           29.50Ki ±   0%
Get/sqlite-4                              25.08Ki ±   0%
Get/dqlite-4                              22.89Ki ±   0%
List/sqlite-tiny/all-4                    1.252Ki ±   2%
List/sqlite-tiny/pagination-4             1.820Ki ±   5%
List/sqlite-fits-in-page/all-4            5.200Ki ±   3%
List/sqlite-fits-in-page/pagination-4     10.23Ki ±   1%
List/sqlite-overflows-page/all-4          26.48Ki ±   6%
List/sqlite-overflows-page/pagination-4   46.10Ki ±   0%
List/dqlite-tiny/all-4                      874.0 ±  11%
List/dqlite-tiny/pagination-4               842.0 ±   1%
List/dqlite-fits-in-page/all-4            4.314Ki ±   2%
List/dqlite-fits-in-page/pagination-4     4.410Ki ±   4%
List/dqlite-overflows-page/all-4          21.14Ki ±   1%
List/dqlite-overflows-page/pagination-4   22.66Ki ±   6%
Update/sqlite-4                           30.30Ki ±   2%
Update/dqlite-4                           27.64Ki ±   0%
geomean                                   8.628Ki

                                        │    After     │
                                        │  allocs/op   │
Compaction/sqlite-4                       16.00 ± 181%
Compaction/dqlite-4                       109.0 ±  49%
Create/sqlite-4                           452.0 ±   3%
Create/dqlite-4                           372.0 ±   0%
Delete/sqlite-4                           720.0 ±   8%
Delete/dqlite-4                           510.0 ±   0%
Get/sqlite-4                              563.0 ±   0%
Get/dqlite-4                              407.0 ±   0%
List/sqlite-tiny/all-4                    41.00 ±   2%
List/sqlite-tiny/pagination-4             63.00 ±   5%
List/sqlite-fits-in-page/all-4            48.00 ±   4%
List/sqlite-fits-in-page/pagination-4     93.00 ±   1%
List/sqlite-overflows-page/all-4          56.00 ±   4%
List/sqlite-overflows-page/pagination-4   93.00 ±   0%
List/dqlite-tiny/all-4                    14.00 ±  14%
List/dqlite-tiny/pagination-4             13.00 ±   0%
List/dqlite-fits-in-page/all-4            18.00 ±   6%
List/dqlite-fits-in-page/pagination-4     18.00 ±   6%
List/dqlite-overflows-page/all-4          29.00 ±   0%
List/dqlite-overflows-page/pagination-4   32.00 ±   9%
Update/sqlite-4                           670.0 ±   3%
Update/dqlite-4                           492.0 ±   0%
geomean                                   94.18

                                        │         After         │
                                        │ network-bytes-read/op │
Compaction/dqlite-4                               1.644Ki ± 50%
Create/dqlite-4                                     239.7 ±  0%
Delete/dqlite-4                                   1.156Ki ±  0%
Get/dqlite-4                                      1.134Ki ±  0%
List/dqlite-tiny/all-4                              202.6 ± 18%
List/dqlite-tiny/pagination-4                       189.0 ±  1%
List/dqlite-fits-in-page/all-4                    1.239Ki ±  3%
List/dqlite-fits-in-page/pagination-4             1.255Ki ±  6%
List/dqlite-overflows-page/all-4                  6.194Ki ±  2%
List/dqlite-overflows-page/pagination-4           6.795Ki ±  9%
Update/dqlite-4                                     564.4 ±  0%
geomean                                             986.6

                                        │          After           │
                                        │ network-bytes-written/op │
Compaction/dqlite-4                                    4.438 ±  8%
Create/dqlite-4                                        112.8 ±  1%
Delete/dqlite-4                                        423.4 ±  0%
Get/dqlite-4                                           80.50 ±  0%
List/dqlite-tiny/all-4                               0.04274 ± 34%
List/dqlite-tiny/pagination-4                        0.04634 ±  7%
List/dqlite-fits-in-page/all-4                       0.05279 ±  4%
List/dqlite-fits-in-page/pagination-4                0.07658 ± 20%
List/dqlite-overflows-page/all-4                     0.06475 ±  3%
List/dqlite-overflows-page/pagination-4               0.1173 ±  7%
Update/dqlite-4                                        263.4 ±  0%
geomean                                                1.665

[bschimke95]

LGTM