Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update versioning docs #169

Merged
merged 1 commit into from
Sep 4, 2024
Merged

Update versioning docs #169

merged 1 commit into from
Sep 4, 2024

Conversation

louiseschmidtgen
Copy link
Contributor

Description

Updating versioning docs since MK 1.28 will be pointed at v1.1.11 as well now.

@louiseschmidtgen louiseschmidtgen requested a review from a team as a code owner September 4, 2024 08:49
Copy link
Contributor

@bschimke95 bschimke95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, so no special 1.28 branch anymore? How come?

Copy link

github-actions bot commented Sep 4, 2024

Benchmark Result

goos: linux
goarch: amd64
pkg: github.com/canonical/k8s-dqlite/test
cpu: AMD EPYC 7763 64-Core Processor                
                                        │    Before    │               After                │
                                        │    sec/op    │    sec/op     vs base              │
Compaction/sqlite-4                       35.42µ ± 11%   37.03µ ± 14%       ~ (p=0.535 n=7)
Compaction/dqlite-4                       39.77µ ±  8%   40.21µ ±  6%       ~ (p=0.383 n=7)
Create/sqlite-4                           1.036m ±  4%   1.094m ±  9%  +5.63% (p=0.004 n=7)
Create/dqlite-4                           923.9µ ±  4%   951.4µ ±  9%  +2.98% (p=0.038 n=7)
Delete/sqlite-4                           1.193m ±  1%   1.264m ± 21%  +5.94% (p=0.001 n=7)
Delete/dqlite-4                           1.166m ±  1%   1.200m ±  7%  +2.87% (p=0.007 n=7)
Get/sqlite-4                              266.9µ ±  3%   265.9µ ±  3%       ~ (p=0.165 n=7)
Get/dqlite-4                              357.3µ ±  0%   354.3µ ±  2%       ~ (p=0.073 n=7)
List/sqlite-tiny/all-4                    4.420µ ±  2%   4.441µ ±  3%       ~ (p=0.259 n=7)
List/sqlite-tiny/pagination-4             9.084µ ±  4%   8.740µ ±  5%       ~ (p=0.165 n=7)
List/sqlite-fits-in-page/all-4            7.521µ ±  2%   7.337µ ±  3%       ~ (p=0.053 n=7)
List/sqlite-fits-in-page/pagination-4     22.78µ ±  1%   23.16µ ±  2%  +1.67% (p=0.017 n=7)
List/sqlite-overflows-page/all-4          17.69µ ±  5%   17.82µ ±  5%       ~ (p=0.053 n=7)
List/sqlite-overflows-page/pagination-4   47.38µ ±  2%   47.76µ ±  3%       ~ (p=0.620 n=7)
List/dqlite-tiny/all-4                    2.779µ ±  6%   2.747µ ± 11%       ~ (p=0.154 n=7)
List/dqlite-tiny/pagination-4             5.930µ ±  4%   5.947µ ±  3%       ~ (p=0.710 n=7)
List/dqlite-fits-in-page/all-4            6.028µ ±  3%   6.140µ ±  3%  +1.86% (p=0.011 n=7)
List/dqlite-fits-in-page/pagination-4     17.08µ ±  3%   16.98µ ±  4%       ~ (p=0.535 n=7)
List/dqlite-overflows-page/all-4          18.91µ ±  2%   19.02µ ±  2%       ~ (p=0.456 n=7)
List/dqlite-overflows-page/pagination-4   42.76µ ±  2%   43.37µ ±  2%  +1.43% (p=0.017 n=7)
Update/sqlite-4                           1.215m ±  2%   1.206m ±  2%       ~ (p=0.073 n=7)
Update/dqlite-4                           1.244m ±  2%   1.229m ±  3%       ~ (p=0.209 n=7)
geomean                                   61.34µ         61.87µ        +0.87%

                                        │        Before        │                    After                     │
                                        │ page-cache-misses/op │ page-cache-misses/op  vs base                │
Compaction/sqlite-4                               0.000 ± 0%               0.000 ± 0%       ~ (p=1.000 n=7) ¹
Compaction/dqlite-4                               0.000 ± 0%               0.000 ± 0%       ~ (p=1.000 n=7) ¹
Create/sqlite-4                                   0.000 ± 0%               0.000 ± 0%       ~ (p=1.000 n=7) ¹
Create/dqlite-4                                   0.000 ± 0%               0.000 ± 0%       ~ (p=1.000 n=7) ¹
Delete/sqlite-4                                   0.000 ± 0%               0.000 ± 0%       ~ (p=1.000 n=7) ¹
Delete/dqlite-4                                   0.000 ± 0%               0.000 ± 0%       ~ (p=1.000 n=7) ¹
Get/sqlite-4                                      0.000 ± 0%               0.000 ± 0%       ~ (p=1.000 n=7) ¹
Get/dqlite-4                                      0.000 ± 0%               0.000 ± 0%       ~ (p=1.000 n=7) ¹
List/sqlite-tiny/all-4                            0.000 ± 0%               0.000 ± 0%       ~ (p=1.000 n=7) ¹
List/sqlite-tiny/pagination-4                     0.000 ± 0%               0.000 ± 0%       ~ (p=1.000 n=7) ¹
List/sqlite-fits-in-page/all-4                    0.000 ± 0%               0.000 ± 0%       ~ (p=1.000 n=7) ¹
List/sqlite-fits-in-page/pagination-4             0.000 ± 0%               0.000 ± 0%       ~ (p=1.000 n=7) ¹
List/sqlite-overflows-page/all-4                  0.000 ± 0%               0.000 ± 0%       ~ (p=1.000 n=7) ¹
List/sqlite-overflows-page/pagination-4           0.000 ± 0%               0.000 ± 0%       ~ (p=1.000 n=7) ¹
List/dqlite-tiny/all-4                            0.000 ± 0%               0.000 ± 0%       ~ (p=1.000 n=7) ¹
List/dqlite-tiny/pagination-4                     0.000 ± 0%               0.000 ± 0%       ~ (p=1.000 n=7) ¹
List/dqlite-fits-in-page/all-4                    0.000 ± 0%               0.000 ± 0%       ~ (p=1.000 n=7) ¹
List/dqlite-fits-in-page/pagination-4             0.000 ± 0%               0.000 ± 0%       ~ (p=1.000 n=7) ¹
List/dqlite-overflows-page/all-4                  0.000 ± 0%               0.000 ± 0%       ~ (p=1.000 n=7) ¹
List/dqlite-overflows-page/pagination-4           0.000 ± 0%               0.000 ± 0%       ~ (p=1.000 n=7) ¹
Update/sqlite-4                                   0.000 ± 0%               0.000 ± 0%       ~ (p=1.000 n=7) ¹
Update/dqlite-4                                   0.000 ± 0%               0.000 ± 0%       ~ (p=1.000 n=7) ¹
geomean                                                      ²                         +0.00%               ²
¹ all samples are equal
² summaries must be >0 to compute geomean

                                        │        Before        │                    After                     │
                                        │ page-cache-spills/op │ page-cache-spills/op  vs base                │
Compaction/sqlite-4                               0.000 ± 0%               0.000 ± 0%       ~ (p=1.000 n=7) ¹
Compaction/dqlite-4                               0.000 ± 0%               0.000 ± 0%       ~ (p=1.000 n=7) ¹
Create/sqlite-4                                   0.000 ± 0%               0.000 ± 0%       ~ (p=1.000 n=7) ¹
Create/dqlite-4                                   0.000 ± 0%               0.000 ± 0%       ~ (p=1.000 n=7) ¹
Delete/sqlite-4                                   0.000 ± 0%               0.000 ± 0%       ~ (p=1.000 n=7) ¹
Delete/dqlite-4                                   0.000 ± 0%               0.000 ± 0%       ~ (p=1.000 n=7) ¹
Get/sqlite-4                                      0.000 ± 0%               0.000 ± 0%       ~ (p=1.000 n=7) ¹
Get/dqlite-4                                      0.000 ± 0%               0.000 ± 0%       ~ (p=1.000 n=7) ¹
List/sqlite-tiny/all-4                            0.000 ± 0%               0.000 ± 0%       ~ (p=1.000 n=7) ¹
List/sqlite-tiny/pagination-4                     0.000 ± 0%               0.000 ± 0%       ~ (p=1.000 n=7) ¹
List/sqlite-fits-in-page/all-4                    0.000 ± 0%               0.000 ± 0%       ~ (p=1.000 n=7) ¹
List/sqlite-fits-in-page/pagination-4             0.000 ± 0%               0.000 ± 0%       ~ (p=1.000 n=7) ¹
List/sqlite-overflows-page/all-4                  0.000 ± 0%               0.000 ± 0%       ~ (p=1.000 n=7) ¹
List/sqlite-overflows-page/pagination-4           0.000 ± 0%               0.000 ± 0%       ~ (p=1.000 n=7) ¹
List/dqlite-tiny/all-4                            0.000 ± 0%               0.000 ± 0%       ~ (p=1.000 n=7) ¹
List/dqlite-tiny/pagination-4                     0.000 ± 0%               0.000 ± 0%       ~ (p=1.000 n=7) ¹
List/dqlite-fits-in-page/all-4                    0.000 ± 0%               0.000 ± 0%       ~ (p=1.000 n=7) ¹
List/dqlite-fits-in-page/pagination-4             0.000 ± 0%               0.000 ± 0%       ~ (p=1.000 n=7) ¹
List/dqlite-overflows-page/all-4                  0.000 ± 0%               0.000 ± 0%       ~ (p=1.000 n=7) ¹
List/dqlite-overflows-page/pagination-4           0.000 ± 0%               0.000 ± 0%       ~ (p=1.000 n=7) ¹
Update/sqlite-4                                   0.000 ± 0%               0.000 ± 0%       ~ (p=1.000 n=7) ¹
Update/dqlite-4                                   0.000 ± 0%               0.000 ± 0%       ~ (p=1.000 n=7) ¹
geomean                                                      ²                         +0.00%               ²
¹ all samples are equal
² summaries must be >0 to compute geomean

                                        │    Before     │                After                │
                                        │ page-reads/op │ page-reads/op  vs base              │
Compaction/sqlite-4                         12.15 ±  1%     12.17 ±  1%       ~ (p=0.734 n=7)
Compaction/dqlite-4                         12.19 ±  1%     12.20 ±  1%       ~ (p=0.733 n=7)
Create/sqlite-4                             14.37 ±  0%     14.28 ±  0%  -0.63% (p=0.002 n=7)
Create/dqlite-4                             13.22 ±  1%     13.18 ±  1%       ~ (p=0.118 n=7)
Delete/sqlite-4                             25.07 ±  1%     25.17 ±  1%       ~ (p=0.971 n=7)
Delete/dqlite-4                             23.96 ±  1%     23.60 ±  1%  -1.50% (p=0.001 n=7)
Get/sqlite-4                                14.96 ±  0%     14.95 ±  0%       ~ (p=0.869 n=7)
Get/dqlite-4                                11.96 ±  0%     11.96 ±  0%       ~ (p=1.000 n=7)
List/sqlite-tiny/all-4                     192.4m ±  0%    192.3m ±  0%       ~ (p=0.809 n=7)
List/sqlite-tiny/pagination-4               1.132 ±  0%     1.132 ±  0%       ~ (p=1.000 n=7)
List/sqlite-fits-in-page/all-4             164.9m ±  0%    165.0m ±  0%       ~ (p=0.835 n=7)
List/sqlite-fits-in-page/pagination-4      965.6m ±  0%    965.6m ±  3%       ~ (p=0.714 n=7)
List/sqlite-overflows-page/all-4           284.8m ± 16%    281.4m ± 22%       ~ (p=0.902 n=7)
List/sqlite-overflows-page/pagination-4     2.080 ±  2%     2.080 ±  0%       ~ (p=0.364 n=7)
List/dqlite-tiny/all-4                     191.2m ±  1%    191.0m ±  1%  -0.10% (p=0.011 n=7)
List/dqlite-tiny/pagination-4               1.125 ±  3%     1.125 ±  3%       ~ (p=1.000 n=7)
List/dqlite-fits-in-page/all-4             163.1m ± 59%    163.2m ±  0%       ~ (p=0.314 n=7)
List/dqlite-fits-in-page/pagination-4      954.3m ±  3%    954.5m ±  3%       ~ (p=0.986 n=7)
List/dqlite-overflows-page/all-4           182.8m ±  0%    182.8m ±  0%       ~ (p=0.633 n=7)
List/dqlite-overflows-page/pagination-4     1.070 ±  3%     1.071 ±  3%       ~ (p=0.266 n=7)
Update/sqlite-4                             25.78 ±  1%     25.83 ±  1%       ~ (p=0.157 n=7)
Update/dqlite-4                             24.76 ±  1%     24.81 ±  1%       ~ (p=0.686 n=7)
geomean                                     2.413           2.410        -0.12%

                                        │     Before     │                 After                  │
                                        │ page-writes/op │ page-writes/op  vs base                │
Compaction/sqlite-4                        207.8m ± 0%        207.9m ± 0%       ~ (p=0.310 n=7)
Compaction/dqlite-4                        188.1m ± 1%        187.6m ± 0%       ~ (p=0.217 n=7)
Create/sqlite-4                             5.228 ± 0%         5.201 ± 1%  -0.52% (p=0.002 n=7)
Create/dqlite-4                             4.301 ± 1%         4.301 ± 0%       ~ (p=0.822 n=7)
Delete/sqlite-4                             5.323 ± 1%         5.323 ± 1%       ~ (p=0.401 n=7)
Delete/dqlite-4                             4.423 ± 0%         4.427 ± 1%       ~ (p=0.689 n=7)
Get/sqlite-4                                0.000 ± 0%         0.000 ± 0%       ~ (p=1.000 n=7) ¹
Get/dqlite-4                                0.000 ± 0%         0.000 ± 0%       ~ (p=1.000 n=7) ¹
List/sqlite-tiny/all-4                      0.000 ± 0%         0.000 ± 0%       ~ (p=1.000 n=7) ¹
List/sqlite-tiny/pagination-4               0.000 ± 0%         0.000 ± 0%       ~ (p=1.000 n=7) ¹
List/sqlite-fits-in-page/all-4              0.000 ± 0%         0.000 ± 0%       ~ (p=1.000 n=7) ¹
List/sqlite-fits-in-page/pagination-4       0.000 ± 0%         0.000 ± 0%       ~ (p=1.000 n=7) ¹
List/sqlite-overflows-page/all-4            0.000 ± 0%         0.000 ± 0%       ~ (p=1.000 n=7) ¹
List/sqlite-overflows-page/pagination-4     0.000 ± 0%         0.000 ± 0%       ~ (p=1.000 n=7) ¹
List/dqlite-tiny/all-4                      0.000 ± 0%         0.000 ± 0%       ~ (p=1.000 n=7) ¹
List/dqlite-tiny/pagination-4               0.000 ± 0%         0.000 ± 0%       ~ (p=1.000 n=7) ¹
List/dqlite-fits-in-page/all-4              0.000 ± 0%         0.000 ± 0%       ~ (p=1.000 n=7) ¹
List/dqlite-fits-in-page/pagination-4       0.000 ± 0%         0.000 ± 0%       ~ (p=1.000 n=7) ¹
List/dqlite-overflows-page/all-4            0.000 ± 0%         0.000 ± 0%       ~ (p=1.000 n=7) ¹
List/dqlite-overflows-page/pagination-4     0.000 ± 0%         0.000 ± 0%       ~ (p=1.000 n=7) ¹
Update/sqlite-4                             5.160 ± 0%         5.158 ± 0%       ~ (p=0.969 n=7)
Update/dqlite-4                             4.171 ± 0%         4.170 ± 0%       ~ (p=0.223 n=7)
geomean                                                ²                   -0.03%               ²
¹ all samples are equal
² summaries must be >0 to compute geomean

                                        │     Before     │                After                 │
                                        │ sec-reading/op │ sec-reading/op  vs base              │
Compaction/sqlite-4                         111.5µ ± 19%     117.2µ ± 25%       ~ (p=0.456 n=7)
Compaction/dqlite-4                         29.30µ ± 49%     31.10µ ± 37%       ~ (p=0.559 n=7)
Create/sqlite-4                             29.00µ ± 45%     36.00µ ± 62%       ~ (p=0.805 n=7)
Create/dqlite-4                             10.30µ ± 52%     10.40µ ± 42%       ~ (p=0.805 n=7)
Delete/sqlite-4                             199.4µ ± 37%     154.9µ ± 84%       ~ (p=0.902 n=7)
Delete/dqlite-4                             50.80µ ± 19%     50.60µ ± 14%       ~ (p=0.710 n=7)
Get/sqlite-4                                87.00µ ±  4%     85.30µ ± 14%       ~ (p=0.209 n=7)
Get/dqlite-4                                32.70µ ± 13%     32.70µ ± 10%       ~ (p=0.686 n=7)
List/sqlite-tiny/all-4                      14.30µ ±  3%     14.30µ ±  3%       ~ (p=0.865 n=7)
List/sqlite-tiny/pagination-4               20.00µ ±  5%     19.10µ ±  8%       ~ (p=0.241 n=7)
List/sqlite-fits-in-page/all-4              17.00µ ± 25%     16.70µ ± 20%       ~ (p=0.535 n=7)
List/sqlite-fits-in-page/pagination-4       63.70µ ±  1%     63.70µ ±  2%       ~ (p=0.914 n=7)
List/sqlite-overflows-page/all-4            64.00µ ± 14%     69.20µ ± 14%       ~ (p=0.165 n=7)
List/sqlite-overflows-page/pagination-4     178.3µ ±  1%     179.7µ ±  2%       ~ (p=0.128 n=7)
List/dqlite-tiny/all-4                      3.900µ ± 18%     3.900µ ± 31%       ~ (p=0.592 n=7)
List/dqlite-tiny/pagination-4               8.400µ ± 18%     8.500µ ± 11%       ~ (p=0.872 n=7)
List/dqlite-fits-in-page/all-4              8.800µ ± 17%     8.800µ ±  3%       ~ (p=0.916 n=7)
List/dqlite-fits-in-page/pagination-4       25.60µ ± 21%     25.50µ ± 20%       ~ (p=0.402 n=7)
List/dqlite-overflows-page/all-4            32.60µ ±  2%     32.80µ ±  3%       ~ (p=0.301 n=7)
List/dqlite-overflows-page/pagination-4     75.00µ ± 19%     73.40µ ± 12%       ~ (p=0.710 n=7)
Update/sqlite-4                             164.5µ ± 27%     196.5µ ± 38%       ~ (p=0.259 n=7)
Update/dqlite-4                             109.2µ ± 17%     111.1µ ± 17%       ~ (p=0.318 n=7)
geomean                                     37.03µ           37.48µ        +1.23%

                                        │     Before     │                 After                  │
                                        │ sec-writing/op │ sec-writing/op  vs base                │
Compaction/sqlite-4                       9.800µ ± 30%      10.200µ ± 16%       ~ (p=0.783 n=7)
Compaction/dqlite-4                       6.900µ ± 13%       6.900µ ± 10%       ~ (p=0.513 n=7)
Create/sqlite-4                           782.4µ ±  6%       855.3µ ± 11%  +9.32% (p=0.004 n=7)
Create/dqlite-4                           39.80µ ± 26%       37.50µ ± 26%       ~ (p=0.456 n=7)
Delete/sqlite-4                           809.4µ ±  4%       886.1µ ± 23%  +9.48% (p=0.001 n=7)
Delete/dqlite-4                           21.30µ ± 19%       22.90µ ± 42%       ~ (p=0.073 n=7)
Get/sqlite-4                               0.000 ±  0%        0.000 ±  0%       ~ (p=1.000 n=7) ¹
Get/dqlite-4                               0.000 ±  0%        0.000 ±  0%       ~ (p=1.000 n=7) ¹
List/sqlite-tiny/all-4                     0.000 ±  0%        0.000 ±  0%       ~ (p=1.000 n=7) ¹
List/sqlite-tiny/pagination-4              0.000 ±  0%        0.000 ±  0%       ~ (p=1.000 n=7) ¹
List/sqlite-fits-in-page/all-4             0.000 ±  0%        0.000 ±  0%       ~ (p=1.000 n=7) ¹
List/sqlite-fits-in-page/pagination-4      0.000 ±  0%        0.000 ±  0%       ~ (p=1.000 n=7) ¹
List/sqlite-overflows-page/all-4           0.000 ±  0%        0.000 ±  0%       ~ (p=1.000 n=7) ¹
List/sqlite-overflows-page/pagination-4    0.000 ±  0%        0.000 ±  0%       ~ (p=1.000 n=7) ¹
List/dqlite-tiny/all-4                     0.000 ±  0%        0.000 ±  0%       ~ (p=1.000 n=7) ¹
List/dqlite-tiny/pagination-4              0.000 ±  0%        0.000 ±  0%       ~ (p=1.000 n=7) ¹
List/dqlite-fits-in-page/all-4             0.000 ±  0%        0.000 ±  0%       ~ (p=1.000 n=7) ¹
List/dqlite-fits-in-page/pagination-4      0.000 ±  0%        0.000 ±  0%       ~ (p=1.000 n=7) ¹
List/dqlite-overflows-page/all-4           0.000 ±  0%        0.000 ±  0%       ~ (p=1.000 n=7) ¹
List/dqlite-overflows-page/pagination-4    0.000 ±  0%        0.000 ±  0%       ~ (p=1.000 n=7) ¹
Update/sqlite-4                           766.2µ ±  3%       756.8µ ±  4%       ~ (p=0.710 n=7)
Update/dqlite-4                           22.90µ ± 41%       21.50µ ± 53%       ~ (p=1.000 n=7)
geomean                                                ²                   +0.72%               ²
¹ all samples are equal
² summaries must be >0 to compute geomean

                                        │    Before     │                After                │
                                        │     B/op      │     B/op       vs base              │
Compaction/sqlite-4                         896.0 ± 56%     996.0 ± 61%       ~ (p=0.805 n=7)
Compaction/dqlite-4                       5.043Ki ± 72%   5.411Ki ± 55%       ~ (p=0.620 n=7)
Create/sqlite-4                           21.30Ki ±  0%   21.31Ki ±  0%       ~ (p=0.207 n=7)
Create/dqlite-4                           20.05Ki ±  0%   20.05Ki ±  0%       ~ (p=0.825 n=7)
Delete/sqlite-4                           32.53Ki ±  1%   32.62Ki ±  1%       ~ (p=0.510 n=7)
Delete/dqlite-4                           29.44Ki ±  0%   29.45Ki ±  0%  +0.04% (p=0.023 n=7)
Get/sqlite-4                              25.08Ki ±  0%   25.08Ki ±  0%       ~ (p=1.000 n=7)
Get/dqlite-4                              22.89Ki ±  0%   22.89Ki ±  0%       ~ (p=0.230 n=7)
List/sqlite-tiny/all-4                    1.267Ki ±  2%   1.263Ki ±  2%       ~ (p=0.804 n=7)
List/sqlite-tiny/pagination-4             1.844Ki ±  5%   1.807Ki ±  4%       ~ (p=0.135 n=7)
List/sqlite-fits-in-page/all-4            5.131Ki ±  2%   5.160Ki ±  2%       ~ (p=1.000 n=7)
List/sqlite-fits-in-page/pagination-4     10.24Ki ±  0%   10.23Ki ±  0%       ~ (p=0.644 n=7)
List/sqlite-overflows-page/all-4          26.48Ki ±  4%   26.52Ki ±  5%       ~ (p=1.000 n=7)
List/sqlite-overflows-page/pagination-4   46.11Ki ±  1%   46.12Ki ±  0%       ~ (p=0.902 n=7)
List/dqlite-tiny/all-4                      869.0 ±  9%     858.0 ± 13%  -1.27% (p=0.043 n=7)
List/dqlite-tiny/pagination-4               842.0 ±  1%     840.0 ±  1%       ~ (p=0.970 n=7)
List/dqlite-fits-in-page/all-4            4.282Ki ±  1%   4.311Ki ±  1%  +0.66% (p=0.019 n=7)
List/dqlite-fits-in-page/pagination-4     4.359Ki ±  6%   4.396Ki ±  4%       ~ (p=0.620 n=7)
List/dqlite-overflows-page/all-4          21.23Ki ±  0%   21.17Ki ±  1%       ~ (p=0.383 n=7)
List/dqlite-overflows-page/pagination-4   22.75Ki ±  4%   23.12Ki ±  2%  +1.64% (p=0.017 n=7)
Update/sqlite-4                           30.27Ki ±  0%   30.23Ki ±  1%       ~ (p=0.535 n=7)
Update/dqlite-4                           27.60Ki ±  0%   27.60Ki ±  0%       ~ (p=0.327 n=7)
geomean                                   8.923Ki         8.994Ki        +0.80%

                                        │   Before    │                After                │
                                        │  allocs/op  │  allocs/op   vs base                │
Compaction/sqlite-4                       34.00 ± 62%   38.00 ± 66%       ~ (p=0.827 n=7)
Compaction/dqlite-4                       122.0 ± 72%   131.0 ± 55%       ~ (p=0.559 n=7)
Create/sqlite-4                           455.0 ±  0%   455.0 ±  0%       ~ (p=0.462 n=7)
Create/dqlite-4                           372.0 ±  0%   372.0 ±  0%       ~ (p=1.000 n=7) ¹
Delete/sqlite-4                           725.0 ±  1%   726.0 ±  1%       ~ (p=0.784 n=7)
Delete/dqlite-4                           511.0 ±  0%   511.0 ±  0%       ~ (p=1.000 n=7) ¹
Get/sqlite-4                              563.0 ±  0%   563.0 ±  0%       ~ (p=1.000 n=7) ¹
Get/dqlite-4                              407.0 ±  0%   407.0 ±  0%       ~ (p=1.000 n=7) ¹
List/sqlite-tiny/all-4                    41.00 ±  2%   41.00 ±  2%       ~ (p=0.734 n=7)
List/sqlite-tiny/pagination-4             64.00 ±  5%   62.00 ±  5%       ~ (p=0.219 n=7)
List/sqlite-fits-in-page/all-4            47.00 ±  4%   47.00 ±  2%       ~ (p=0.988 n=7)
List/sqlite-fits-in-page/pagination-4     93.00 ±  0%   93.00 ±  0%       ~ (p=1.000 n=7) ¹
List/sqlite-overflows-page/all-4          56.00 ±  4%   56.00 ±  5%       ~ (p=0.900 n=7)
List/sqlite-overflows-page/pagination-4   93.00 ±  0%   93.00 ±  0%       ~ (p=1.000 n=7) ¹
List/dqlite-tiny/all-4                    14.00 ± 14%   14.00 ± 21%       ~ (p=0.437 n=7)
List/dqlite-tiny/pagination-4             13.00 ±  0%   13.00 ±  0%       ~ (p=1.000 n=7) ¹
List/dqlite-fits-in-page/all-4            18.00 ±  6%   18.00 ±  0%       ~ (p=1.000 n=7)
List/dqlite-fits-in-page/pagination-4     18.00 ±  6%   18.00 ±  6%       ~ (p=0.633 n=7)
List/dqlite-overflows-page/all-4          29.00 ±  0%   29.00 ±  3%       ~ (p=1.000 n=7)
List/dqlite-overflows-page/pagination-4   32.00 ±  6%   33.00 ±  3%       ~ (p=0.057 n=7)
Update/sqlite-4                           670.0 ±  1%   669.0 ±  1%       ~ (p=0.679 n=7)
Update/dqlite-4                           492.0 ±  0%   492.0 ±  0%       ~ (p=1.000 n=7) ¹
geomean                                   98.01         98.82        +0.83%
¹ all samples are equal

                                        │        Before         │                    After                    │
                                        │ network-bytes-read/op │ network-bytes-read/op  vs base              │
Compaction/dqlite-4                               1.835Ki ± 73%           1.973Ki ± 56%       ~ (p=0.620 n=7)
Create/dqlite-4                                     242.1 ±  0%             241.9 ±  0%       ~ (p=0.186 n=7)
Delete/dqlite-4                                   1.161Ki ±  0%           1.161Ki ±  0%       ~ (p=0.731 n=7)
Get/dqlite-4                                      1.133Ki ±  0%           1.133Ki ±  0%       ~ (p=0.437 n=7)
List/dqlite-tiny/all-4                              203.8 ± 15%             199.7 ± 22%  -2.01% (p=0.016 n=7)
List/dqlite-tiny/pagination-4                       189.4 ±  2%             188.8 ±  2%       ~ (p=0.364 n=7)
List/dqlite-fits-in-page/all-4                    1.225Ki ±  2%           1.234Ki ±  1%  +0.80% (p=0.041 n=7)
List/dqlite-fits-in-page/pagination-4             1.232Ki ±  6%           1.247Ki ±  6%       ~ (p=0.535 n=7)
List/dqlite-overflows-page/all-4                  6.236Ki ±  1%           6.204Ki ±  2%       ~ (p=0.435 n=7)
List/dqlite-overflows-page/pagination-4           6.769Ki ±  6%           7.019Ki ±  3%  +3.69% (p=0.011 n=7)
Update/dqlite-4                                     565.0 ±  0%             565.1 ±  0%  +0.02% (p=0.004 n=7)
geomean                                             996.2                  1005.2        +0.90%

                                        │          Before          │                      After                      │
                                        │ network-bytes-written/op │ network-bytes-written/op  vs base               │
Compaction/dqlite-4                                    4.574 ± 14%                4.571 ± 10%        ~ (p=0.710 n=7)
Create/dqlite-4                                        117.2 ±  1%                116.9 ±  1%        ~ (p=0.076 n=7)
Delete/dqlite-4                                        425.6 ±  0%                425.5 ±  0%        ~ (p=0.277 n=7)
Get/dqlite-4                                           80.57 ±  0%                80.57 ±  0%        ~ (p=1.000 n=7)
List/dqlite-tiny/all-4                               0.04319 ± 29%              0.04166 ± 42%   -3.54% (p=0.017 n=7)
List/dqlite-tiny/pagination-4                        0.04556 ± 11%              0.04470 ± 10%        ~ (p=1.000 n=7)
List/dqlite-fits-in-page/all-4                       0.05215 ±  3%              0.05288 ±  2%   +1.40% (p=0.038 n=7)
List/dqlite-fits-in-page/pagination-4                0.07523 ± 19%              0.07799 ± 11%        ~ (p=0.620 n=7)
List/dqlite-overflows-page/all-4                     0.06499 ±  1%              0.06440 ±  3%        ~ (p=0.209 n=7)
List/dqlite-overflows-page/pagination-4               0.1092 ± 25%               0.1298 ± 11%  +18.86% (p=0.026 n=7)
Update/dqlite-4                                        263.7 ±  0%                263.7 ±  0%        ~ (p=0.911 n=7)
geomean                                                1.661                      1.685         +1.42%
Current status
goos: linux
goarch: amd64
pkg: github.com/canonical/k8s-dqlite/test
cpu: AMD EPYC 7763 64-Core Processor                
                                        │    After     │
                                        │    sec/op    │
Compaction/sqlite-4                       37.03µ ± 14%
Compaction/dqlite-4                       40.21µ ±  6%
Create/sqlite-4                           1.094m ±  9%
Create/dqlite-4                           951.4µ ±  9%
Delete/sqlite-4                           1.264m ± 21%
Delete/dqlite-4                           1.200m ±  7%
Get/sqlite-4                              265.9µ ±  3%
Get/dqlite-4                              354.3µ ±  2%
List/sqlite-tiny/all-4                    4.441µ ±  3%
List/sqlite-tiny/pagination-4             8.740µ ±  5%
List/sqlite-fits-in-page/all-4            7.337µ ±  3%
List/sqlite-fits-in-page/pagination-4     23.16µ ±  2%
List/sqlite-overflows-page/all-4          17.82µ ±  5%
List/sqlite-overflows-page/pagination-4   47.76µ ±  3%
List/dqlite-tiny/all-4                    2.747µ ± 11%
List/dqlite-tiny/pagination-4             5.947µ ±  3%
List/dqlite-fits-in-page/all-4            6.140µ ±  3%
List/dqlite-fits-in-page/pagination-4     16.98µ ±  4%
List/dqlite-overflows-page/all-4          19.02µ ±  2%
List/dqlite-overflows-page/pagination-4   43.37µ ±  2%
Update/sqlite-4                           1.206m ±  2%
Update/dqlite-4                           1.229m ±  3%
geomean                                   61.87µ

                                        │        After         │
                                        │ page-cache-misses/op │
Compaction/sqlite-4                               0.000 ± 0%
Compaction/dqlite-4                               0.000 ± 0%
Create/sqlite-4                                   0.000 ± 0%
Create/dqlite-4                                   0.000 ± 0%
Delete/sqlite-4                                   0.000 ± 0%
Delete/dqlite-4                                   0.000 ± 0%
Get/sqlite-4                                      0.000 ± 0%
Get/dqlite-4                                      0.000 ± 0%
List/sqlite-tiny/all-4                            0.000 ± 0%
List/sqlite-tiny/pagination-4                     0.000 ± 0%
List/sqlite-fits-in-page/all-4                    0.000 ± 0%
List/sqlite-fits-in-page/pagination-4             0.000 ± 0%
List/sqlite-overflows-page/all-4                  0.000 ± 0%
List/sqlite-overflows-page/pagination-4           0.000 ± 0%
List/dqlite-tiny/all-4                            0.000 ± 0%
List/dqlite-tiny/pagination-4                     0.000 ± 0%
List/dqlite-fits-in-page/all-4                    0.000 ± 0%
List/dqlite-fits-in-page/pagination-4             0.000 ± 0%
List/dqlite-overflows-page/all-4                  0.000 ± 0%
List/dqlite-overflows-page/pagination-4           0.000 ± 0%
Update/sqlite-4                                   0.000 ± 0%
Update/dqlite-4                                   0.000 ± 0%
geomean                                                      ¹
¹ summaries must be >0 to compute geomean

                                        │        After         │
                                        │ page-cache-spills/op │
Compaction/sqlite-4                               0.000 ± 0%
Compaction/dqlite-4                               0.000 ± 0%
Create/sqlite-4                                   0.000 ± 0%
Create/dqlite-4                                   0.000 ± 0%
Delete/sqlite-4                                   0.000 ± 0%
Delete/dqlite-4                                   0.000 ± 0%
Get/sqlite-4                                      0.000 ± 0%
Get/dqlite-4                                      0.000 ± 0%
List/sqlite-tiny/all-4                            0.000 ± 0%
List/sqlite-tiny/pagination-4                     0.000 ± 0%
List/sqlite-fits-in-page/all-4                    0.000 ± 0%
List/sqlite-fits-in-page/pagination-4             0.000 ± 0%
List/sqlite-overflows-page/all-4                  0.000 ± 0%
List/sqlite-overflows-page/pagination-4           0.000 ± 0%
List/dqlite-tiny/all-4                            0.000 ± 0%
List/dqlite-tiny/pagination-4                     0.000 ± 0%
List/dqlite-fits-in-page/all-4                    0.000 ± 0%
List/dqlite-fits-in-page/pagination-4             0.000 ± 0%
List/dqlite-overflows-page/all-4                  0.000 ± 0%
List/dqlite-overflows-page/pagination-4           0.000 ± 0%
Update/sqlite-4                                   0.000 ± 0%
Update/dqlite-4                                   0.000 ± 0%
geomean                                                      ¹
¹ summaries must be >0 to compute geomean

                                        │     After     │
                                        │ page-reads/op │
Compaction/sqlite-4                         12.17 ±  1%
Compaction/dqlite-4                         12.20 ±  1%
Create/sqlite-4                             14.28 ±  0%
Create/dqlite-4                             13.18 ±  1%
Delete/sqlite-4                             25.17 ±  1%
Delete/dqlite-4                             23.60 ±  1%
Get/sqlite-4                                14.95 ±  0%
Get/dqlite-4                                11.96 ±  0%
List/sqlite-tiny/all-4                     192.3m ±  0%
List/sqlite-tiny/pagination-4               1.132 ±  0%
List/sqlite-fits-in-page/all-4             165.0m ±  0%
List/sqlite-fits-in-page/pagination-4      965.6m ±  3%
List/sqlite-overflows-page/all-4           281.4m ± 22%
List/sqlite-overflows-page/pagination-4     2.080 ±  0%
List/dqlite-tiny/all-4                     191.0m ±  1%
List/dqlite-tiny/pagination-4               1.125 ±  3%
List/dqlite-fits-in-page/all-4             163.2m ±  0%
List/dqlite-fits-in-page/pagination-4      954.5m ±  3%
List/dqlite-overflows-page/all-4           182.8m ±  0%
List/dqlite-overflows-page/pagination-4     1.071 ±  3%
Update/sqlite-4                             25.83 ±  1%
Update/dqlite-4                             24.81 ±  1%
geomean                                     2.410

                                        │     After      │
                                        │ page-writes/op │
Compaction/sqlite-4                        207.9m ± 0%
Compaction/dqlite-4                        187.6m ± 0%
Create/sqlite-4                             5.201 ± 1%
Create/dqlite-4                             4.301 ± 0%
Delete/sqlite-4                             5.323 ± 1%
Delete/dqlite-4                             4.427 ± 1%
Get/sqlite-4                                0.000 ± 0%
Get/dqlite-4                                0.000 ± 0%
List/sqlite-tiny/all-4                      0.000 ± 0%
List/sqlite-tiny/pagination-4               0.000 ± 0%
List/sqlite-fits-in-page/all-4              0.000 ± 0%
List/sqlite-fits-in-page/pagination-4       0.000 ± 0%
List/sqlite-overflows-page/all-4            0.000 ± 0%
List/sqlite-overflows-page/pagination-4     0.000 ± 0%
List/dqlite-tiny/all-4                      0.000 ± 0%
List/dqlite-tiny/pagination-4               0.000 ± 0%
List/dqlite-fits-in-page/all-4              0.000 ± 0%
List/dqlite-fits-in-page/pagination-4       0.000 ± 0%
List/dqlite-overflows-page/all-4            0.000 ± 0%
List/dqlite-overflows-page/pagination-4     0.000 ± 0%
Update/sqlite-4                             5.158 ± 0%
Update/dqlite-4                             4.170 ± 0%
geomean                                                ¹
¹ summaries must be >0 to compute geomean

                                        │     After      │
                                        │ sec-reading/op │
Compaction/sqlite-4                         117.2µ ± 25%
Compaction/dqlite-4                         31.10µ ± 37%
Create/sqlite-4                             36.00µ ± 62%
Create/dqlite-4                             10.40µ ± 42%
Delete/sqlite-4                             154.9µ ± 84%
Delete/dqlite-4                             50.60µ ± 14%
Get/sqlite-4                                85.30µ ± 14%
Get/dqlite-4                                32.70µ ± 10%
List/sqlite-tiny/all-4                      14.30µ ±  3%
List/sqlite-tiny/pagination-4               19.10µ ±  8%
List/sqlite-fits-in-page/all-4              16.70µ ± 20%
List/sqlite-fits-in-page/pagination-4       63.70µ ±  2%
List/sqlite-overflows-page/all-4            69.20µ ± 14%
List/sqlite-overflows-page/pagination-4     179.7µ ±  2%
List/dqlite-tiny/all-4                      3.900µ ± 31%
List/dqlite-tiny/pagination-4               8.500µ ± 11%
List/dqlite-fits-in-page/all-4              8.800µ ±  3%
List/dqlite-fits-in-page/pagination-4       25.50µ ± 20%
List/dqlite-overflows-page/all-4            32.80µ ±  3%
List/dqlite-overflows-page/pagination-4     73.40µ ± 12%
Update/sqlite-4                             196.5µ ± 38%
Update/dqlite-4                             111.1µ ± 17%
geomean                                     37.48µ

                                        │     After      │
                                        │ sec-writing/op │
Compaction/sqlite-4                       10.20µ ± 16%
Compaction/dqlite-4                       6.900µ ± 10%
Create/sqlite-4                           855.3µ ± 11%
Create/dqlite-4                           37.50µ ± 26%
Delete/sqlite-4                           886.1µ ± 23%
Delete/dqlite-4                           22.90µ ± 42%
Get/sqlite-4                               0.000 ±  0%
Get/dqlite-4                               0.000 ±  0%
List/sqlite-tiny/all-4                     0.000 ±  0%
List/sqlite-tiny/pagination-4              0.000 ±  0%
List/sqlite-fits-in-page/all-4             0.000 ±  0%
List/sqlite-fits-in-page/pagination-4      0.000 ±  0%
List/sqlite-overflows-page/all-4           0.000 ±  0%
List/sqlite-overflows-page/pagination-4    0.000 ±  0%
List/dqlite-tiny/all-4                     0.000 ±  0%
List/dqlite-tiny/pagination-4              0.000 ±  0%
List/dqlite-fits-in-page/all-4             0.000 ±  0%
List/dqlite-fits-in-page/pagination-4      0.000 ±  0%
List/dqlite-overflows-page/all-4           0.000 ±  0%
List/dqlite-overflows-page/pagination-4    0.000 ±  0%
Update/sqlite-4                           756.8µ ±  4%
Update/dqlite-4                           21.50µ ± 53%
geomean                                                ¹
¹ summaries must be >0 to compute geomean

                                        │     After     │
                                        │     B/op      │
Compaction/sqlite-4                         996.0 ± 61%
Compaction/dqlite-4                       5.411Ki ± 55%
Create/sqlite-4                           21.31Ki ±  0%
Create/dqlite-4                           20.05Ki ±  0%
Delete/sqlite-4                           32.62Ki ±  1%
Delete/dqlite-4                           29.45Ki ±  0%
Get/sqlite-4                              25.08Ki ±  0%
Get/dqlite-4                              22.89Ki ±  0%
List/sqlite-tiny/all-4                    1.263Ki ±  2%
List/sqlite-tiny/pagination-4             1.807Ki ±  4%
List/sqlite-fits-in-page/all-4            5.160Ki ±  2%
List/sqlite-fits-in-page/pagination-4     10.23Ki ±  0%
List/sqlite-overflows-page/all-4          26.52Ki ±  5%
List/sqlite-overflows-page/pagination-4   46.12Ki ±  0%
List/dqlite-tiny/all-4                      858.0 ± 13%
List/dqlite-tiny/pagination-4               840.0 ±  1%
List/dqlite-fits-in-page/all-4            4.311Ki ±  1%
List/dqlite-fits-in-page/pagination-4     4.396Ki ±  4%
List/dqlite-overflows-page/all-4          21.17Ki ±  1%
List/dqlite-overflows-page/pagination-4   23.12Ki ±  2%
Update/sqlite-4                           30.23Ki ±  1%
Update/dqlite-4                           27.60Ki ±  0%
geomean                                   8.994Ki

                                        │    After    │
                                        │  allocs/op  │
Compaction/sqlite-4                       38.00 ± 66%
Compaction/dqlite-4                       131.0 ± 55%
Create/sqlite-4                           455.0 ±  0%
Create/dqlite-4                           372.0 ±  0%
Delete/sqlite-4                           726.0 ±  1%
Delete/dqlite-4                           511.0 ±  0%
Get/sqlite-4                              563.0 ±  0%
Get/dqlite-4                              407.0 ±  0%
List/sqlite-tiny/all-4                    41.00 ±  2%
List/sqlite-tiny/pagination-4             62.00 ±  5%
List/sqlite-fits-in-page/all-4            47.00 ±  2%
List/sqlite-fits-in-page/pagination-4     93.00 ±  0%
List/sqlite-overflows-page/all-4          56.00 ±  5%
List/sqlite-overflows-page/pagination-4   93.00 ±  0%
List/dqlite-tiny/all-4                    14.00 ± 21%
List/dqlite-tiny/pagination-4             13.00 ±  0%
List/dqlite-fits-in-page/all-4            18.00 ±  0%
List/dqlite-fits-in-page/pagination-4     18.00 ±  6%
List/dqlite-overflows-page/all-4          29.00 ±  3%
List/dqlite-overflows-page/pagination-4   33.00 ±  3%
Update/sqlite-4                           669.0 ±  1%
Update/dqlite-4                           492.0 ±  0%
geomean                                   98.82

                                        │         After         │
                                        │ network-bytes-read/op │
Compaction/dqlite-4                               1.973Ki ± 56%
Create/dqlite-4                                     241.9 ±  0%
Delete/dqlite-4                                   1.161Ki ±  0%
Get/dqlite-4                                      1.133Ki ±  0%
List/dqlite-tiny/all-4                              199.7 ± 22%
List/dqlite-tiny/pagination-4                       188.8 ±  2%
List/dqlite-fits-in-page/all-4                    1.234Ki ±  1%
List/dqlite-fits-in-page/pagination-4             1.247Ki ±  6%
List/dqlite-overflows-page/all-4                  6.204Ki ±  2%
List/dqlite-overflows-page/pagination-4           7.019Ki ±  3%
Update/dqlite-4                                     565.1 ±  0%
geomean                                            1005.2

                                        │          After           │
                                        │ network-bytes-written/op │
Compaction/dqlite-4                                    4.571 ± 10%
Create/dqlite-4                                        116.9 ±  1%
Delete/dqlite-4                                        425.5 ±  0%
Get/dqlite-4                                           80.57 ±  0%
List/dqlite-tiny/all-4                               0.04166 ± 42%
List/dqlite-tiny/pagination-4                        0.04470 ± 10%
List/dqlite-fits-in-page/all-4                       0.05288 ±  2%
List/dqlite-fits-in-page/pagination-4                0.07799 ± 11%
List/dqlite-overflows-page/all-4                     0.06440 ±  3%
List/dqlite-overflows-page/pagination-4               0.1298 ± 11%
Update/dqlite-4                                        263.7 ±  0%
geomean                                                1.685

@louiseschmidtgen
Copy link
Contributor Author

LGTM, so no special 1.28 branch anymore? How come?

We could not get the snap to pass the core addons upgrade test so we assume there is a bug-fix somewhere between the old version and the newer v1.1.11 version of k8s-dqlite. So we point it to the newer version.

@louiseschmidtgen louiseschmidtgen merged commit 7e926ad into master Sep 4, 2024
7 checks passed
@marco6 marco6 deleted the update-version-doc branch September 26, 2024 06:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants