Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1.29 conformance fixes #92

Merged
merged 8 commits into from
Mar 6, 2024
Merged

Conversation

neoaggelos
Copy link
Contributor

@neoaggelos neoaggelos commented Feb 28, 2024

Summary

Update k8s-dqlite to pass the Kubernetes 1.29 conformance tests

Changes

  • Compaction only ignores the last 100 revisions (from 1000).
  • List responses return keys in alphabetical order.
  • List requests with paging now return the correct Count of results that remain
  • List requests with paging properly handle the start key.
  • Properly handle list responses where the keys revisions are not in alphabetical order.

See the individual commits for details. Each commit is accompanied by a test case that doesn't work without the introduced changes.

@neoaggelos neoaggelos requested a review from a team as a code owner February 28, 2024 15:13
@neoaggelos neoaggelos force-pushed the KU-444/1.29-conformance-fixes branch from 615dd19 to af089be Compare March 4, 2024 07:49
@ktsakalozos ktsakalozos changed the title [wip] 1.29 conformance fixes 1.29 conformance fixes Mar 6, 2024
Copy link
Member

@ktsakalozos ktsakalozos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM +1

@ktsakalozos ktsakalozos merged commit 9fb964d into master Mar 6, 2024
9 checks passed
@berkayoz berkayoz deleted the KU-444/1.29-conformance-fixes branch September 2, 2024 07:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants