-
Notifications
You must be signed in to change notification settings - Fork 13
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Add unit tests for Calico network k8sd feature (#647)
* Add unit tests for calico k8sd network feature * Remove t.Helper from cilium tests
- Loading branch information
1 parent
11d088a
commit 1b51ba7
Showing
5 changed files
with
248 additions
and
27 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,222 @@ | ||
| package calico_test | ||
|
|
||
| import ( | ||
| "context" | ||
| "errors" | ||
| "testing" | ||
|
|
||
| . "github.com/onsi/gomega" | ||
|
|
||
| "github.com/canonical/k8s/pkg/client/helm" | ||
| helmmock "github.com/canonical/k8s/pkg/client/helm/mock" | ||
| "github.com/canonical/k8s/pkg/k8sd/features/calico" | ||
| "github.com/canonical/k8s/pkg/k8sd/types" | ||
| snapmock "github.com/canonical/k8s/pkg/snap/mock" | ||
| "github.com/canonical/k8s/pkg/utils" | ||
| "k8s.io/utils/ptr" | ||
| ) | ||
|
|
||
| // NOTE(hue): status.Message is not checked sometimes to avoid unnecessary complexity | ||
|
|
||
| var defaultAnnotations = types.Annotations{ | ||
| "k8sd/v1alpha1/calico/apiserver-enabled": "true", | ||
| "k8sd/v1alpha1/calico/encapsulation-v4": "VXLAN", | ||
| "k8sd/v1alpha1/calico/encapsulation-v6": "VXLAN", | ||
| "k8sd/v1alpha1/calico/autodetection-v4/firstFound": "true", | ||
| "k8sd/v1alpha1/calico/autodetection-v6/firstFound": "true", | ||
| } | ||
|
|
||
| func TestDisabled(t *testing.T) { | ||
| t.Run("HelmApplyFails", func(t *testing.T) { | ||
| g := NewWithT(t) | ||
|
|
||
| applyErr := errors.New("failed to apply") | ||
| helmM := &helmmock.Mock{ | ||
| ApplyErr: applyErr, | ||
| } | ||
| snapM := &snapmock.Snap{ | ||
| Mock: snapmock.Mock{ | ||
| HelmClient: helmM, | ||
| }, | ||
| } | ||
| cfg := types.Network{ | ||
| Enabled: ptr.To(false), | ||
| } | ||
|
|
||
| status, err := calico.ApplyNetwork(context.Background(), snapM, cfg, nil) | ||
|
|
||
| g.Expect(err).To(MatchError(applyErr)) | ||
| g.Expect(status.Enabled).To(BeFalse()) | ||
| g.Expect(status.Message).To(ContainSubstring(applyErr.Error())) | ||
| g.Expect(status.Version).To(Equal(calico.CalicoTag)) | ||
| g.Expect(helmM.ApplyCalledWith).To(HaveLen(1)) | ||
|
|
||
| callArgs := helmM.ApplyCalledWith[0] | ||
| g.Expect(callArgs.Chart).To(Equal(calico.ChartCalico)) | ||
| g.Expect(callArgs.State).To(Equal(helm.StateDeleted)) | ||
| g.Expect(callArgs.Values).To(BeNil()) | ||
| }) | ||
| t.Run("Success", func(t *testing.T) { | ||
| g := NewWithT(t) | ||
|
|
||
| helmM := &helmmock.Mock{} | ||
| snapM := &snapmock.Snap{ | ||
| Mock: snapmock.Mock{ | ||
| HelmClient: helmM, | ||
| }, | ||
| } | ||
| cfg := types.Network{ | ||
| Enabled: ptr.To(false), | ||
| } | ||
|
|
||
| status, err := calico.ApplyNetwork(context.Background(), snapM, cfg, nil) | ||
|
|
||
| g.Expect(err).ToNot(HaveOccurred()) | ||
| g.Expect(status.Enabled).To(BeFalse()) | ||
| g.Expect(status.Message).To(Equal(calico.DisabledMsg)) | ||
| g.Expect(status.Version).To(Equal(calico.CalicoTag)) | ||
| g.Expect(helmM.ApplyCalledWith).To(HaveLen(1)) | ||
|
|
||
| callArgs := helmM.ApplyCalledWith[0] | ||
| g.Expect(callArgs.Chart).To(Equal(calico.ChartCalico)) | ||
| g.Expect(callArgs.State).To(Equal(helm.StateDeleted)) | ||
| g.Expect(callArgs.Values).To(BeNil()) | ||
| }) | ||
| } | ||
|
|
||
| func TestEnabled(t *testing.T) { | ||
| t.Run("InvalidPodCIDR", func(t *testing.T) { | ||
| g := NewWithT(t) | ||
|
|
||
| helmM := &helmmock.Mock{} | ||
| snapM := &snapmock.Snap{ | ||
| Mock: snapmock.Mock{ | ||
| HelmClient: helmM, | ||
| }, | ||
| } | ||
| cfg := types.Network{ | ||
| Enabled: ptr.To(true), | ||
| PodCIDR: ptr.To("invalid-cidr"), | ||
| } | ||
|
|
||
| status, err := calico.ApplyNetwork(context.Background(), snapM, cfg, defaultAnnotations) | ||
|
|
||
| g.Expect(err).To(HaveOccurred()) | ||
| g.Expect(status.Enabled).To(BeFalse()) | ||
| g.Expect(status.Version).To(Equal(calico.CalicoTag)) | ||
| g.Expect(helmM.ApplyCalledWith).To(HaveLen(0)) | ||
| }) | ||
| t.Run("InvalidServiceCIDR", func(t *testing.T) { | ||
| g := NewWithT(t) | ||
|
|
||
| helmM := &helmmock.Mock{} | ||
| snapM := &snapmock.Snap{ | ||
| Mock: snapmock.Mock{ | ||
| HelmClient: helmM, | ||
| }, | ||
| } | ||
| cfg := types.Network{ | ||
| Enabled: ptr.To(true), | ||
| PodCIDR: ptr.To("192.0.2.0/24,2001:db8::/32"), | ||
| ServiceCIDR: ptr.To("invalid-cidr"), | ||
| } | ||
|
|
||
| status, err := calico.ApplyNetwork(context.Background(), snapM, cfg, defaultAnnotations) | ||
|
|
||
| g.Expect(err).To(HaveOccurred()) | ||
| g.Expect(status.Enabled).To(BeFalse()) | ||
| g.Expect(status.Version).To(Equal(calico.CalicoTag)) | ||
| g.Expect(helmM.ApplyCalledWith).To(HaveLen(0)) | ||
| }) | ||
| t.Run("HelmApplyFails", func(t *testing.T) { | ||
| g := NewWithT(t) | ||
|
|
||
| applyErr := errors.New("failed to apply") | ||
| helmM := &helmmock.Mock{ | ||
| ApplyErr: applyErr, | ||
| } | ||
| snapM := &snapmock.Snap{ | ||
| Mock: snapmock.Mock{ | ||
| HelmClient: helmM, | ||
| }, | ||
| } | ||
| cfg := types.Network{ | ||
| Enabled: ptr.To(true), | ||
| PodCIDR: ptr.To("192.0.2.0/24,2001:db8::/32"), | ||
| ServiceCIDR: ptr.To("192.0.2.0/24,2001:db8::/32"), | ||
| } | ||
|
|
||
| status, err := calico.ApplyNetwork(context.Background(), snapM, cfg, defaultAnnotations) | ||
|
|
||
| g.Expect(err).To(MatchError(applyErr)) | ||
| g.Expect(status.Enabled).To(BeFalse()) | ||
| g.Expect(status.Message).To(ContainSubstring(applyErr.Error())) | ||
| g.Expect(status.Version).To(Equal(calico.CalicoTag)) | ||
| g.Expect(helmM.ApplyCalledWith).To(HaveLen(1)) | ||
|
|
||
| callArgs := helmM.ApplyCalledWith[0] | ||
| g.Expect(callArgs.Chart).To(Equal(calico.ChartCalico)) | ||
| g.Expect(callArgs.State).To(Equal(helm.StatePresent)) | ||
| validateValues(t, callArgs.Values, cfg) | ||
| }) | ||
| t.Run("Success", func(t *testing.T) { | ||
| g := NewWithT(t) | ||
|
|
||
| helmM := &helmmock.Mock{} | ||
| snapM := &snapmock.Snap{ | ||
| Mock: snapmock.Mock{ | ||
| HelmClient: helmM, | ||
| }, | ||
| } | ||
| cfg := types.Network{ | ||
| Enabled: ptr.To(true), | ||
| PodCIDR: ptr.To("192.0.2.0/24,2001:db8::/32"), | ||
| ServiceCIDR: ptr.To("192.0.2.0/24,2001:db8::/32"), | ||
| } | ||
|
|
||
| status, err := calico.ApplyNetwork(context.Background(), snapM, cfg, defaultAnnotations) | ||
|
|
||
| g.Expect(err).ToNot(HaveOccurred()) | ||
| g.Expect(status.Enabled).To(BeTrue()) | ||
| g.Expect(status.Message).To(Equal(calico.EnabledMsg)) | ||
| g.Expect(status.Version).To(Equal(calico.CalicoTag)) | ||
| g.Expect(helmM.ApplyCalledWith).To(HaveLen(1)) | ||
|
|
||
| callArgs := helmM.ApplyCalledWith[0] | ||
| g.Expect(callArgs.Chart).To(Equal(calico.ChartCalico)) | ||
| g.Expect(callArgs.State).To(Equal(helm.StatePresent)) | ||
| validateValues(t, callArgs.Values, cfg) | ||
| }) | ||
| } | ||
|
|
||
| func validateValues(t *testing.T, values map[string]any, cfg types.Network) { | ||
| g := NewWithT(t) | ||
|
|
||
| podIPv4CIDR, podIPv6CIDR, err := utils.ParseCIDRs(cfg.GetPodCIDR()) | ||
| g.Expect(err).ToNot(HaveOccurred()) | ||
|
|
||
| svcIPv4CIDR, svcIPv6CIDR, err := utils.ParseCIDRs(cfg.GetServiceCIDR()) | ||
| g.Expect(err).ToNot(HaveOccurred()) | ||
|
|
||
| // calico network | ||
| calicoNetwork := values["installation"].(map[string]any)["calicoNetwork"].(map[string]any) | ||
| g.Expect(calicoNetwork["ipPools"].([]map[string]any)).To(ContainElements(map[string]any{ | ||
| "name": "ipv4-ippool", | ||
| "cidr": podIPv4CIDR, | ||
| "encapsulation": "VXLAN", | ||
| })) | ||
| g.Expect(calicoNetwork["ipPools"].([]map[string]any)).To(ContainElements(map[string]any{ | ||
| "name": "ipv6-ippool", | ||
| "cidr": podIPv6CIDR, | ||
| "encapsulation": "VXLAN", | ||
| })) | ||
| g.Expect(calicoNetwork["ipPools"].([]map[string]any)).To(HaveLen(2)) | ||
| g.Expect(calicoNetwork["nodeAddressAutodetectionV4"].(map[string]any)["firstFound"]).To(Equal(true)) | ||
| g.Expect(calicoNetwork["nodeAddressAutodetectionV6"].(map[string]any)["firstFound"]).To(Equal(true)) | ||
|
|
||
| g.Expect(values["apiServer"].(map[string]any)["enabled"]).To(Equal(true)) | ||
|
|
||
| // service CIDRs | ||
| g.Expect(values["serviceCIDRs"].([]string)).To(ContainElements(svcIPv4CIDR, svcIPv6CIDR)) | ||
| g.Expect(values["serviceCIDRs"].([]string)).To(HaveLen(2)) | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters