Update feature status on failed apply (#601)

Update feature status on failed apply

src/k8s/pkg/k8sd/controllers/feature.go

@@ -131,10 +131,14 @@ func (c *FeatureController) reconcile(
 		return fmt.Errorf("failed to retrieve cluster configuration: %w", err)
 	}
 
-	if featureStatus, err := apply(cfg); err != nil {
-		return fmt.Errorf("failed to apply configuration: %w", err)
-	} else if err := updateFeatureStatus(ctx, featureStatus); err != nil {
-		return fmt.Errorf("failed to update feature status: %w", err)
+	status, applyErr := apply(cfg)
+	if err := updateFeatureStatus(ctx, status); err != nil {
+		// NOTE (hue): status update errors are not returned but only logged. we might need some retry logic in the future.
+		log.FromContext(ctx).WithValues("message", status.Message, "applied-successfully", applyErr == nil).Error(err, "Failed to update feature status")
+	}
+
+	if applyErr != nil {
+		return fmt.Errorf("failed to apply configuration: %w", applyErr)
 	}
 
 	return nil