Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kubectl.md: fix typo #463

Merged
merged 1 commit into from
Jun 10, 2024
Merged

kubectl.md: fix typo #463

merged 1 commit into from
Jun 10, 2024

Conversation

dulmandakh
Copy link
Contributor

I was reading through the documentation, and found this typo

@dulmandakh dulmandakh requested a review from a team as a code owner June 3, 2024 09:20
bschimke95
bschimke95 previously approved these changes Jun 3, 2024
Copy link
Contributor

@bschimke95 bschimke95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution @dulmandakh!

Please make sure to sign the CLA.

@bschimke95 bschimke95 self-requested a review June 3, 2024 10:13
@bschimke95 bschimke95 dismissed their stale review June 3, 2024 10:13

Markdown linter not ready

@bschimke95
Copy link
Contributor

@dulmandakh there was an issue with our markdown linter that I addressed in #464
Please rebase your PR to fix the failing CI test.
Thanks!

Copy link
Contributor

@bschimke95 bschimke95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requires rebase on main and CLA signing, thanks!

@dulmandakh
Copy link
Contributor Author

Requires rebase on main and CLA signing, thanks!

rebased, and IIRC, I already signed CLA

Copy link
Contributor

@bschimke95 bschimke95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for your contribution!

@bschimke95 bschimke95 merged commit 5faf42c into canonical:main Jun 10, 2024
14 checks passed
eaudetcobello pushed a commit that referenced this pull request Jun 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants