Add CAPI node-remove endpoint #509
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bschimke95
force-pushed
the
KU-963/node-deletion
branch
2 times, most recently
from
f7ac073
to
fa49e42
Compare
bschimke95
force-pushed
the
KU-963/node-deletion
branch
from
fa49e42
to
787e22a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add a new endpoint
x/capi/remove-nodethat is protected by the CAPI access handler.Rationale
This is a prerequisite for the removal of machines from a CAPI workload cluster. Similar to the
x/capi/set-auth-tokenwe cannot simply reuse the existing removal endpoint (k8sd/cluster/remove) as the CAPI management cluster lacks a proper auth mechanism for this.See #498 for more on this.