Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch default encapsulation to VXLAN, add annotations for autodetection #514

Merged
merged 6 commits into from
Jul 3, 2024
Merged

Switch default encapsulation to VXLAN, add annotations for autodetection #514

merged 6 commits into from
Jul 3, 2024

Conversation

berkayoz
Copy link
Member

  • Changed default encapsulation to VXLAN for both IPv4 and IPv6 pools
  • Disabled Calico api server deployment by default
  • Added annotations for node address auto detection

@berkayoz berkayoz requested a review from a team as a code owner June 26, 2024 05:05
neoaggelos
neoaggelos reviewed Jun 26, 2024
View reviewed changes
Copy link
Contributor

@neoaggelos neoaggelos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, style comments and some possible improvements

src/k8s/pkg/k8sd/features/calico/internal.go Outdated Show resolved Hide resolved
src/k8s/pkg/k8sd/features/calico/internal.go Outdated Show resolved Hide resolved
src/k8s/pkg/k8sd/features/calico/internal.go Outdated Show resolved Hide resolved
src/k8s/pkg/k8sd/features/calico/internal.go Outdated Show resolved Hide resolved
src/k8s/pkg/k8sd/features/calico/internal.go Show resolved Hide resolved
src/k8s/pkg/k8sd/features/calico/internal.go Outdated Show resolved Hide resolved
src/k8s/pkg/k8sd/features/calico/internal.go Outdated Show resolved Hide resolved
@berkayoz berkayoz requested a review from neoaggelos June 27, 2024 10:27
neoaggelos
neoaggelos suggested changes Jun 27, 2024
View reviewed changes
Copy link
Contributor

@neoaggelos neoaggelos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Final comment, let's avoid an extra step of structs, since helm values need to be map[string]any at the end of the day

src/k8s/pkg/k8sd/features/calico/chart.go Outdated Show resolved Hide resolved
src/k8s/pkg/k8sd/features/calico/network.go Outdated Show resolved Hide resolved
src/k8s/pkg/k8sd/features/calico/internal.go Outdated Show resolved Hide resolved
src/k8s/pkg/k8sd/features/calico/network.go Outdated Show resolved Hide resolved
@berkayoz berkayoz requested a review from neoaggelos June 28, 2024 10:45
neoaggelos
neoaggelos reviewed Jun 28, 2024
View reviewed changes
Copy link
Contributor

@neoaggelos neoaggelos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, mostly style comments

src/k8s/pkg/k8sd/features/calico/internal.go Outdated Show resolved Hide resolved
src/k8s/pkg/k8sd/features/calico/chart.go Outdated Show resolved Hide resolved
src/k8s/pkg/k8sd/features/calico/internal.go Outdated Show resolved Hide resolved
src/k8s/pkg/k8sd/features/calico/internal.go Outdated Show resolved Hide resolved
src/k8s/pkg/k8sd/features/calico/network.go Outdated Show resolved Hide resolved
@berkayoz berkayoz requested a review from neoaggelos July 1, 2024 10:11
neoaggelos
neoaggelos reviewed Jul 1, 2024
View reviewed changes
src/k8s/pkg/k8sd/features/calico/cleanup.go Outdated Show resolved Hide resolved
src/k8s/pkg/k8sd/features/calico/internal.go Outdated Show resolved Hide resolved
src/k8s/pkg/k8sd/features/calico/internal.go Outdated Show resolved Hide resolved
src/k8s/pkg/k8sd/features/calico/internal.go Outdated Show resolved Hide resolved
@berkayoz berkayoz requested a review from neoaggelos July 2, 2024 08:07
@berkayoz berkayoz merged commit 2bb842f into main Jul 3, 2024
17 checks passed
@berkayoz berkayoz deleted the KU-1018/calico-configs branch July 3, 2024 09:12
louiseschmidtgen pushed a commit that referenced this pull request Jul 4, 2024
@berkayoz @louiseschmidtgen
Switch default calico encapsulation to VXLAN, add annotations for aut…
c1f9c28 
…odetection (#514)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@neoaggelos neoaggelos neoaggelos approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@berkayoz @neoaggelos