Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sync Contour images #516

Merged
merged 14 commits into from
Jul 3, 2024
Merged

Sync Contour images #516

merged 14 commits into from
Jul 3, 2024

Conversation

louiseschmidtgen
Copy link
Contributor

@louiseschmidtgen louiseschmidtgen commented Jun 27, 2024 •
edited
Loading

Description

Sync contour images to ghcr.io/canonical.

docker.io/envoyproxy/envoy:v1.29.2
ghcr.io/projectcontour/contour:v1.28.2
docker.io/bitnami/contour:1.28.2-debian-12-r4
docker.io/bitnami/envoy:1.28.2-debian-12-r0

Manipulated the pulled gateway provisioner manifests to be able to set the images via helm values:

    spec:
      containers:
      - args:
        - gateway-provisioner
        - --metrics-addr=127.0.0.1:8080
        - --enable-leader-election
        - --envoy-image={{ .Values.envoyproxy.image.repository }}:{{ .Values.envoyproxy.image.tag }}
        - --contour-image={{ .Values.projectcontour.image.repository }}:{{ .Values.projectcontour.image.tag }}
        command: ["contour"]
        image: "{{ .Values.projectcontour.image.repository }}:{{ .Values.projectcontour.image.tag }}"
        imagePullPolicy: IfNotPresent
        name: contour-gateway-provisioner

Note: Gateway provisioner uses envoyproxy image v1.29.2 instead of v1.28.2 in their release for gateway provisioner v1.28.2.

Sidenote: Gateway provisioner allows you to change the images used by setting these args here.

@louiseschmidtgen louiseschmidtgen changed the title Ku 1024/contour images Sync contour images Jun 27, 2024
@louiseschmidtgen louiseschmidtgen changed the title Sync contour images Sync Contour images Jun 27, 2024
neoaggelos
neoaggelos reviewed Jun 28, 2024
View reviewed changes
Copy link
Contributor

@neoaggelos neoaggelos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remember to update the images that contour reports.

@louiseschmidtgen louiseschmidtgen marked this pull request as ready for review July 2, 2024 12:30
@louiseschmidtgen louiseschmidtgen requested a review from a team as a code owner July 2, 2024 12:30
neoaggelos
neoaggelos reviewed Jul 2, 2024
View reviewed changes
Copy link
Contributor

@neoaggelos neoaggelos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are also missing the updated list of images in register.go

src/k8s/pkg/k8sd/features/contour/chart.go Outdated Show resolved Hide resolved
neoaggelos
neoaggelos suggested changes Jul 3, 2024
View reviewed changes
src/k8s/pkg/k8sd/features/contour/register.go Outdated Show resolved Hide resolved
src/k8s/pkg/k8sd/features/contour/ingress.go Outdated Show resolved Hide resolved
neoaggelos
neoaggelos approved these changes Jul 3, 2024
View reviewed changes
Copy link
Contributor

@neoaggelos neoaggelos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost there!

src/k8s/pkg/k8sd/features/contour/chart.go Outdated Show resolved Hide resolved
@louiseschmidtgen louiseschmidtgen merged commit e96042b into main Jul 3, 2024
17 checks passed
@louiseschmidtgen louiseschmidtgen deleted the KU-1024/contour-images branch July 3, 2024 12:25
louiseschmidtgen added a commit that referenced this pull request Jul 4, 2024
@louiseschmidtgen
Sync Contour images (#516)
99bc2e4 
* enable setting image in gateway chart

* ingress images

* hackery & sed wizardry gateway imgs

* better comments

* gateway img values

* upstream images update

* simplify

* fix registry/repo

* update envoyproxy img tag

* add note about envoy img version

* update img tag target

* add img in register.go

* rm separate registry value

* naming
louiseschmidtgen added a commit that referenced this pull request Jul 4, 2024
@louiseschmidtgen
Sync Contour images (#516)
a75f3e8 
* enable setting image in gateway chart

* ingress images

* hackery & sed wizardry gateway imgs

* better comments

* gateway img values

* upstream images update

* simplify

* fix registry/repo

* update envoyproxy img tag

* add note about envoy img version

* update img tag target

* add img in register.go

* rm separate registry value

* naming
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@neoaggelos neoaggelos neoaggelos approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@louiseschmidtgen @neoaggelos