Cleanup on failed k8s bootstrap an k8s join-cluster attempts
#521
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neoaggelos
force-pushed
the
KU-1013/cleanup
branch
from
c544f4f
to
7853340
Compare
bschimke95
approved these changes
Jul 1, 2024
| metav1 "k8s.io/apimachinery/pkg/apis/meta/v1" | ||
| "k8s.io/client-go/util/retry" | ||
| ) | ||
|
|
||
| // DeleteNode will remove a node from the kubernetes cluster. | ||
| // DeleteNode will retry if there is a conflict on the resource. | ||
| // DeleteNode will not fail if the node does not |
neoaggelos
force-pushed
the
KU-1013/timeouts
branch
from
a4bcbb6
to
3620fba
Compare
neoaggelos
force-pushed
the
KU-1013/cleanup
branch
from
7853340
to
ba8e00c
Compare
Merged
louiseschmidtgen
pushed a commit
that referenced
this pull request
Jul 4, 2024
* cleanup on failed bootstrap * cleanup on failed worker join * create a local microcluster client on App * start cleanup on control plane join * do not block remove hook
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Merge after #520
Changes
k8s bootstrap, remove all configs, stop control plane services, then useResetClusterMember. This resets the microcluster state. Note that this runs automatically by k8sd, no manual action from the client is required.k8s join-clusterfor worker nodes, similarly revert configs, then useResetClusterMemberk8s join-clusterfor control plane nodes: When thepostJoinhook runs, the node has already joined microcluster. Therefore, we need to revert configs, but also make sure to useDeleteClusterMember, such that the failed node is removed from the cluster before resetting.Notes
k8s remove-nodecommand, instead of delaying the completion of thek8s join-clustercommand.