Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Follow up ingress & gateway e2e tests #528

Merged
merged 10 commits into from
Jul 8, 2024
Merged

Conversation

louiseschmidtgen
Copy link
Contributor

Description

This PR addresses potential test flakiness as raised in this comment: here.

@louiseschmidtgen louiseschmidtgen changed the title Follow up ingress & gateway e2e tests WIP Follow up ingress & gateway e2e tests Jul 3, 2024
@louiseschmidtgen louiseschmidtgen changed the title WIP Follow up ingress & gateway e2e tests Follow up ingress & gateway e2e tests Jul 4, 2024
@louiseschmidtgen louiseschmidtgen marked this pull request as ready for review July 4, 2024 10:02
@louiseschmidtgen louiseschmidtgen requested a review from a team as a code owner July 4, 2024 10:02
Copy link
Contributor

@bschimke95 bschimke95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, only minor comment

tests/integration/tests/test_gateway.py Outdated Show resolved Hide resolved
tests/integration/tests/test_gateway.py Show resolved Hide resolved
Copy link
Contributor

@bschimke95 bschimke95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@louiseschmidtgen louiseschmidtgen merged commit e229caa into main Jul 8, 2024
18 checks passed
@louiseschmidtgen louiseschmidtgen deleted the KU-1035/contour-tests branch July 8, 2024 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants