Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dualstack integration tests #532

Merged
merged 16 commits into from
Jul 11, 2024
Merged

Conversation

bschimke95
Copy link
Contributor

Summary

Adds a test that verifies the Canonical K8s dual-stack setup by deploying a nginx service and connecting to it. This is right now only supported by LXD. Other test harnesses will fail.

Notable changes

  • Adds lxd overlay profile for dualstack that configures a network bridge to eth0
  • Refactor setup of lxd profiles
  • Setup lxd profile and network for dualstack if configrued
  • Add dualstack config parameters: LXD_DUALSTACK_NETWORK, LXD_DUALSTACK_PROFILE_NAME, LXD_DUALSTACK_PROFILE

@bschimke95 bschimke95 requested a review from a team as a code owner July 4, 2024 15:56
@bschimke95 bschimke95 force-pushed the KU-827/dualstack-integration-test branch from b89bb22 to 9e2bb50 Compare July 5, 2024 05:59
Copy link
Contributor

@neoaggelos neoaggelos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, mostly style comments here

tests/integration/tests/test_dualstack.py Outdated Show resolved Hide resolved
tests/integration/tests/conftest.py Show resolved Hide resolved
tests/integration/tests/test_dualstack.py Outdated Show resolved Hide resolved
tests/integration/tests/test_dualstack.py Outdated Show resolved Hide resolved
tests/integration/tests/test_util/harness/lxd.py Outdated Show resolved Hide resolved
tests/integration/tests/test_util/harness/lxd.py Outdated Show resolved Hide resolved
tests/integration/tests/test_util/util.py Outdated Show resolved Hide resolved
Copy link
Contributor

@neoaggelos neoaggelos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggested some small improvements

tests/integration/tests/test_dualstack.py Outdated Show resolved Hide resolved
tests/integration/tests/test_util/harness/lxd.py Outdated Show resolved Hide resolved
@bschimke95 bschimke95 force-pushed the KU-827/dualstack-integration-test branch from 958a76e to 3dc255d Compare July 10, 2024 09:51
@bschimke95 bschimke95 merged commit 4e96859 into main Jul 11, 2024
18 checks passed
@bschimke95 bschimke95 deleted the KU-827/dualstack-integration-test branch July 11, 2024 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants