Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove extra bookeeping for worker nodes #533

Merged
merged 5 commits into from
Jul 8, 2024
Merged

Conversation

neoaggelos
Copy link
Contributor

@neoaggelos neoaggelos commented Jul 8, 2024

Summary

Remove extraneous worker nodes table.

Changes

This table is used as bookkeeping for cluster worker nodes, but only causes issues right now:

  • If a worker node has already left the cluster, it is impossible to remove it, as the client.DeleteNode() will fail.
  • If a worker node fails to join, then it still gets an entry on the worker_nodes table, therefore is unable to join with that name (with a not useful error message that the node already exists).

Also, we begin marking nodes with k8sd.io/role=control-plane or k8sd.io/role=worker, such that we know these nodes are managed by k8sd

@neoaggelos neoaggelos requested a review from a team as a code owner July 8, 2024 07:27
Copy link
Contributor

@bschimke95 bschimke95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, so in essence you moved the "bookkeeping" from k8sd to the workers themselves, right?

@neoaggelos neoaggelos merged commit 90d6d99 into main Jul 8, 2024
18 checks passed
@neoaggelos neoaggelos deleted the KU-1050/workers branch July 8, 2024 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants