refactor GetRemoteCertificate test #596
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eaudetcobello
force-pushed
the
eaudetcobello/fix-getremotecert-test
branch
from
1bcc99d
to
6a68df5
Compare
Because it relies on a specific error message, the test can fail under arcane conditions. Instead, test that an error occured. Also, drive-by gomega idioms.
eaudetcobello
force-pushed
the
eaudetcobello/fix-getremotecert-test
branch
from
6a68df5
to
ed65c98
Compare
addyess
reviewed
Aug 12, 2024
mateoflorido
approved these changes
Aug 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because it relies on a specific error message, the test can fail under arcane conditions. Instead, test that an error occured. Also, drive-by gomega idioms