Add worker token TTL #621
Merged
Add worker token TTL #621
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
addyess
force-pushed
the
KU-1414/worker-token-ttl
branch
2 times, most recently
from
e54f001
to
9d87f9c
Compare
bschimke95
force-pushed
the
KU-1414/worker-token-ttl
branch
3 times, most recently
from
cf54e39
to
83daee4
Compare
bschimke95
force-pushed
the
KU-1414/worker-token-ttl
branch
from
54b9ba9
to
bbf4d0d
Compare
masnax
reviewed
Sep 18, 2024
Comment on lines
+17
to
26
| // Note(ben): Never change the order or remove a migration as this would break the internal microcluster counter! | ||
| SchemaExtensions = []schema.Update{ | ||
| schemaApplyMigration("kubernetes-auth-tokens", "000-create.sql"), | ||
| schemaApplyMigration("cluster-configs", "000-create.sql"), | ||
|
|
||
| schemaApplyMigration("worker-tokens", "000-create.sql"), | ||
| schemaApplyMigration("worker-tokens", "001-add-expiry.sql"), | ||
|
|
||
| schemaApplyMigration("feature-status", "000-feature-status.sql"), | ||
| } |
There was a problem hiding this comment.
Looks like the addition of schemaApplyMigration("worker-tokens", "001-add-expiry.sql") did not obey the comment at the top of this function:
// Note(ben): Never change the order or remove a migration as this would break the internal microcluster counter!
addyess
reviewed
Oct 18, 2024
Comment on lines
+1
to
+2
| ALTER TABLE worker_tokens | ||
| ADD COLUMN expiry DATETIME DEFAULT '2100-01-01 23:59:59'; |
There was a problem hiding this comment.
@bschimke95 what if the table worker_tokens has a column named expiry already. Won't this fail?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add an optional TTL for worker tokens similar to #620
This PR requires the (backward-compatible) update in the k8s-snap-api.
canonical/k8s-snap-api#5
Once this PR is reviewed and approved, I will merge the API change, create a new tag (1.0.3) and update this k8s-snap PR to use the new API version.