Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds SnapRefreshRPC and node token authentication #636

Merged
merged 10 commits into from
Sep 6, 2024

Conversation

berkayoz
Copy link
Member

@berkayoz berkayoz commented Aug 29, 2024

Changes:

  • Added ValidateNodeTokenAccessHandler to authenticate per node endpoints
  • Added SnapRefreshRPC implementation
  • Update k8s-snap-api tag

Shouldn't be merged before canonical/k8s-snap-api#7

@berkayoz berkayoz requested a review from a team as a code owner August 29, 2024 10:42
Copy link
Contributor

@bschimke95 bschimke95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great work, added a couple of comments

src/k8s/pkg/k8sd/types/refresh.go Outdated Show resolved Hide resolved
src/k8s/pkg/k8sd/api/snap_refresh.go Outdated Show resolved Hide resolved
src/k8s/pkg/snap/pebble.go Outdated Show resolved Hide resolved
Copy link
Contributor

@bschimke95 bschimke95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Please address the remaining TODO/nit, then we are good to merge.

Copy link
Contributor

@bschimke95 bschimke95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

src/k8s/cmd/k8s/k8s_x_capi.go Show resolved Hide resolved
src/k8s/cmd/k8s/k8s_x_capi.go Outdated Show resolved Hide resolved
@berkayoz berkayoz merged commit 74d645a into main Sep 6, 2024
17 of 19 checks passed
@berkayoz berkayoz deleted the KU-956/snap-in-place-refresh branch September 6, 2024 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants