Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin k8s-dqlite version to tag #644

Merged
merged 1 commit into from
Sep 3, 2024

Conversation

louiseschmidtgen
Copy link
Contributor

@louiseschmidtgen louiseschmidtgen commented Sep 2, 2024

Description

This PR pins our main branch to the appropriate k8s-dqlite tag.
See: https://github.com/canonical/k8s-dqlite/blob/master/docs/versioning.md

Copy link
Contributor

@bschimke95 bschimke95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should not pin the version on master, only the releases

@louiseschmidtgen
Copy link
Contributor Author

We should not pin the version on master, only the releases

We will be doing some big changes in k8s-dqlite it will be best to pin ourselves to the most recent k8s-dqlite version

Copy link
Contributor

@bschimke95 bschimke95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, as discussed offline: pinning the version is the right decision. Sorry for the wrong call!

@louiseschmidtgen louiseschmidtgen merged commit 411275f into main Sep 3, 2024
35 checks passed
@louiseschmidtgen louiseschmidtgen deleted the KU-1471/pin-k8s-dqlite-version branch September 3, 2024 07:27
@kwmonroe kwmonroe mentioned this pull request Sep 13, 2024
34 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants