Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

k8sd cluster-recover: add non-interactive mode #662

Merged
merged 1 commit into from
Sep 16, 2024

Conversation

petrutlucian94
Copy link
Contributor

At the moment, the "k8sd cluster-recover" displays interactive prompts and text editors that assist the user in updating the dqlite configuration.

We need to be able to run the command non-interactively in order to automate the cluster recovery procedure.

This change adds a "--non-interactive" flag. If set, we'll no longer show confirmation prompts and we'll assume that the configuration files have already been updated, proceeding with the dqlite recovery.

@petrutlucian94 petrutlucian94 requested a review from a team as a code owner September 11, 2024 06:55
@petrutlucian94 petrutlucian94 marked this pull request as draft September 11, 2024 06:55
Copy link
Contributor

@bschimke95 bschimke95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

docs/src/snap/howto/restore-quorum.md Show resolved Hide resolved
At the moment, the "k8sd cluster-recover" displays interactive
prompts and text editors that assist the user in updating the dqlite
configuration.

We need to be able to run the command non-interactively in order
to automate the cluster recovery procedure.

This change adds a "--non-interactive" flag. If set, we'll no longer
show confirmation prompts and we'll assume that the configuration
files have already been updated, proceeding with the dqlite recovery.
@petrutlucian94 petrutlucian94 marked this pull request as ready for review September 16, 2024 08:26
@bschimke95 bschimke95 merged commit a47d342 into canonical:main Sep 16, 2024
19 checks passed
evilnick pushed a commit that referenced this pull request Sep 18, 2024
At the moment, the "k8sd cluster-recover" displays interactive
prompts and text editors that assist the user in updating the dqlite
configuration.

We need to be able to run the command non-interactively in order
to automate the cluster recovery procedure.

This change adds a "--non-interactive" flag. If set, we'll no longer
show confirmation prompts and we'll assume that the configuration
files have already been updated, proceeding with the dqlite recovery.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants