Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add version upgrade tests #678

Merged
merged 27 commits into from
Sep 24, 2024
Merged

Add version upgrade tests #678

merged 27 commits into from
Sep 24, 2024

Conversation

bschimke95
Copy link
Contributor

@bschimke95 bschimke95 commented Sep 17, 2024 •
edited
Loading

Summary

Adds an integration test to validate that a cluster can be upgraded sequentially for each release on each flavor.

Details

  • minor refactoring on how we inject environment variables in the CI jobs
  • use explicit path and not rely on $PWD
  • add new test_version_upgrade test that creates a three node cluster and performs sequential upgrades on each node
  • inject the branches for each flavour in the CI

@bschimke95 bschimke95 marked this pull request as ready for review September 19, 2024 11:52
@bschimke95 bschimke95 requested a review from a team as a code owner September 19, 2024 11:52
addyess
addyess requested changes Sep 19, 2024
View reviewed changes
Copy link
Contributor

@addyess addyess left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine... a few questions about python env vars

tests/integration/tests/test_util/config.py Outdated Show resolved Hide resolved
tests/integration/tests/test_version_upgrades.py Outdated Show resolved Hide resolved
tests/integration/tests/test_version_upgrades.py Outdated Show resolved Hide resolved
.github/workflows/integration-informing.yaml Outdated Show resolved Hide resolved
tests/integration/tests/test_version_upgrades.py Show resolved Hide resolved
addyess
addyess reviewed Sep 20, 2024
View reviewed changes
Copy link
Contributor

@addyess addyess left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bschimke95 the snap store is not careful about which architecture. use the arch of the instance that's ready to be upgraded

tests/integration/tests/test_version_upgrades.py Outdated Show resolved Hide resolved
tests/integration/tests/test_util/snap.py Outdated Show resolved Hide resolved
tests/integration/tests/test_util/snap.py Outdated Show resolved Hide resolved
HomayoonAlimohammadi
HomayoonAlimohammadi reviewed Sep 23, 2024
View reviewed changes
Copy link
Contributor

@HomayoonAlimohammadi HomayoonAlimohammadi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot @bschimke95! left some minor comments and questions.

tests/integration/tests/test_util/snap.py Outdated Show resolved Hide resolved
tests/integration/tests/test_util/snap.py Show resolved Hide resolved
tests/integration/tests/test_version_upgrades.py Outdated Show resolved Hide resolved
louiseschmidtgen
louiseschmidtgen reviewed Sep 23, 2024
View reviewed changes
Copy link
Contributor

@louiseschmidtgen louiseschmidtgen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work Ben! Two comments :)

@bschimke95 @addyess
Update tests/integration/tests/test_util/config.py
a920576 
Co-authored-by: Adam Dyess <adam.dyess@canonical.com>
addyess
addyess approved these changes Sep 23, 2024
View reviewed changes
Copy link
Contributor

@addyess addyess left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Pretty spiffy

@bschimke95 bschimke95 merged commit 6ce90fa into main Sep 24, 2024
18 of 20 checks passed
@bschimke95 bschimke95 deleted the KU-1463/add-upgrade-tests branch September 24, 2024 06:55
@addyess addyess mentioned this pull request Sep 26, 2024
Merged
evilnick pushed a commit to evilnick/k8s-snap that referenced this pull request Nov 14, 2024
@bschimke95 @addyess @evilnick
Add version upgrade tests (canonical#678)
d59f661 
---------

Co-authored-by: Adam Dyess <adam.dyess@canonical.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@louiseschmidtgen louiseschmidtgen louiseschmidtgen left review comments

@HomayoonAlimohammadi HomayoonAlimohammadi HomayoonAlimohammadi left review comments

@addyess addyess addyess approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bschimke95 @addyess @HomayoonAlimohammadi @louiseschmidtgen