Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add unit tests for coredns #684

Merged
merged 2 commits into from
Sep 20, 2024
Merged

Add unit tests for coredns #684

merged 2 commits into from
Sep 20, 2024

Conversation

maci3jka
Copy link
Contributor

Coredns feature lacks unit test this PR implements tests for DNS functionality.
KU-1515

Copy link
Contributor

@HomayoonAlimohammadi HomayoonAlimohammadi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing job @maci3jka, thanks a lot! left some minor comments.

Copy link
Contributor

@HomayoonAlimohammadi HomayoonAlimohammadi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks a lot @maci3jka!

@maci3jka maci3jka merged commit cfa7f99 into main Sep 20, 2024
20 checks passed
@maci3jka maci3jka deleted the KU-1515/unittests-coredns branch September 20, 2024 11:27
evilnick pushed a commit to evilnick/k8s-snap that referenced this pull request Nov 14, 2024
* Add unit tests for coredns
KU-1515
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants