Restoring the Microcluster Schema Migration history #689
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
addyess
reviewed
Sep 20, 2024
louiseschmidtgen
changed the title
There was a problem hiding this comment.
Thanks a lot @louiseschmidtgen! left a minor comment for discussion.
bschimke95
approved these changes
Sep 23, 2024
src/k8s/pkg/k8sd/database/sql/migrations/worker-nodes/000-create.sql
Outdated
Show resolved
Hide resolved
louiseschmidtgen
force-pushed
the
KU-1598/placeholder-migration
branch
from
ce17486
to
de12ded
Compare
berkayoz
approved these changes
Sep 25, 2024
|
@berkayoz we recently introduces a comment "don't change the order and only append to the migration" (https://github.com/canonical/k8s-snap/pull/689/files#diff-e146bb0bfd60417d271d4806b46753a797e5d4e2cffc7ac9a334c249311fb816R17) but seems like I didn't stick to my own notes :) |
louiseschmidtgen
added a commit
that referenced
this pull request
Sep 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Restoring the Microcluster Migration History
This PR restores our microcluster schema migration history to the original order.
Issue
We had an issue where the latest migration did not get applied: #634
Cause
The reason for this issue is that a migration was removed without dropping the schema version count. Consequently, when refreshing the snap the microcluster migration thought more migrations were already applied, leaving the latest migration un-applied.
Fix
This PR restores the schema migration order which will need to be back-ported into all 1.31 branches.
It is not good practice to remove a migration, this does not remove the existing table. A second migration should be in place to remove the table maintaining the accurate migration history.
Note on Prefix count
We should have labeled these not at all in the first place. It is not good practice to change the existing migration name (in case microcluster introduces checks around migration names). To stay consistent with the current naming I am continuing the current number prefix.