Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use map of struct instead of bool #693

Merged
merged 1 commit into from
Sep 24, 2024
Merged

Use map of struct instead of bool #693

merged 1 commit into from
Sep 24, 2024

Conversation

HomayoonAlimohammadi
Copy link
Contributor

using map[string]struct{} instead of map[string]bool for a very minimal performance gain.

@HomayoonAlimohammadi HomayoonAlimohammadi requested a review from a team as a code owner September 23, 2024 13:51
@HomayoonAlimohammadi HomayoonAlimohammadi merged commit a2c00fb into main Sep 24, 2024
18 of 20 checks passed
@HomayoonAlimohammadi HomayoonAlimohammadi deleted the nit-map-struct branch September 24, 2024 08:48
evilnick pushed a commit to evilnick/k8s-snap that referenced this pull request Nov 14, 2024
@HomayoonAlimohammadi @evilnick
Use map of struct instead of bool (canonical#693)
64dc68a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eaudetcobello eaudetcobello eaudetcobello approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@HomayoonAlimohammadi @eaudetcobello