Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix TiCS action's permission error #694

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

eaudetcobello
Copy link
Contributor

@eaudetcobello eaudetcobello commented Sep 24, 2024

make go.unit has to be run with elevated privileges since we now change the owner of /opt/cni/bin to root. See

if err := os.Chown(cniBinDir, 0, 0); err != nil {

This operation fails if make go.unit is run as a regular user.

@eaudetcobello eaudetcobello requested a review from a team as a code owner September 24, 2024 17:17
@eaudetcobello eaudetcobello force-pushed the eaudetcobello-patch-1 branch 8 times, most recently from c78e2ef to 4278c65 Compare September 24, 2024 17:38
@eaudetcobello eaudetcobello changed the title Update cron-jobs.yaml Fix TiCS action's permission error Sep 24, 2024
Copy link
Contributor

@addyess addyess left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks really good. Don't forget the workflow changes

.github/workflows/cron-jobs.yaml Outdated Show resolved Hide resolved
@eaudetcobello eaudetcobello force-pushed the eaudetcobello-patch-1 branch 2 times, most recently from d633f9e to 0a2010d Compare September 27, 2024 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants