Improve Nightly Test runs to pass #701
Conversation
addyess
force-pushed
the
KU-1609/repair-nightly-test
branch
12 times, most recently
from
ad8c14b
to
6172383
Compare
| @pytest.mark.xfail("cilium failures are blocking this from working") | ||
| @pytest.mark.xfail(reason="cilium failures are blocking this from working") |
There was a problem hiding this comment.
repairs a syntax error on this xfail call
| @cached_property | ||
| def arch(self) -> str: | ||
| return self.exec( | ||
| ["dpkg", "--print-architecture"], text=True, capture_output=True | ||
| ).stdout.strip() | ||
|
|
There was a problem hiding this comment.
yay! an instance can know what architecture its running on
| @@ -1,47 +1,46 @@ | |||
| [tox] | |||
| no_package = True | |||
There was a problem hiding this comment.
All these changes are to make this more compatible with tox 3. Why tox 3? Because that's what you get with apt on focal and jammy. Why not pip install it? Arm64 runners were having severe trouble loading python libraries from a virtual env on the GH runners for reasons i never was able to understand. I think it's a combination of running tox with sg but i'm not sure. LD_PYTHON_PATH got lost though -- using the system-wide tox improves this
addyess
force-pushed
the
KU-1609/repair-nightly-test
branch
from
6172383
to
77127b4
Compare
addyess
changed the title
| @@ -3,47 +3,43 @@ name: Nightly Latest/Edge Tests | |||
| on: | |||
| schedule: | |||
| - cron: '0 0 * * *' # Runs every midnight | |||
| pull_request: | |||
There was a problem hiding this comment.
🚨 Don't merge with this in there -- its just for testing this PR 🚨
| with: | ||
| name: ${{ env.artifact_name }} | ||
| path: ${{ github.workspace }}/inspection-reports.tar.gz | ||
| - name: Tmate debugging session |
There was a problem hiding this comment.
IMHO this will just extend the failed test for 10min. Nobody is looking at the nightly tests until they fail. The inspection report should be sufficient to reproduce the issue, if not, we need to isolate the failed test and add the tmate session as part of a draft/test PR.
There was a problem hiding this comment.
yep, we can take it out. I had it in there b/c i was tinkering and trying to learn why things failed but weren't in the inspection reports
addyess
force-pushed
the
KU-1609/repair-nightly-test
branch
from
44ade1b
to
86176e8
Compare
Overview
Resolves a number of tests issues the nightly tests were having to run effectively on arm64 and amd64 units.
Details
pytest.mark.xfailtox.inito be tox 3 and 4 compatible