Unit tests for contour k8sd feature #705
Open
+627
−67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
adresses also KU-1516 |
HomayoonAlimohammadi
approved these changes
Sep 30, 2024
berkayoz
reviewed
Sep 30, 2024
| g.Expect(err.Error()).To(ContainSubstring(applyErr.Error())) | ||
| g.Expect(status.Enabled).To(BeFalse()) | ||
| g.Expect(status.Version).To(Equal(contour.ContourGatewayProvisionerContourImageTag)) | ||
| g.Expect(status.Message).To(ContainSubstring("Failed to delete Contour Gateway")) |
There was a problem hiding this comment.
Suggested change
| g.Expect(status.Message).To(ContainSubstring("Failed to delete Contour Gateway")) | |
| g.Expect(status.Message).To(Equal(fmt.Sprintf(gatewayDeleteFailedMsgTmpl, err))) |
I believe we can just use the err returned from ApplyGateway to construct the entire status.Message.
| projectcontour := values["projectcontour"].(map[string]any)["image"].(map[string]any) | ||
| g.Expect(projectcontour["repository"]).To(Equal(contour.ContourGatewayProvisionerContourImageRepo)) | ||
| g.Expect(projectcontour["tag"]).To(Equal(contour.ContourGatewayProvisionerContourImageTag)) | ||
| envoy := values["envoyproxy"].(map[string]any)["image"].(map[string]any) |
There was a problem hiding this comment.
Suggested change
| envoy := values["envoyproxy"].(map[string]any)["image"].(map[string]any) | |
| envoyImage := values["envoyproxy"].(map[string]any)["image"].(map[string]any) |
Also we should check for envoyproxy and image to exist first, otherwise we'll do a nil cast/reference.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The unit tests for the contour feature are lacking this pr proves test coverage from 0% files, 0% statements to 100% files, 84.3% statements for github.com/canonical/k8s/pkg/k8sd/features/contour package.