Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix lint and sbom jobs #791

Merged
merged 2 commits into from
Nov 13, 2024
Merged

Fix lint and sbom jobs #791

merged 2 commits into from
Nov 13, 2024

Conversation

petrutlucian94
Copy link
Contributor

@petrutlucian94 petrutlucian94 commented Nov 13, 2024

We need to remove a trailing whitespace that was added by mistake as it breaks the linting job.

At the same time, the cilium rockcraft.yaml location changed after introducing a new version, for which reason we need to update the sbom generation script.

We need to remove a trailing whitespace that was added by mistake
as it breaks the linting job.
@petrutlucian94 petrutlucian94 requested a review from a team as a code owner November 13, 2024 11:47
@petrutlucian94 petrutlucian94 changed the title Fix lint job, removing trailing whitespace Fix lint and sbom jobs Nov 13, 2024
We changed the cilium rockcraft.yaml location after introducing
a new version.

We'll update the sbom generation script accordingly.
Copy link
Member

@berkayoz berkayoz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@berkayoz berkayoz merged commit 5b032a9 into canonical:main Nov 13, 2024
12 checks passed
evilnick pushed a commit to evilnick/k8s-snap that referenced this pull request Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants