Add registry mirrors, preload snapd and core20 #799
+326
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
berkayoz
force-pushed
the
fix/test-flakes
branch
from
ae452c2
to
5bdf803
Compare
berkayoz
changed the title
We'll add config options for snap preloading and local image mirror. At the same time, we'll make a little code cleanup.
We'll simplify the "instance" fixture a little and move the mirror configuration to the Registry class, adding a new method named "apply_configuration".
We'll mask the mirror credentials, adding a flag that sanitizes the commands or kwargs (e.g. stdin data).
We'll pass the ghcr credentials to our registry mirror. TODO: do the same for dockerhub once we have a docker secret registered on Github.
We'll need these logs in order to investigate mirror issues.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.