-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
charms docs: Add 1.32 charms release notes #913
base: main
Are you sure you want to change the base?
charms docs: Add 1.32 charms release notes #913
Conversation
508182b
to
ae67186
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great so far. Just a small nit on one of the links
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fantastic work @HomayoonAlimohammadi, I've got some minor suggestions.
@nhennigan is this the correct place for the release notes? Should they rather live under our top-level release notes section?
## Also in this release | ||
|
||
- Replace `AssertionError` with `ReconcileError` [#173] | ||
- Renames `annotations` to `cluster-annotations` in charm config [#198] | ||
- Add `kube-apiserver-extra-sans` option [#201] | ||
- Add worker `bootstrap-node-taints` setting [#215] | ||
- Enhance status visibility during cluster upgrades [#216] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can this join the bug fixes/ what's new section?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought that this does not really fit the "bug fixes" section since these are not really bugs. Also for the "what's new?" section these are too small IMO. If you agree, I think it's best to keep them like this. It was also inspired by what @nhennigan did for 1.32 snap.
I plan on changing the sidebar navigation so that we can see both charm and snap release notes. Once this PR is reabsed to include the 1.32 snap notes, I'll add my changes. The docs/canonicalk8s/src/_parts/install.md will also need to be updated to stable so I'll add that too. |
72d22bd
to
21d4831
Compare
@nhennigan It's rebased now. Thanks! |
Update charm channel to 1.32 stable. Reoganise the navigation side bar to be able to see both snap and charm release notes
Overview
This PR adds the 1.32 Canonical Kubernetes charms release notes.