Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix misnamed container reference in katib-ui charm #157

Merged
merged 1 commit into from
Nov 29, 2023

Conversation

ca-scribner
Copy link
Contributor

Changes katib-ui charm to correctly access the container by the container name, not by the application name.

Fixes #156

Changes katib-ui charm to correctly access the container by the container name, not by the application name.

Fixes #156
Copy link
Member

@misohu misohu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM although the bundle test times out ? I dont think its related

@ca-scribner
Copy link
Contributor Author

Yeah that's odd - I'll rerun the tests first to see if it just had a flake

@ca-scribner ca-scribner merged commit 311b36a into main Nov 29, 2023
13 of 14 checks passed
@ca-scribner ca-scribner deleted the katib-ui-fix-get-container-name branch November 29, 2023 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

katib-ui charm tries to access workload container by wrong name
2 participants