Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add terraform modules for katib-{controller,db-manager,ui} #240

Merged
merged 7 commits into from
Sep 24, 2024

Conversation

orfeas-k
Copy link
Contributor

@orfeas-k orfeas-k commented Sep 18, 2024

Create a terraform/ directory for each of the charms that hosts their individual Terraform modules. It follows the structure proposed in this spec and it is based on what was done in canonical/argo-operators#198.

To test the modules:

  • Clone the repository and switch this PR's branch.
  • For each charm:
    • cd into its directory
    • First run tox -e tflint to ensure that linting is correct
    • Create a juju controller and a model name kubeflow
    • Run terraform apply -var "channel=latest/edge" -var "model_name=kubeflow" --auto-approve and wait until the charm is Active and Idle.

Ref #236
Ref #237
Ref #239

@orfeas-k orfeas-k enabled auto-merge (squash) September 24, 2024 10:38
Copy link

@mvlassis mvlassis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that the "terraform-apply" command results in a Blocked charm in the katib-controller, katib-db-manager, but that's expected behavior since the proper relations are missing.

@orfeas-k orfeas-k merged commit da56426 into main Sep 24, 2024
25 checks passed
@orfeas-k orfeas-k deleted the kf-6232-add-terraform-modules branch September 24, 2024 12:56
orfeas-k added a commit that referenced this pull request Sep 24, 2024
Create a `terraform/` directory for each of the charms that hosts their individual Terraform modules. It follows the structure proposed in [this spec](https://docs.google.com/document/d/1EG71A2pJ244PQRaGVzGj7Mx2B_bzE4U_OSqx4eeVI1E/edit) and it is based on what was done in canonical/argo-operators#198.

Ref #236 
Ref #237 
Ref #239
orfeas-k added a commit that referenced this pull request Sep 26, 2024
…ules

feat: Backport terraform modules for katib-{controller,db-manager,ui} from #240 
Closes #236
Closes #237
Closes #239
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants