You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Right now kfp-profile-controller uses CompositeController as it is written for metacontroller-operator image version v2.0.4. This causes problem to resource-dispatcher as it uses DecoratroController written for metacontroller-operator image version v3.0.0+ (issue).
We should rewrite kfp-profile-controller to use DecoratroController so we can update metacontroller-operator image version to v3.0.0+. More about why do we have to change to DecoratroController is described in this closed issue.
In order to use DecoratroController in kfp-profile-controller we need to rewrite files/upstream/sync.py file. We can take inspiration from resource-dispatcher-image source code.
To Reproduce
None
Environment
None
Relevant log output
None
Additional context
No response
The text was updated successfully, but these errors were encountered:
Ideas for improvements
Currently we use sync.py file to specify the webhook's API. we push this file to the charm which makes it problematic:
we have everything in one file
we cannot have separate dependencies for the sync.py itself as it uses charm's one all the time
we are not testing the API with unit tests we just relly on integration tests for charm
The profile-controller itself has the same structure as resource-dispatcher . In there we decided to create a separate image for the resource dispatcher api, instead of pushing file to the charm. This allow us to resolve all the problems above. We can use the same approach fot the profiles controller. We need to keep in mind that upstream is organizing code in single sync.py file tho.
Bug Description
Right now kfp-profile-controller uses
CompositeController
as it is written formetacontroller-operator
image versionv2.0.4
. This causes problem toresource-dispatcher
as it usesDecoratroController
written formetacontroller-operator
image versionv3.0.0+
(issue).We should rewrite kfp-profile-controller to use
DecoratroController
so we can updatemetacontroller-operator
image version tov3.0.0+
. More about why do we have to change toDecoratroController
is described in this closed issue.In order to use
DecoratroController
in kfp-profile-controller we need to rewritefiles/upstream/sync.py
file. We can take inspiration from resource-dispatcher-image source code.To Reproduce
None
Environment
None
Relevant log output
Additional context
No response
The text was updated successfully, but these errors were encountered: