Decorator controller rewrite #342
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Libraries: OK
Libraries: Out of sync
and removed
Libraries: OK
Libraries: Out of sync
labels
DnPlas
reviewed
Oct 3, 2023
There was a problem hiding this comment.
Thanks @misohu. I understand that this change has to be done in order to fix other (unrelated) issues, and that makes sense, but I wonder what does this change mean for the kfp-profile-controller. This is just for understanding how the operator may be affected.
github-actions
bot
added
Libraries: Out of sync
Libraries: OK
and removed
Libraries: OK
Libraries: Out of sync
labels
|
Hi @DnPlas this should not affect the controller functionality vise. It just enables us to update the metacontroller to higher version. I dont think that the operator will be affected. |
DnPlas
approved these changes
Oct 4, 2023
Signed-off-by: misohu <michal.hucko@canonical.com>
Signed-off-by: misohu <michal.hucko@canonical.com>
misohu
force-pushed
the
KF-4401-decorator-controller-rewrite
branch
from
d266f5b to
d2adbfc
Compare
github-actions
bot
added
Libraries: Out of sync
Libraries: OK
and removed
Libraries: OK
Libraries: Out of sync
labels
|
Closing as a duplicate of #344 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#334
Changes:
Tests:
This PR resolves resource-dispatcher's issue as we can migrate to metacontroller v3