Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use get_charms_build_with_cache.yaml on pull request workflow #641

Open
DnPlas opened this issue Dec 17, 2024 · 2 comments · May be fixed by #642
Open

Use get_charms_build_with_cache.yaml on pull request workflow #641

DnPlas opened this issue Dec 17, 2024 · 2 comments · May be fixed by #642
Labels
enhancement New feature or request

Comments

@DnPlas
Copy link
Contributor

DnPlas commented Dec 17, 2024

Context

canonical/charmed-kubeflow-workflows#88 introduces a reusable workflow that allows the CI to build charms in their dedicated machines and with charmcraft cache enabled. These enablements improve the build time and ensure that the same charm artefact is tested individually, as a bundle, and published.

What needs to get done

  1. Add the canonical/charmed-kubeflow-workflows/.github/workflows/get_charms_build_with_cache.yaml workflow on pull request workflow
name: On Pull Request

# On pull_request, we:
# * always publish to charmhub at latest/edge/branchname
# * always run tests
# * always run builds with cache
on:
  pull_request:

jobs:
  get-paths-and-build:
    name: Get charm paths and build with cache
    uses: canonical/charmed-kubeflow-workflows/.github/workflows/get_charms_build_with_cache.yaml@main

  tests:
    name: Run Tests
    needs: [get-paths-and-build]
    uses: ./.github/workflows/integrate.yaml
    secrets: inherit

  # publish runs in parallel with tests, as we always publish in this situation
  publish-charm:
    name: Publish Charm
    needs: [get-paths-and-build]
    uses: ./.github/workflows/publish.yaml
    secrets: inherit

Definition of Done

The pull request workflow uses canonical/charmed-kubeflow-workflows/.github/workflows/get_charms_build_with_cache.yaml before proceeding on the publish and test jobs.

@DnPlas DnPlas added the enhancement New feature or request label Dec 17, 2024
Copy link

Thank you for reporting us your feedback!

The internal ticket has been created: https://warthogs.atlassian.net/browse/KF-6698.

This message was autogenerated

Copy link

Thank you for reporting us your feedback!

The internal ticket has been created: https://warthogs.atlassian.net/browse/KF-6699.

This message was autogenerated

DnPlas added a commit that referenced this issue Dec 17, 2024
This workflow enables the usage of canonical/charmed-kubeflow-workflows/.github/workflows/get_charms_build_with_cache.yaml
for this CI, meaning that the integration tests and publish jobs are now able to download charm artefacts and use them
consistently throught the various operations of this CI.

Fixes #641
@DnPlas DnPlas linked a pull request Dec 17, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant