fix: Add Persistence Agent ClusterRole and Binding #324
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Apply auth manifests for the KFP Persistence Agent, including the ClusterRole, ClusterRoleBinding, and ServiceAccount that allow the workload to get, list, and watch workflows/scheduledworkflows, as well as get namespaces. Signed-off-by: Phoevos Kalemkeris <phoevos.kalemkeris@canonical.com>
github-actions
bot
added
Libraries: OK
Libraries: Out of sync
and removed
Libraries: OK
Libraries: Out of sync
labels
Signed-off-by: Phoevos Kalemkeris <phoevos.kalemkeris@canonical.com>
github-actions
bot
added
Libraries: Out of sync
Libraries: OK
and removed
Libraries: OK
Libraries: Out of sync
labels
Co-authored-by: Daniela Plascencia <daniela.plascencia@canonical.com>
|
@DnPlas, I'm not really sure how we could catch this in our CI, given that this won't cause an issue right now (since we're deploying the charm with trust, the workload will by extension get all required permissions and then some). We could add a test to all of our sidecar charms to ensure that they also apply the Roles provided by upstream. But I think that the effort of doing that is exactly the same as just adding the required roles. Let alone the fact that if I remember to add the test, I'll realise that I need to apply some roles and I'll just do that. |
github-actions
bot
added
Libraries: OK
Libraries: Out of sync
and removed
Libraries: Out of sync
Libraries: OK
labels
DnPlas
approved these changes
Sep 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apply auth manifests (KF 1.8) for the KFP Persistence Agent, including the ClusterRole, ClusterRoleBinding, and ServiceAccount that allow the workload to get, list, and watch workflows/scheduledworkflows, as well as get namespaces.