-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add sa token component to kfp-persistence #349
Conversation
The kfp-persistence charms needs a ServiceAccount token to be inside the workload container to be able to start the service. The sa token component will generate the required token and save it in a file where it can be accessed to later be pushed from the charm to the workload container. Fixes #343
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So left one more comment which is more of base charm question as to if this should be the way to implement the component. The logic in the rest of the code looks good.
I will go ahead and deploy charms from the PR in order to verify the functionality. My understanding is that I should:
- look for the file that the component is expected to create
- check if kfp-persistence service has started successfully
Is there something else I should look into?
Hey @orfeas-k, I added a "testing" section in the description of the PR. Regarding checking that the service starts, in this case, we'll see the service starting just fine because in pipelines 2.0.0-alpha.7 it does not need this file. We will observe this dependency when we finalise the work in #331. For now just ensuring the file is there is enough. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work and collaboration @DnPlas, approving!
* feat: add sa token component to kfp-persistence The kfp-persistence charms needs a ServiceAccount token to be inside the workload container to be able to start the service. The sa token component will generate the required token and save it in a file where it can be accessed to later be pushed from the charm to the workload container. Fixes #343 * tests: use mysql 8.0/stable for integration tests
The kfp-persistence charms needs a ServiceAccount token to be inside the workload container to be able to start the service. The sa token component will generate the required token and save it in a file where it can be accessed to later be pushed from the charm to the workload container.
Testing
kubectl exec
check the files inside the workload container. Make sure you check thepersistenceagent
container and not thecharm
./var/run/secrets/kubeflow/tokens/<token name>
Fixes #343