feat: Add kfp-metadata-writer charm #350
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Libraries: OK
Libraries: Out of sync
and removed
Libraries: OK
Libraries: Out of sync
labels
orfeas-k
force-pushed
the
kf-4763-feat-metadata-writer
branch
from
19c9feb to
53927a5
Compare
github-actions
bot
added
Libraries: Out of sync
Libraries: OK
and removed
Libraries: OK
Libraries: Out of sync
labels
github-actions
bot
added
Libraries: Out of sync
Libraries: OK
and removed
Libraries: OK
Libraries: Out of sync
labels
Add kfp-metadata-writer charm that charms KFP V2 component metadata writer.
orfeas-k
force-pushed
the
kf-4763-feat-metadata-writer
branch
from
083cd99 to
c719175
Compare
github-actions
bot
added
Libraries: Out of sync
Libraries: OK
and removed
Libraries: OK
labels
orfeas-k
force-pushed
the
kf-4763-feat-metadata-writer
branch
from
089ace7 to
924e825
Compare
github-actions
bot
added
Libraries: Out of sync
Libraries: OK
and removed
Libraries: OK
Libraries: Out of sync
labels
orfeas-k
force-pushed
the
kf-4763-feat-metadata-writer
branch
from
924e825 to
275dc77
Compare
github-actions
bot
added
Libraries: Out of sync
Libraries: OK
and removed
Libraries: OK
Libraries: Out of sync
labels
Reduce idle_period from 120 to 30 to avoid huge amount of waiting and tests failing. A very large idle_period had as a result the wait_for_idle to time out due to one of the charms constantly doing expected `execute` stuff in these two minutes.
orfeas-k
force-pushed
the
kf-4763-feat-metadata-writer
branch
from
275dc77 to
a3db7cc
Compare
github-actions
bot
added
Libraries: Out of sync
Libraries: OK
and removed
Libraries: OK
Libraries: Out of sync
labels
Remove test_pebble_service_is_replanned_on_config_changed since charm has no configuration options.
github-actions
bot
added
Libraries: Out of sync
Libraries: OK
and removed
Libraries: OK
Libraries: Out of sync
labels
DnPlas
approved these changes
Oct 20, 2023
DnPlas
pushed a commit
that referenced
this pull request
Nov 20, 2023
* feat: Introduce charm for KFP V2 metadata-writer component * gitignore: Add venv folder * ci: Integrate kfp-metadata-reviewer charm * tests(bundle-integration): Reduce idle_period to 30 from 120 to avoid huge amount of waiting and tests failing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce
kfp-metadata-writercharm for upstream KFP V2 Metadata writer component. Details in the issue below.Fixes #348