-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Upgrade manifests to 2.3.0 #583
Conversation
12b6f5b
to
d3dbfd6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All changes LGTM, for testing this I deployed all kfp charms and checked the status, as well as their logs.
Since kfp-ui
is the charm that received the most changes, I focused on it and inspected the pebble logs. While most of it looks normal, I noticed two things:
- There is a
2024-11-20T04:12:03.662Z [ml-pipeline-ui] Failed reading json data from '/etc/config/viewer-pod-template.json': 2024-11-20T04:12:03.664Z [ml-pipeline-ui] SyntaxError: Unexpected end of JSON input
message. - There are a lot of warnings like
2024-11-20T04:12:03.686Z [ml-pipeline-ui] (node:15) Warning: Accessing non-existent property 'which' of module exports inside circular dependency
I don't think any of this is affecting the charm, but it's worth double checking.
Hey @DnPlas, thank you for taking a thorough look. For the first one, I have already filed this issue #603. This has been observed in EDIT: Filed an issue #609 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @orfeas-k , bundle-integration-v2
tests all passed locally
I can confirm the logs reported by @DnPlas do not affect the functionality
one thing missed: to upgrade the driver and launcher images in config.yaml
of kfp-api
charm. Note: we could use adding this to CONTRIBUTING.md since it does not come up in kubeflow/manifests
diff.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks @orfeas-k
Upgrade manifests to 2.3.0. For producing the manifests, instructions in the CONTRIBUTING.md file were followed.
This includes:
Fixes #580
Tests
CI is fails mostly intermittently due to #602 and #601. Locally, they are successful (I hit #601 only once which looks unrelated to charms changes). I 've also refreshed a CKF deployment with the PR's charms and ran some pipelines, the kfp UAT and also enabled a recurring one.