feat: add envs to ensure kfp-ui can show logs #605
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kimwnasptd
reviewed
Nov 29, 2024
There was a problem hiding this comment.
Tested this, alongside KFP 2.3 charms as described in #582 (comment)
Everything worked as we describe:
- The V2 Pipelines now preserve the logs, stored in the path of new
keyFormat - The V1 Pipelines keep their logs in the
output-artifacts, as described in Ensure kfp-ui can show logs from Argo #582 (comment)
kimwnasptd
approved these changes
Nov 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #582
Summary
Sets each of the following environment variables in
kfp-uito fix showing the logs after the workflow gets deleted:ARGO_ARCHIVE_LOGSDISABLE_GKE_METADATAARGO_KEYFORMATRemoves
ARGO_ARCHIVE_PREFIXenv var, as indicated by upstream in kubeflow/pipelines#11010.Testing
For testing, see #582 (comment)