fix: kfp-api observability integration tests #86
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note that this is against kf-16-release, not main, so publishing jobs will fail |
natalian98
reviewed
Jul 28, 2022
|
lgtm, but since it's for 1.6 release, maybe we could test on microk8s 1.22? What do you think? |
|
Totally agree that testing on microk8s 1.22 is a good idea, but I'll do it separately to keep cause and effect of any breaks clear if that's ok |
ca-scribner
force-pushed
the
fix-kfp-api-tests
branch
from
f8db6a1 to
630517c
Compare
DnPlas
pushed a commit
that referenced
this pull request
Aug 2, 2022
Fixed tests that were broken due to ambiguous relations
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates test to explicitly call out relations. Refactors tests for consistency with others.