Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add charm skeleton #2

Merged
merged 4 commits into from
Nov 15, 2022
Merged

Add charm skeleton #2

merged 4 commits into from
Nov 15, 2022

Conversation

nsklikas
Copy link
Collaborator

  • Change the template names to match the charm name
  • Remove template actions and config
  • Add github workflows

@nsklikas nsklikas requested a review from a team October 17, 2022 14:59
@agathanatasha
Copy link

I think you are copying the workflows from the other two charms. There were some errors. See my initial tests PR to update yours

agathanatasha
agathanatasha reviewed Oct 18, 2022
View reviewed changes
CONTRIBUTING.md Outdated
```bash
# Create a model
juju add-model dev
# Enable DEBUG logging
juju model-config logging-config="<root>=INFO;unit=DEBUG"
# Deploy the charm
juju deploy ./template-operator_ubuntu-20.04-amd64.charm \
juju deploy ./kratos-external-idp-integrator_ubuntu-20.04-amd64.charm \
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are using 22.04. You should also update charmcraft.yaml

@agathanatasha agathanatasha merged commit 8999666 into main Nov 15, 2022
@agathanatasha agathanatasha deleted the charm-skeleton branch November 15, 2022 02:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@agathanatasha agathanatasha agathanatasha approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nsklikas @agathanatasha