Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pin sniffio<1.3.1 #221

Merged
merged 9 commits into from
Mar 7, 2024
Merged

pin sniffio<1.3.1 #221

merged 9 commits into from
Mar 7, 2024

Conversation

addyess
Copy link
Contributor

@addyess addyess commented Mar 7, 2024

anyio has no upper bounds on sniffio, and due to a recent update now depends on a setuptools>=64.

So long as sniffio is pinned, reactive charms will still build

  • Various improvements to the functional tests and github actions within this repo
  • matrix runs against juju2.9 and juju 3
  • juju-crashdumps at the end of a func-test run

Copy link
Collaborator

@wolsen wolsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@freyes freyes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Waiting for the CI results.

.github/workflows/main.yml Outdated Show resolved Hide resolved
tox.ini Outdated Show resolved Hide resolved
@wolsen wolsen merged commit 6f70ad3 into master Mar 7, 2024
8 checks passed
@addyess addyess deleted the akd/pin-sniffio branch March 7, 2024 21:51
kwmonroe pushed a commit to charmed-kubernetes/layer-basic that referenced this pull request Apr 15, 2024
* pin sniffio<1.3.1

* Test with multiple juju cahnnels

* test on 3/stable and 3.1/stable

* test with juju2.9 using a constraints file on pylibjuju

* Constrain juju3 tox environment

* Functional tests build and deploy .charm files referenced from the bundle

* Artifact crashdump and error logs

* eliminate ci warnings and correct the crashdump artifact names

* remove /stable from artifact name
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants