-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pin sniffio<1.3.1 #221
Merged
Merged
pin sniffio<1.3.1 #221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wolsen
approved these changes
Mar 7, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
freyes
approved these changes
Mar 7, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Waiting for the CI results.
freyes
reviewed
Mar 7, 2024
freyes
requested changes
Mar 7, 2024
kwmonroe
pushed a commit
to charmed-kubernetes/layer-basic
that referenced
this pull request
Apr 15, 2024
* pin sniffio<1.3.1 * Test with multiple juju cahnnels * test on 3/stable and 3.1/stable * test with juju2.9 using a constraints file on pylibjuju * Constrain juju3 tox environment * Functional tests build and deploy .charm files referenced from the bundle * Artifact crashdump and error logs * eliminate ci warnings and correct the crashdump artifact names * remove /stable from artifact name
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
anyio has no upper bounds on sniffio, and due to a recent update now depends on a
setuptools>=64
.So long as sniffio is pinned, reactive charms will still build