Unpin setuptools for Python>=3.12 #224
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The version of setuptools pinned by the wheelhouse is incompatible with
python 3.12, to avoid breaking old charms, this patch unpins setuptools
only for python>=3.12
Fixes the following error at build time:
File "/tmp/pip-download-gg1zdrmr/setuptools_ebd74bdeeaf0421480a69f5448330f5e/setuptools/__init__.py", line 16, in <module>
import setuptools.version
File "/tmp/pip-download-gg1zdrmr/setuptools_ebd74bdeeaf0421480a69f5448330f5e/setuptools/version.py", line 1, in <module>
import pkg_resources
File "/tmp/pip-download-gg1zdrmr/setuptools_ebd74bdeeaf0421480a69f5448330f5e/pkg_resources/__init__.py", line 2191, in <module>
register_finder(pkgutil.ImpImporter, find_on_path)
^^^^^^^^^^^^^^^^^^^
AttributeError: module 'pkgutil' has no attribute 'ImpImporter'. Did you mean: 'zipimporter'?
ajkavanagh
reviewed
Apr 11, 2024
wheelhouse.txt
Outdated
| @@ -26,7 +26,8 @@ MarkupSafe<2.2.0;python_version >= '3.7' # newer pythons | |||
|
|
|||
| setuptools<42;python_version < '3.8' | |||
| # https://github.com/juju-solutions/layer-basic/issues/201 | |||
| setuptools<62.2.0;python_version >= '3.8' | |||
| setuptools<62.2.0;python_version >= '3.8' and python_version<'3.12' | |||
| setuptools>=62.2.0;python_version >= '3.12' | |||
| setuptools-scm<=1.17.0;python_version < '3.8' | |||
| # https://github.com/pypa/setuptools_scm/issues/722 | |||
| setuptools-scm<7;python_version >= '3.8' | |||
There was a problem hiding this comment.
This line may cause a problem; setupstools-scm is pinned for ever on later versions and not earlier ones; is this a typo from a previous commit?
wheelhouse.txt
Outdated
| @@ -41,4 +42,4 @@ netaddr<=0.7.19 | |||
|
|
|||
| # https://github.com/python-trio/sniffio/pull/49 | |||
| anyio<3.7.0;python_version >= '3.8' | |||
There was a problem hiding this comment.
These two lines also look a bit suspect.
Drop anyio and sniffio for python>=3.12, this allows them to be pulled in indirectly by whoever needs them instead of carrying them as part of layer basic
When TEST_JUJU3 is set, zaza will allow the use of python-libjuju>=3.0
ajkavanagh
approved these changes
Apr 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The version of setuptools pinned by the wheelhouse is incompatible with python 3.12, to avoid breaking old charms, this patch unpins setuptools only for python>=3.12
Fixes the following error at build time: