Add client library version for Qt6 #373
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Everyone contributing to this PR have now signed the CLA. Thanks! |
|
Well, now CI is building a version for Qt6. Tests fail just like in main; tests added for Qt6 also fail. |
Open
|
@robert-ancell, |
|
@Gliese852 yes, you will need to sign the CLA and you can use my name. Thanks! |
Gliese852
force-pushed
the
qt6-upstream
branch
from
492c705
to
6fdda91
Compare
|
Squashed the fixup commits to at the same time provoke the launch of CI, at least the cla-check is now successful. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I would like to port
lightdm-kde-greeterto qt6, and this requires the corresponding lightdm library.I did not delete the version for qt5, the versions do not interfere with each other. The source code has not changed much, just updated the outdated
QString::toAsciimethod.Added an m4 macro to search for the
mocexecutable file to check the version. It seems that this will be more reliable if there are several of them in the system. For reference, I used macros from thefreecivproject. (qt6.m4)